From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E506C001DC for ; Wed, 26 Jul 2023 17:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82D276B0071; Wed, 26 Jul 2023 13:19:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80D626B0072; Wed, 26 Jul 2023 13:19:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A48E8D0001; Wed, 26 Jul 2023 13:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5C00D6B0071 for ; Wed, 26 Jul 2023 13:19:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 17FE01A036E for ; Wed, 26 Jul 2023 17:19:20 +0000 (UTC) X-FDA: 81054424080.30.4EDCDC2 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 9D4D710002A for ; Wed, 26 Jul 2023 17:19:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="i2RDq/0o"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf14.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690391957; a=rsa-sha256; cv=none; b=bGRrj0Had1TsK1JRGq6ONY9xiU3lm7Dgb3x/RSA288OvB7HJWOT9e3P6AYeXoJsdJpesi3 Yq1JGFcya0ck2K273K8Npvl3B7W5RhKYvQerGcOENWMyQN4nWgFQm5x+jN8I0v1+OeIErT Nb/pEovBoCVkPpiZ1GYyEE/piUg0MSM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="i2RDq/0o"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf14.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690391957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ip3sa1zKMQ2zxWsxMFPxdq3PaMdI/MwxyZTVXbJTpvs=; b=Dd2VzLSEVivYG+hx6RzJs25OA9NP0EkeocXBRZYXhBPWi8VSlkpthyrDtSthTWYIApgvMI zt386SmUmE2witQdmD+DxagVVRN+ySZ0yvRBNlb1UZ4Fd6iXrLcc/CCh51jr07v9weULFf mMgzQ7y+PNtDbq7v4kX3xgNiXvGeE5g= Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36QGlQu6027300; Wed, 26 Jul 2023 17:18:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ip3sa1zKMQ2zxWsxMFPxdq3PaMdI/MwxyZTVXbJTpvs=; b=i2RDq/0ouE1p0Qk33YvTF/NHZO7HzDwmf4G6/X9boSMShdSMP7py+5eEipe35xBxMlaG MdcVym7bNRuamvdEEm03a7KedxDMBhu4/3t7mYSxCf6H2g1c16fbfn2afIlrjMD4BlqY xP9K0s7wqqxnYtklUY6zEPCt5WBxv5DWfKOuX9t4Dy/V4/ierZhWKSvTlbyhoxwnwNPq ndGmjKB2WdSLWa4i2eYGe9wKyhXrHRAbT8uzTpMFrHrRJNkGvm+Rc9VeKdzXH4EWUj1x /2Hf+Oh7Ysdzl9v2/c/1CZ2hi3Pwn8Avzu+8uGCTp8vnPqbIEM/iSFctK4eEqwNDg/D8 rw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s34x6gffc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jul 2023 17:18:39 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36QHIcJQ030805 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jul 2023 17:18:38 GMT Received: from [10.71.109.50] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 26 Jul 2023 10:18:37 -0700 Message-ID: <8f7ea958-7caa-a185-10d2-900024aeddf0@quicinc.com> Date: Wed, 26 Jul 2023 10:18:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Elliot Berman Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , "Michael Ellerman" , Anup Patel , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" CC: , , , , , , , , , , , Chao Peng , "Fuad Tabba" , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , "David Hildenbrand" , Quentin Perret , "Michael Roth" , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> Content-Language: en-US In-Reply-To: <20230718234512.1690985-13-seanjc@google.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: hvBAyKu5NMlIhf3rhtakVUP0GpxUNjz7 X-Proofpoint-ORIG-GUID: hvBAyKu5NMlIhf3rhtakVUP0GpxUNjz7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1011 phishscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307260154 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9D4D710002A X-Stat-Signature: yzcwizwjnxy4ogc8rgmi4qyasigmfzfk X-HE-Tag: 1690391957-871073 X-HE-Meta: U2FsdGVkX1+5++P0GIbtBfuhv2eyME9fpMkO6SgWU8RwhhnXwIONd8jcVPn50QXqDyJXbMxSlmPpgue2kHARbpSLCF5503+LDSQVKD7p9yBx+NqyBj6UuyX6/HUT2jy2mH89MRIJtjLmcqIeOVYiq26hWyPBW58JqXFptU1WZjsjJJBJWpEO2o+7KC1Ofa+5Mf9w9ql5i3PtWb6mZa4S09tVHrzb8ELjwLl1TSvFIvnrBIjyxP3eJpyrR0wYfqvvcNx4x/P83QLqtGtiF5+zBlf4KfLVPECf3PMICywXuvfbwcFjsPiudnJjh5NDYQoHFLxqLiuYIeuR+CI12AQg/tNNXQmhH4l/5XZqrZg8lv1v2I+Gc6SIRehF4VmTYQad9WCLDd25gDvGqwWwr45YHBPAQDNNMJWSluvb39jc/uoeKCKWKyabBXmBM5sifCIAAJOCUPq78eKUKFoNqBsKjm8PJS6PvZJQ6qxwSVqIov2SzWLLsXrrzivC7OHtifFLx3C3uCkbN0qlXlemqItnJsXSixQxkv+YUteIh6hGkheknX5fUIcCjhuDQ6G91rVsFrnxi8Ot4Ruc/MPpEg6P9nY9eRX33NKtMySgnfxAYAUx4AZpdXMIOmuV5b+idJF4LGWHt1MeuQQCG+SJ4j+jKCCaNOPpQJv3j0eEc1bMgdpSULaxKkfTcM+QZjQsOvxePfJc7YkuqSMUAz4D0GyYd7Y5vHm48NzUSxKhQf833DgvqzBRHDyo9G7nCOKaWaKWHjpnD7aTAbaSPrlMLYb0pANM9ZpKzeb40JrHkcYsX4eBtoN9E7F4Rqc+WbSX+PuCdiiURi+Lz3usSH8Tj7jCEBXOqAfuRVYCmDnpGImgoAfvYHfJ/5tX/lICTb20UF7VC4+wHnXmRGUFUtpR24YRBS5YnNma1AuxoExu3msCK5xVremIcbTNk4PlQ1huwnqi+mvk56XS84d/v4Rk5Yq kP22U10S XyaQcHbBgOIEWs2dBg4BNQpEOg4qyCGiWzulVzk6OmaB3jHoTqX8YAvppkmhSxiYMejX4Wph7Lg3cLI2UOKnn/g/fezKTstvMEqYRo32f893gTdY4/9tqnOgkWyPJPxzUOlMsSC+YuAEhC9Hx3CZltUqNGGoCgAk2mkYPt4YV6o8gp/GkgOnV4VV8Zw7rIKkbZspaI0nlwOF9flAR1ZrOUbPzcIgnhfN0mwPKti1x9RF8OTlVPhcqPSSWrpKQvCSjz1x0/aJ3ETywqkhwP57qqflnYpSglq0etl2kT3ApPwoJhFytBI4x+FFksEqjlpZvy1ZmA1YSknHgCho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/18/2023 4:44 PM, Sean Christopherson wrote: > TODO > diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h > index 6325d1d0e90f..15041aa7d9ae 100644 > --- a/include/uapi/linux/magic.h > +++ b/include/uapi/linux/magic.h > @@ -101,5 +101,6 @@ > #define DMA_BUF_MAGIC 0x444d4142 /* "DMAB" */ > #define DEVMEM_MAGIC 0x454d444d /* "DMEM" */ > #define SECRETMEM_MAGIC 0x5345434d /* "SECM" */ > +#define GUEST_MEMORY_MAGIC 0x474d454d /* "GMEM" */ Should this be: #define GUEST_MEMORY_KVM_MAGIC or KVM_GUEST_MEMORY_KVM_MAGIC? BALLOON_KVM_MAGIC is KVM-specific few lines above. --- Originally, I was planning to use the generic guest memfd infrastructure to support Gunyah hypervisor, however I see that's probably not going to be possible now that the guest memfd implementation is KVM-specific. I think this is good for both KVM and Gunyah as there will be some Gunyah specifics and some KVM specifics in each of implementation, as you mentioned in the previous series. I'll go through series over next week or so and I'll try to find how much similar Gunyah guest mem fd implementation would be and we can see if it's better to pull whatever that ends up being into a common implementation? We could also agree to have completely divergent fd implementations like we do for the UAPI. Thoughts? Thanks, Elliot