From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C156C77B7F for ; Sat, 13 May 2023 13:25:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B27836B0074; Sat, 13 May 2023 09:25:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7136B0078; Sat, 13 May 2023 09:25:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99EBD6B007B; Sat, 13 May 2023 09:25:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 870BE6B0074 for ; Sat, 13 May 2023 09:25:56 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4846A4111D for ; Sat, 13 May 2023 13:25:56 +0000 (UTC) X-FDA: 80785304712.02.C2DCB80 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 6ACC0100003 for ; Sat, 13 May 2023 13:25:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=LLWWTC34; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683984354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OZ9suH3ysp93knG+LU0uGT9RZVnxtGwdUs21az4sbeY=; b=r3qrWpPy/A/9JFmbvaZomlW/0A7oM4SdVGcNCDgUoNRej6MakSqsZ2sItwNu+CDYQhb9HK g1C6nnL6TJl6ASrfitHNAfWYeZn+9MpPDfHYM+I6kThkJZOzyftsofPm0fxD4X0NjarKBF Cd+4HRy/WjUuz6Qb/YyQVuK5pCfvfdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683984354; a=rsa-sha256; cv=none; b=BQNEnivFCf2IFfGnJg4S4uJruHoR7xwlGpHGU83vCIS/b+8aY+zwqscnOQzExQnP4KMwya yHGm1h4BkgblZGT9mXs5/fdJWIwmJtimftTj2xSmWPhLoO4Oo84snYw7QK+OaLnz2H+9aG ui3OKthBoqVkJbyQKgefrs1c62m9TD8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=LLWWTC34; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3f42ba32e24so37088655e9.3 for ; Sat, 13 May 2023 06:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683984353; x=1686576353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OZ9suH3ysp93knG+LU0uGT9RZVnxtGwdUs21az4sbeY=; b=LLWWTC34vSI3jpNT/zyl5RqzF/v1bIiGvyiYvrtMN8jjjzdEzIai/eiOraHQrauYam erId9ONSYr708J/L2MRSkt0ge+0hLyJr/N/u8r/cKralLyhjFzlX/6ki7aodxs7m7ZZG 3i7L/UK1r63y2DwYaHzCi4MKpkFoGA05F5gX/ji8gZuFn0ROx1bVlAs0foZWqb5BA6wn YvOT7j8Pz/zcfm0KXgYAuZQ81xmQTKOtAsjxWjFC9uH4oOvEhIlu8Hdk87BIfGe090t8 CpafDsH+CiRZ56wKFwMCQ+n19YJ0ZMUdYeC2F1Bd8gNmcAyC/gXUvAdIo6mb3m28mz8N KaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683984353; x=1686576353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OZ9suH3ysp93knG+LU0uGT9RZVnxtGwdUs21az4sbeY=; b=CBevP2ZT2edzRJJJ9814h8EjXfJCyjvMtjYwWp285jWlB9Cbockc0C79mdN3B0f2bY DyMYqPi7JrdDtCYTDEhaIf+lgqNhcP86pHQzMvNzfvQaI5gTK64YnyB3TGtcGAs6S+rK aBDMNkEHfHY452eSqaOcgFdVHCqD0YEQvpDDt70V2j7O/fmPUSOKkN+JAMsVbTRrq3Wn d+tf9WlrmlGwTrUSfupez/4FLNAXd2vlUXyghJUdXvp0eJ+QcJ/EE6JKj5nf8xuyLOFc b6f5b3VWbezbyOoYYm+iSCb2vImZ5m0mHPuwJsxNCiVFKwVhMVjH7F8HEN3zUvE/UP/C T+Yw== X-Gm-Message-State: AC+VfDwBoSR0he+BMvKHPGJDiTvKrb+Wkp+jpnE0dF8YkW37ZEfC7QEC 2X6dM5zYNID1TOufCVaBkNU+e1kG6hc= X-Google-Smtp-Source: ACHHUZ4Fz/9yo2Vm9Z/ZjMqmZaOp0EPZjKnAs/L7EDiSodi1OfaqFtGjEb2oM/fg3JKfA96SeGDvPQ== X-Received: by 2002:a05:600c:c6:b0:3f4:28db:f5ff with SMTP id u6-20020a05600c00c600b003f428dbf5ffmr13378158wmm.35.1683984352479; Sat, 13 May 2023 06:25:52 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id e3-20020a05600c218300b003f421979398sm20316940wme.26.2023.05.13.06.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 06:25:51 -0700 (PDT) Date: Sat, 13 May 2023 14:25:50 +0100 From: Lorenzo Stoakes To: Christoph Hellwig Cc: Kent Overstreet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: <8f76b8c2-f59d-43fc-9613-bb094e53fb16@lucifer.local> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: jqzirizqc9hyotg566gm61b6fr4m1b48 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6ACC0100003 X-Rspam-User: X-HE-Tag: 1683984354-456902 X-HE-Meta: U2FsdGVkX1+0BbohKzq/HfAZkQKMnQ9FjWaUnLcfsLL4R7nQgjJ+rV5Vf+yXDBoW8EABUT6eULXjWFTo4putJTrwwRZtQuCxVCyaTRw5+hQoTGocAgszYLemQ5hZSdnsDcitFq2wtd1bSy5yV1t23pCeS2eShLjAscBTWm/9+KfLTucDgmbXfC+IDUHOySw2UxFgTZ2bE9cvUfLL7maf0bfDLGtxNSXq+eqZ2DWfeEY93wMuXUzb9keE9F0ojxkY0HnYD7vGvrkK6Aa8/IGZVCqpV7FOm3vYQQoy1tc1vt6k+54aUySTDtybUUtKr/B/8MdDCXa7Y89K2iryxdgOFbl6Ija1OhYZYghRc5PkOScQJ5/sBTcKuUSh+ugOZZ7etIpWXDgSdDp1oyQkrl0w2IgT2rHsUJET42TiaJOzgrFbN6qnyjSbGsF4DbIFhtNsfrV2ZT5IMxiw52azN1/TW+PY9CvUOdtIgTECzOGn4ht0tcKWhcZvxEsPSYB6n4AlFWJ/vzSLDg+V067k7vIfRSaQElL4JhMHv7oTdCcWeKrar1vbM86PXVQzr/9Wdqzc0AEgY9c1TgsXslwaZ4H/Znwc8ab8GNOiugejqNavhmdfVZRqbowX+7LSh5LyBQZivRoQwQbom8bh3QHSBtatm7fbCdMv/29OVISrgoNk2CNkZEaH0QKHrbmlVHO96g0z/zpRsms36Ollrr2YZ38YnGv1tJAqSF/oaSiwBMmpC1gtCueT3x1I9WLHE4ZpxujRIqCX8IEUX3iFIsfEVGRT+n6Xp2fq3yMovhEIvOSFgSf/vfwW6tbgYl+CYHSFXYPOmqqX801wjS+IVvH/Z9tV/EDgNGzAwdbSo8H3+DZsbt0PQkejN+O8joJGH6uFHdGbj+CI/pVi3gEG75mJPzXwqlcLVs3yMaPEDp3VhgEFj9KtHAqXcgNHUiL2N2M3xc+MVOqJJqQKEHjwM+ea/RA 5RfB1OJK fMRqefEH8dSriM9owbehKdQyxETI81+XSceykOvjzpvR/Wn3+HbEb8CZ/1Nsq5v73MAi5L7zv4DDOMKWjpt5P+XTslAHQ6NoCzaSREz6yaPFLGW/blh4FXScwvMqOCUqv1HYDWpUgcYwd6PuzG/zgHSbDnIi+K20BnpbjaZoeuCchjl+CfqHESZMHqlJUslQuNWdyvrY5i0stSA89ydFqmGvOXnBWwThnKRbfP5qBLx4xNHavtTMiBVpATy+6QWzJQs8FYjDC+2VZTlrjTjH2Co7us5P1cmepMXngGqnZzN5AFu2cG3n+mUwHJhirI3Od9ar+gJtmvhXAp9Y9PEPOw84rbeYehQ3KO1ecU9c97+VOauj9xGGMaCeVDbwzunZb5SshW+08yXH38nfwn3903f9LpjEetnPBKmrUT59pqHziRwAdac8I64a7sboG4OVRWUebaDQjeoKVg2NjRJYRlG3Ms8GZSdZHg0U59/KXfYlLn/djY/E7VgjAaVvDydFTrGf6nvtP5iAXq5p20oy6F9379i0iXNsiCgam X-Bogosity: Ham, tests=bogofilter, spamicity=0.020095, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 09, 2023 at 02:12:41PM -0700, Lorenzo Stoakes wrote: > On Tue, May 09, 2023 at 01:46:09PM -0700, Christoph Hellwig wrote: > > On Tue, May 09, 2023 at 12:56:32PM -0400, Kent Overstreet wrote: > > > From: Kent Overstreet > > > > > > This is needed for bcachefs, which dynamically generates per-btree node > > > unpack functions. > > > > No, we will never add back a way for random code allocating executable > > memory in kernel space. > > Yeah I think I glossed over this aspect a bit as it looks ostensibly like simply > reinstating a helper function because the code is now used in more than one > place (at lsf/mm so a little distracted :) > > But it being exported is a problem. Perhaps there's another way of acheving the > same aim without having to do so? Just to be abundantly clear, my original ack was a mistake (I overlooked the _exporting_ of the function being as significant as it is and assumed in an LSF/MM haze that it was simply a refactoring of _already available_ functionality rather than newly providing a means to allocate directly executable kernel memory). Exporting this is horrible for the numerous reasons expounded on in this thread, we need a different solution. Nacked-by: Lorenzo Stoakes