From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8F0C32774 for ; Tue, 23 Aug 2022 07:37:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272C38D0001; Tue, 23 Aug 2022 03:37:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 222866B0074; Tue, 23 Aug 2022 03:37:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3B78D0001; Tue, 23 Aug 2022 03:37:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F0F5B6B0073 for ; Tue, 23 Aug 2022 03:37:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ACD9EABB94 for ; Tue, 23 Aug 2022 07:37:03 +0000 (UTC) X-FDA: 79830051126.16.223DA4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 21DC680031 for ; Tue, 23 Aug 2022 07:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661240222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HohlDOM1an5R3Aeg0WJ6GQRtA32+l/PSRz3n64TVcFI=; b=QoG+AdmEJFhLTazALmYxXOH4iLtqDgwci802sX/4jdTKKs4NhjaLT9ue+8poTKZKPJXvue nmFmdOgkspSXedAXE3I5BMh6OLPQRUNlV1ya9JXx0gqdD0KegS/uqTRaEsMtd4r2rdDQv8 MdDUr0stYsbatJPckuknEUldl2YOEEU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-290-WMafFWWCMu62HiROkuoKiw-1; Tue, 23 Aug 2022 03:37:01 -0400 X-MC-Unique: WMafFWWCMu62HiROkuoKiw-1 Received: by mail-wr1-f70.google.com with SMTP id t12-20020adfa2cc000000b00224f577fad1so2017467wra.4 for ; Tue, 23 Aug 2022 00:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=HohlDOM1an5R3Aeg0WJ6GQRtA32+l/PSRz3n64TVcFI=; b=BKWq2wEs4nJJnU80q6lkf2suRtCSlR9xLwYTd5JaW4YPFCnJBRWIwLqmYNDSQxzg7E GNAHcw3fwiaCNkWPOEK8eW83uxn4VIgtv6/iGnfnk9/X/blM3hDxQ6kuYaz1NTW2+Erf TZoJWYxhusaXS2f6i1gYGvPA2eWNWnYdQXW6qFQC674evdCtV8tg8GDxXwkMwGocZhbG xbVLfFuBAQDLM6wbcY0U5OCf75xFhMeMTGi2ljRqH1gEKoCGD4bin9J04rCz9yBwH0jq 4u6j6rWhyg4rpxoWxvPXu3z2kkyVI7KNfeHltYdpDniRETUq4DVkbs17C4UF0BwndB1c 9asw== X-Gm-Message-State: ACgBeo1axpdOQfyPawR048v6m2n8RM3qX7xamEXBK8OGXui3hj5haCT4 jBssFsZaf+1SlFdU0juPWSzh5uKfDtd6oM5f8BEnJWuPe1NiTN/NSWrJnuTDjwlmIJs//FTihZl 4qD9NNrq2KBg= X-Received: by 2002:a05:600c:4e04:b0:3a5:a34e:ae81 with SMTP id b4-20020a05600c4e0400b003a5a34eae81mr1210687wmq.147.1661240219969; Tue, 23 Aug 2022 00:36:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR4NUFG4IFicJqv+j50eM5lq6Rzd1ri/9X+RKdy6Bv7oWpP5THIKdol8DYBnS2vZ39y/40KufQ== X-Received: by 2002:a05:600c:4e04:b0:3a5:a34e:ae81 with SMTP id b4-20020a05600c4e0400b003a5a34eae81mr1210635wmq.147.1661240219655; Tue, 23 Aug 2022 00:36:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id u18-20020adfdb92000000b0021eaf4138aesm16379582wri.108.2022.08.23.00.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 00:36:59 -0700 (PDT) Message-ID: <8f6f428b-85e6-a188-7f32-512b6aae0abf@redhat.com> Date: Tue, 23 Aug 2022 09:36:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v7 01/14] mm: Add F_SEAL_AUTO_ALLOCATE seal to memfd To: "Kirill A. Shutemov" , Paolo Bonzini Cc: Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-2-chao.p.peng@linux.intel.com> <472207cf-ff71-563b-7b66-0c7bea9ea8ad@redhat.com> <20220817234120.mw2j3cgshmuyo2vw@box.shutemov.name> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220817234120.mw2j3cgshmuyo2vw@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QoG+AdmE; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661240223; a=rsa-sha256; cv=none; b=tWPV0wwLMTqCI/xUjLejuGr//1uDUs9EK0DPXY/DkSYuST7kjbYSjcSzzblyS59IUGhZN4 hQ/fYWcRWHr2G7sp/N6owqDvQk2Gb9Y0UYDLgkoZ8vkH0veS+Gu0YrUwelX83FnJPx9Tm3 NjmGmU97xnnfYlK97iSiXLbhVXM3II4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661240223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HohlDOM1an5R3Aeg0WJ6GQRtA32+l/PSRz3n64TVcFI=; b=j8iA5KHSgSbPGXwci9W4LzUHjAIujFzd9o2FHOA9n66ZOxl4DsoEc94m+A3Rzi7QygeMKU csXvVwzU9YWRPdOWMAUZXsZF8wziISNgPGS8RADszhDXdDLJcF/tKo2A99QFmSYbuyTVuX 5o7Wf/Tt4f9X4nUWauDN12ZE8zclxcE= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QoG+AdmE; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: udayynbp5mtzeozk6tcg5aygdh3xacym X-Rspamd-Queue-Id: 21DC680031 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1661240222-417894 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.08.22 01:41, Kirill A. Shutemov wrote: > On Fri, Aug 05, 2022 at 07:55:38PM +0200, Paolo Bonzini wrote: >> On 7/21/22 11:44, David Hildenbrand wrote: >>> >>> Also, I*think* you can place pages via userfaultfd into shmem. Not >>> sure if that would count "auto alloc", but it would certainly bypass >>> fallocate(). >> >> Yeah, userfaultfd_register would probably have to forbid this for >> F_SEAL_AUTO_ALLOCATE vmas. Maybe the memfile_node can be reused for this, >> adding a new MEMFILE_F_NO_AUTO_ALLOCATE flags? Then userfault_register >> would do something like memfile_node_get_flags(vma->vm_file) and check the >> result. > > I donno, memory allocation with userfaultfd looks pretty intentional to > me. Why would F_SEAL_AUTO_ALLOCATE prevent it? > Can't we say the same about a write()? > Maybe we would need it in the future for post-copy migration or something? > > Or existing practises around userfaultfd touch memory randomly and > therefore incompatible with F_SEAL_AUTO_ALLOCATE intent? > > Note, that userfaultfd is only relevant for shared memory as it requires > VMA which we don't have for MFD_INACCESSIBLE. This feature (F_SEAL_AUTO_ALLOCATE) is independent of all the lovely encrypted VM stuff, so it doesn't matter how it relates to MFD_INACCESSIBLE. -- Thanks, David / dhildenb