From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8D4C3DA64 for ; Tue, 6 Aug 2024 11:08:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9407D6B007B; Tue, 6 Aug 2024 07:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F0976B0082; Tue, 6 Aug 2024 07:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 743186B0083; Tue, 6 Aug 2024 07:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 552306B007B for ; Tue, 6 Aug 2024 07:08:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1ED71609AE for ; Tue, 6 Aug 2024 11:08:43 +0000 (UTC) X-FDA: 82421547726.27.31BD00A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf03.hostedemail.com (Postfix) with ESMTP id 5CA242002C for ; Tue, 6 Aug 2024 11:08:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q5CaJ0td; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MykqE4Bh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q5CaJ0td; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MykqE4Bh; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722942475; a=rsa-sha256; cv=none; b=3uolzJL5xXCmTipbPGh30S6LNjRPFI9QX1UlDNySm5LF66/l18ug8GgP7HfVsjEyeT/tkO ucEXjGN61tIXsXHmP5DZYiqJUIXxMefLfL0YAyp3CDdTCikWhfB5p7o4Wdp0sCj/87UK7J gMSJ46xjkz4V6GuGXad535zRmjiQ4pc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q5CaJ0td; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MykqE4Bh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q5CaJ0td; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MykqE4Bh; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722942475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=74A2Gq5YchB9c5c4oXkZu7v/z59QVoU6ktEL0jehpUA=; b=2SQykHgNDDb5LTs8sltZudl4yyrnnXJqcKb7Ty1saFg7azQ0Euv8yeapxANsGt6Oa5aalx nYOPfPqHJNasrkoc/3JKtz3H+SlQrhfLAeIGjZydQ2taX5q+y/j2IH4oV5vc5Lk1yL6hMt BiqM+pR5U/ef2bD0/BabsQci8aSNeLA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B91D21C86; Tue, 6 Aug 2024 11:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722942519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=74A2Gq5YchB9c5c4oXkZu7v/z59QVoU6ktEL0jehpUA=; b=Q5CaJ0tdnTriVIY1SHKoH0JXKN8iQ80mTnFT4P3Fg207nUmmGh8LDq0eBizOh7lCWPD6lc DChKhh93/xJQVH/PfNZdQtX+ZLy6oCigXQ8ShmbRU0kYCfbzW+pLRgk/xzJNIEPMJxPWg9 KnRg3fLoQLlxa5jcPjXnQMCZpXk6GlA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722942519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=74A2Gq5YchB9c5c4oXkZu7v/z59QVoU6ktEL0jehpUA=; b=MykqE4Bh96QBwI7ukg2vjMp23P0DAOCPL08u8fKFj7zRl8C1Fv+YCZ5IBy9pXalTV4jzzt sO2t8jVjOTF8/wDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722942519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=74A2Gq5YchB9c5c4oXkZu7v/z59QVoU6ktEL0jehpUA=; b=Q5CaJ0tdnTriVIY1SHKoH0JXKN8iQ80mTnFT4P3Fg207nUmmGh8LDq0eBizOh7lCWPD6lc DChKhh93/xJQVH/PfNZdQtX+ZLy6oCigXQ8ShmbRU0kYCfbzW+pLRgk/xzJNIEPMJxPWg9 KnRg3fLoQLlxa5jcPjXnQMCZpXk6GlA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722942519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=74A2Gq5YchB9c5c4oXkZu7v/z59QVoU6ktEL0jehpUA=; b=MykqE4Bh96QBwI7ukg2vjMp23P0DAOCPL08u8fKFj7zRl8C1Fv+YCZ5IBy9pXalTV4jzzt sO2t8jVjOTF8/wDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69A6B13770; Tue, 6 Aug 2024 11:08:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VWxvGTcEsmb1HQAAD6G6ig (envelope-from ); Tue, 06 Aug 2024 11:08:39 +0000 Message-ID: <8f5d3a92-f90c-4a0d-bd24-10dc49235afe@suse.cz> Date: Tue, 6 Aug 2024 13:08:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 12/20] kthread: Implement preferred affinity Content-Language: en-US To: Frederic Weisbecker Cc: LKML , Andrew Morton , Kees Cook , Peter Zijlstra , Thomas Gleixner , Michal Hocko , linux-mm@kvack.org, "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Boqun Feng , Zqiang , rcu@vger.kernel.org References: <20240726215701.19459-1-frederic@kernel.org> <20240726215701.19459-13-frederic@kernel.org> <4e9d1f6d-9cd8-493c-9440-b46a99f1c8af@suse.cz> <00914d25-f0ae-4b00-9608-2457821c071c@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: / X-Rspamd-Action: no action X-Rspamd-Queue-Id: 5CA242002C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yikxid9xaegqz5pkhdbswfngq3cnnzyy X-HE-Tag: 1722942521-603138 X-HE-Meta: U2FsdGVkX1+6DJn8UHuONyh+lMFxXb3mAC0vAHbpeUGlPgyceBvEvgSkcFie5bYuoDtnaEDKWm4EcO9wLcZ2Hx/nAJ4p1Tq42VLiNGFyfyzslYjqeFFb5EDtNkfh1vWaN/Ev4guQ8wVFoBm0PT+iPJNIDTo75EAY2niJou9BIgYaL11sJN/G15Etyuwu6G2R7B1CBRTBxVxw7837KZF8i/1VG+cVPuA1YJSTBLQyckwYUgeAYE+Pl1zxOhzSUn+i+hbsiIoISqQtvwo6iiMSTuqkY8Zpjwp1FlRrkXzU5q1SVl7UHRnvCorss9sDNAwdZOAhn9FFKrNYGH6LU0J8BqMNG6jgMecnYKiuVjSnUv2JaAdhlXVp6wY1ezvRfF77RFPLqXbXwnGrec/0RWX6whR0seW2wJo3Fu7NMnUuSYweC7ZzudSSJvyCK4F6DofUCT5JixIeULLKH+t4AWNdyzDerzU+qr85gG1Fv5l7uNBd1MUQIaYL6k6t0PPr/u4MbOQUPxe9tp6klPqwBk9mm3k3jnTUWAiJfH6sJga+DdiX1b/Yd8mCojeUrjA/ROW8BATchsp+LY+QnYl5tG9Fo3pas8p404BfRhTMNb8JEO2i4gEWPHwyvbHMP/viHazb6bSwXBSkz1AbMG+r5ZSy7maGq6e3CWdgmLhJ8MQo/lMxRwuK3Ey2/J1xIFmq9EGeuWfl0lza4UIOpmlf4RTmqLgv6lDwzz80OK/QNIo4GaKf72hcp+b5VLhyJ7A7y5ehG0py8yf6pjzBXjadBwP0bux3dw2mXMVC4R97eunkbvPfG1osfqNl7+68/lNY1Ax0+DM/fRfm1Kb95XnSUWlYKS+EmTwDK4QTOPDZDyFeNxl1hsHFdqDgFXBgSUmlXrZ3KoGUe8v4fBT82wpjApV7Z9GiE17bRwptarA1hZwVEbwnBzqRDwv3tWh9NUb7F4EcE2IG34yO9IksEXF97Yp Kh+sKvRO 9Nah+fzRpX+XCP1lj+zdP9B4OxfNQPcz/hGmTaskb0HphZPN71Ic+ngcrlxcDnlNM4e5EhuQHLIWvd4ocQLz/XlqTEzgBHz70ueiakOcHbBq1//8dr8c4+C3VEFb1lubhVs2/fD2H9yRGkmuRdPz0G4WCQvlIyG2IS7UMfNy2WPP20lzsy8QBBsO956tiPJq/mhRnGKhwB4dyp9Evvkiv2oHcdjct6E5LmoRDuTGBrceWYX2H2PGJjIVU/8sRrNFqQCzPBl4PRZvGMz2B2wSfUYzpj9dp3+wuVizCqAswXhpZcnPQrcrZ4ncYnF3V/HODyen0tTjxJavfdOPEj1vvRAy46A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/6/24 01:59, Frederic Weisbecker wrote: > On Mon, Aug 05, 2024 at 11:25:59PM +0200, Vlastimil Babka wrote: >> > It's too bad we don't have a way to have a cpumask_possible_of_node(). I've >> > looked into the guts of numa but that doesn't look easy to do. >> >> That was my impression as well. Maybe not even possible because exact cpu >> ids might not be pre-determined like this? > > Probably. > >> >> > Or there could be kthread_set_preferred_node()... ? >> >> Possible instead of the callback idea suggested above? >> kthreads_hotplug_update() could check if this is set and construct the mask >> accordingly. > > Or even better, callers of kthread_create_on_node() with actual node passed > (!NUMA_NO_NODE) can be preferrably affined to the corresponding node by default > unless told otherwise (that is unless kthread_bind() or > kthread_set_preferred_affinity() has been called before the first wake up, and > that includes kthread_create_on_cpu()). Sounds logical and great! > There are a few callers concerned: kswapd, kcompactd, some drivers: > drivers/block/mtip32xx/mtip32xx.c, drivers/firmware/stratix10-svc.c, > kernel/dma/map_benchmark.c, net/sunrpc/svc.c > > After all kthread_create_on_cpu() affines to the corresponding CPU. So > it sounds natural that kthread_create_on_node() affines to the corresponding > node. Yes. > And then it's handled on hotplug just as a special case of preferred affinity. > > Or is there something that wouldn't make that work? Hopefully not. > Thanks. > > >> >> > Thanks. >> > >> >> >> >> > Thanks. >> >> >>