From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1884CC4167D for ; Tue, 12 Dec 2023 13:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAF846B02D4; Tue, 12 Dec 2023 08:21:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5FE56B02D5; Tue, 12 Dec 2023 08:21:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900BC6B02D6; Tue, 12 Dec 2023 08:21:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8017C6B02D4 for ; Tue, 12 Dec 2023 08:21:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5635F16098D for ; Tue, 12 Dec 2023 13:21:04 +0000 (UTC) X-FDA: 81558226848.17.EB2EBC6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 0EA28100017 for ; Tue, 12 Dec 2023 13:21:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/KAcA9q"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702387262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/teg7loHbVYD4Q/M0QxS5AQ4Il37BNIB0Gfukc5nhb0=; b=B2qk70wEx7lGBtGtf4PyqlQI9jmM13q11D61wTK+/vpH6tb/Gao/nYRe3xTioxCyK4H859 g2ycAZbsJi7U0Puaw0vPShiqjjx8wtpJ5DYHo7ynvZcVr1gROgqDNG2xhMeMIlmkYJY7Sc zYcMAYd8YkMizDuO0Mp/3XFH02cmsP0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/KAcA9q"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702387262; a=rsa-sha256; cv=none; b=4sQMqJfX+WpO5B5dkZ0UvJYAJjA60CMCzo6yKE0Y83ZcEnmp1/UBzbEO6ewfe5g1fC3Y5q 6pEG9HQUi+8S3IH9s4Qm04dR55QJmOPfhmbljQ1hk7nx1LwDJi7cjmyagzWOGzn+AJNQMp 9LsOp3VZq8YDtIXpuDmy861SvQfMa/w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702387261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/teg7loHbVYD4Q/M0QxS5AQ4Il37BNIB0Gfukc5nhb0=; b=S/KAcA9qnYfVvxmsinNe+V63Hif7JUotoEHBx7Zu+x151eq+utPMjGtPO9VOjJaP65p2ga eIU7OaT0kQ000l3MrAczIaF0N3cSg2iX7OF2yPy4jW8ZKh5wKs3Iin2pFWOBeMrw2TW9AO 5uEV6gXiFPTutO9orKc4tQLZ0lYdWIU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-b_MO62n7OyibMC9Ib0uB4g-1; Tue, 12 Dec 2023 08:20:59 -0500 X-MC-Unique: b_MO62n7OyibMC9Ib0uB4g-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-334b645998eso4274194f8f.1 for ; Tue, 12 Dec 2023 05:20:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702387258; x=1702992058; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/teg7loHbVYD4Q/M0QxS5AQ4Il37BNIB0Gfukc5nhb0=; b=likWuHAdxX6gCl7pVbfgQ7SWy/u4yYmXJ4vXmTVYuW4eKWVb1mLtV0iCKYJJFtv+yw SajhbWNkgTUEZZyv7vaGlR2zv9NEvyXhDMo4vLRYFyGUabaErsLsTJlz1mi4pq5YoeGQ v/ZzjNfFD5fdRlFl+n1uH5FTvONfx9Lsg9EUaBRsPLFimJCN/dNWLeLCwhQe1inJlXSf epRU0buJtXngP0nHySWluruxotwDZJtkqkwpn/Uz2WE7gsyrlDWhxR7m9uHDRMXEC8Qj Pb+onApu0bk4rAiNHCpuFJgN+D0gXewy42mTUIwO8DX36b2zdKJNrvQNCRk3THjZj6Yt tR7A== X-Gm-Message-State: AOJu0Yzv6kusnPr7vHLFuLuY8v92YWOcbsfPFuaueME8fIWC4nwWvMel pXrc5yGFvtC3YeNgA+Tb5bf+Q/5eJHRMZntjsSjxvo6IOHPgIr2giZfDob2LCEX56wHCB75XHTU R0jfNh2Fwyhk= X-Received: by 2002:adf:e302:0:b0:32f:6fc3:7963 with SMTP id b2-20020adfe302000000b0032f6fc37963mr2700060wrj.15.1702387258673; Tue, 12 Dec 2023 05:20:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0/4PBFfOIdQKLSJgtzBjR1HW8G3cobEdxk7BEWQmHkNb2lsonIqSqmieKkG4XDQOhDS1lGw== X-Received: by 2002:adf:e302:0:b0:32f:6fc3:7963 with SMTP id b2-20020adfe302000000b0032f6fc37963mr2700056wrj.15.1702387258361; Tue, 12 Dec 2023 05:20:58 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id v14-20020a5d4a4e000000b003333541a5bdsm10845248wrs.80.2023.12.12.05.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 05:20:58 -0800 (PST) Message-ID: <8f53f722-5382-4c54-a9b1-bf8103616493@redhat.com> Date: Tue, 12 Dec 2023 14:20:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] mm: Remove references to page_add_new_anon_rmap in comments To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-7-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231211162214.2146080-7-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0EA28100017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: it3fr3ryosrkxp85w9d674ymjufqn7zh X-HE-Tag: 1702387261-63662 X-HE-Meta: U2FsdGVkX1+uK5ZRf3QWI086fdtvucn6PxecTFTonPpCJzgd2agZ9u+Xaj4KBJsi4xvkqUHa1MmRU48onDODr06MnNZ+JyTb1c9v5HMyQOcTT7fushsAHwDReoVmHncU+4TbMHnzmRbBTqcTCnijT1cShxUvMS8RQTc5hxkLSnLGfvRfUJD4fQP12JMtxFcAGwxXW1b/AggYxosu3io2f6BMur4iAfgbTo0h5rMYQbGy+PwL66OvDw4N2O4kbq63cr2bhlb/Yy9ULkEftpazdU/n2HpT1eLFbOaRc4H59J8jJQX+xlSOORD0CAwpd4E73zBSTc2i+DBTNrp8q5F4jeY7Zo7DfIbHEt8dPJRLdaVyFsZDkbElvSWA0kLes1pqwXS5/3m19tQFuSnLViL6irAf3BdnyrGisaMRrhbZKGse3yHU5lUFOZOOSbz7eFQhChyqC8DoiDsFjXMGg9S4oNmZQGEdZCuvXjYCoEWGl0AISZrRHRq63m1tC+GNbbrwcI9e1ny+paFjy89faKnCZCnFGki3qdkVC6wVZhSgd1j7kfWqUdj13iDC3cm1bDlTn5qGQ884GM/5Yv/KM875XRBfbx1m4b4oh7nYDDpeRlv49Ls4QIQh+DRwSFCrIJJ9WkTLY5EcGozJQZAO8ULO/TS/vJH6udY/tpgiuGTWlvOG6SEp+NG+uWrSnq92YeoxxjFpREe632yw5xyShKZP0dPEWkgS7u8cJwT/9R2cVE4Y6FEdrKwr0XS4bTMGz3lnSaKGYJaw4ymzGXk/vuIkmhYdAQJIPXpbIJKR7saaDStNy9qOvG1fLhjYbP7vZM0nlVujq+MpVWjwwY6wpQX9xX7/qU/8zhJn1oKP7kQFQaiJI+iR6/gitxANy0NvVnXdpbs+HTtlGbjpgoXcv0QIh4Fdq8YLYtEu7fNBgTzSOEZpn3Heqnr33+dZN23FcCJyT8kQxEAhB/r00kye52F dIm1GYbu GuI8RHf+Es4K7SLnoSl9LhNAP619kRtQ1GJPpjGRhdSaktpgVT+0Efp+isj4L/0/919hqOj8G/nGVv7qS7CyidcWFvjcHTxOmUnso1zk608C0MYwG7fZfceGpi+D3ttAoM07B1XMnJzfnqLBQWjdcfoSiU6FvCQZ4G0eSlhP7eMf65S0YQEzQ53yiVXQPRfH4QgvMo0a71HU6Ql/dx5i/qTXSvPe+PGSeO1RvdCjom7BfMaztTAtaY/c2KOzFnb30+77GjzBGp06tpvIcxCEWpFkSfQDZIWSdCEhopBU63iH3/HDIJRaLjo3zoe/YDY2hbc6nRohybH/H2h8GweJmOFYwx6i/9kTz0lGF5jW/Ymf9xXrNqRJrDwf0SwxbcOHv1aOF4gRsMN+bKuZu1QCuTYwmCqFBF7X29TY6MMLWzMru6yfDrbGzPIOZO/nSxiKfC/8uYiuPssZBo7bRdNQZH+8ml+65UVYbU+pLsMCwWmRM7yMH8mg9xAhIjhXL+A9HZA/+BUy2U69jWwX5tGhlD7w3IrWYZitCQoM2UmbUBIFNyLY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.12.23 17:22, Matthew Wilcox (Oracle) wrote: > Refer to folio_add_new_anon_rmap() instead. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/rmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index de9426ad0f1b..f3d49ec197ef 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1231,9 +1231,9 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page, > * We have exclusion against page_add_anon_rmap because the caller > * always holds the page locked. > * > - * We have exclusion against page_add_new_anon_rmap because those pages > + * We have exclusion against folio_add_new_anon_rmap because those pages > * are initially only visible via the pagetables, and the pte is locked > - * over the call to page_add_new_anon_rmap. > + * over the call to folio_add_new_anon_rmap. > */ > VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root, > folio); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb