From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB2BC433F5 for ; Tue, 8 Mar 2022 02:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B6678D0005; Mon, 7 Mar 2022 21:36:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 266C88D0001; Mon, 7 Mar 2022 21:36:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12DA28D0005; Mon, 7 Mar 2022 21:36:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 0589A8D0001 for ; Mon, 7 Mar 2022 21:36:57 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A50EC182E52FD for ; Tue, 8 Mar 2022 02:36:56 +0000 (UTC) X-FDA: 79219656432.28.763B69B Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf20.hostedemail.com (Postfix) with ESMTP id 44B4A1C0003 for ; Tue, 8 Mar 2022 02:36:56 +0000 (UTC) Received: by mail-qt1-f176.google.com with SMTP id s6so11703163qtc.4 for ; Mon, 07 Mar 2022 18:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=Hf+SYcbvteaeA2Pp6oDme8UIQyTPeK300MDHIaaOJZs=; b=ddfciQmjYws8TUQ+/R/l2Asz2YolMt5+q4M9T2HVYx71KxRMPoCtDjXQqbqmrofW+O 6BSZ6QC6hch7vERGe39Zn4XHaAmt6t8SBRvjFBLKlC/CMwIttICPXGUFpxUo0iVpeXYs hGCqsnR7cc7LlFGnRuBbDw6fLaS9vQ34vAQk0mkHdh6Lqhu9L3rFp0bVCCadprImKh0Q J+ioin83OmVlxhyTxiysTHxbrulkAwRebUGfdEqPNkjTimBUrlsa+U2o8CnUybkReH8r WdyIf7HzSF6u8TtgstJVKH575D0A9SAlqlZ40+vnKM+on21c+25NbegzssllsiPQGlmE 614Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=Hf+SYcbvteaeA2Pp6oDme8UIQyTPeK300MDHIaaOJZs=; b=ZqeJlTTb9b8DqMJP4fQnUNmNcnkjKIuDdQUs2bm3mTHt2TBK1La/55EWCT9xcK2Wj9 h4HktjhylWRIOBYUHwTlPYKnLaHoyt4KbKhk3xN2QkLEdQxmkAmQD2g/6i5vd5wF4Pyr BHNHOL0SHNaEmB/FAStJ/zTHwtFrUF2O+TxpFpGKphyD7jC3XDtNiwthX7VaIIkaZot1 9xDv4UQmJmbklc2G1RKcF4HjUa6yULZwv2xXn7Fs64ovpEKCNmH18Z4gQ2umq1ppIfr5 2WF4YtC8wQNC+3zgRU1sukhHfZtHMpOA7WSqeT8uFz48zHinbva4eo3hhAoicMs5MVp8 rGNQ== X-Gm-Message-State: AOAM5310mq7pWlJFd72Mj6nrL4pHxJ0b/NVABY0No8CEWE3tAhzb8a93 bd/3IPNHRyi+85/7acoDwslu8Q== X-Google-Smtp-Source: ABdhPJzwqDRLZOGcQ9TZx0OXr0dzVAXSP9SxhUKKJk0EWgDs+aK5wBK51LJq9ZwVoorkwZB6yjfZYQ== X-Received: by 2002:ac8:5dcf:0:b0:2df:f2e8:1b89 with SMTP id e15-20020ac85dcf000000b002dff2e81b89mr11892381qtx.632.1646707015401; Mon, 07 Mar 2022 18:36:55 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id m10-20020a05622a054a00b002e049ff99f2sm8752998qtx.7.2022.03.07.18.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 18:36:54 -0800 (PST) Date: Mon, 7 Mar 2022 18:36:42 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Andrew Morton cc: Yang Shi , David Hildenbrand , Andrea Arcangeli , Hugh Dickins , "Kirill A. Shutemov" , Linux Kernel Mailing List , Linux MM , Matthew Wilcox , Naresh Kamboju Subject: Re: [PATCH] mm: thp: don't have to lock page anymore when splitting PMD In-Reply-To: <20220307165015.77fbcbe9e1fa2fe15f3eb239@linux-foundation.org> Message-ID: <8f419d19-c83d-bbcd-8936-2d64ced7464c@google.com> References: <20220303222014.517033-1-shy828301@gmail.com> <13ad4ba1-2a88-9459-3995-70af36aba33e@redhat.com> <20220306180718.6d4e6233130b94fdad98df88@linux-foundation.org> <84a6c9c1-d18f-6955-2666-0a2d7bce6094@redhat.com> <20220307154326.6494f7fca7def491a23e5df1@linux-foundation.org> <20220307165015.77fbcbe9e1fa2fe15f3eb239@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: 5r3gz5bf3zmqyb8jbdhr8pi8p6dzspoo Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ddfciQmj; spf=pass (imf20.hostedemail.com: domain of hughd@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Queue-Id: 44B4A1C0003 X-HE-Tag: 1646707016-650282 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 7 Mar 2022, Andrew Morton wrote: > > OK, looks sane. Can someone please test all this? Only the briefest of testing, but mmotm 2022-03-06-20-33 minus mm-thp-dont-have-to-lock-page-anymore-when-splitting-pmd.patch plus mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch plus mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd-fix.patch is infinitely better than mmotm 2022-03-06-20-33. I could just about reach a login on yesterday's mmotm, but graphics no. Couldn't spend time to investigate, but Naresh's mail today that LTP thp04 timeouted (hey, I'm English, we say timed out!) inspired me to try booting with transparent_hugepage=never on cmdline, and that worked. Again, no time to investigate, but the combination above has booted and is running load, including transparent hugepages. And before setting that load going, I did try LTP thp04, which passed. (There is an unrelated console printk lockdep spew, and am I the only one to see these mm/workingset.c:567 shadow_lru_isolate warnings that started up a week or three ago?) Must dash, Hugh