From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB200C021B2 for ; Sat, 22 Feb 2025 11:00:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 800636B007B; Sat, 22 Feb 2025 06:00:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B0736B0083; Sat, 22 Feb 2025 06:00:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69E666B0085; Sat, 22 Feb 2025 06:00:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F43C6B007B for ; Sat, 22 Feb 2025 06:00:56 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EB7498128B for ; Sat, 22 Feb 2025 11:00:55 +0000 (UTC) X-FDA: 83147288070.12.F7CD014 Received: from pv50p00im-ztdg10021801.me.com (pv50p00im-ztdg10021801.me.com [17.58.6.56]) by imf30.hostedemail.com (Postfix) with ESMTP id 0BE7680012 for ; Sat, 22 Feb 2025 11:00:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=HhStBCZN; spf=pass (imf30.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.56 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740222054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UhO/oKP5iMw5fHjgaGRWOOpphrslB5BPutH1Bqw2Dkg=; b=ohhg+LopTmWpeBU2Rc81r/g+qBP1v/eIwXpWjf1RAmzCvezoa51wQLXIDA+jNuj0uJybSc ERRRePYcafbd/OYGkRMrbZvNsyGUMzrf4GeI1nea5RtFlmiwyNOwlEjVdgX8q/z5JEM0Ji eK8q+0JmzIstWFjD8DyTA9jBnCTwnE8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=HhStBCZN; spf=pass (imf30.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.56 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740222054; a=rsa-sha256; cv=none; b=UKwOS+rgaPWxHHttzJDbIP45ufLhfFhmPW7JeJq+A7PNRWBEP2U6KdQCNoLE826uSpLrHo TPKZxQakR1aoCJFdUS2cZOVHd/6AzOv4Jw6rF6f+BAts2fbBhKXWx42xJCk317bk8vXxgV qehaFJOh8q7FzOkKVKJ2BvVwafLwIFE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=UhO/oKP5iMw5fHjgaGRWOOpphrslB5BPutH1Bqw2Dkg=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:x-icloud-hme; b=HhStBCZN3rVcd9EC6oBRvG6abifGqlnPtcBVpdm6i/PmmBuQa0QJPHyLR1FLsYmXk MvvGwxnVyjgIAQUePoznfvb7VEqM2/2CzwoYBfpUQAlvZbnYih/hmf83Ex5BvNFrdQ PbfYoJ6GNXR9EuX2Q1IkypReed+wxDFG/c9O7uFQFsKRQdeX9qYk5H4Dvd9QURFidN MaOu/D4ITgbWB/BaBzseWqBas93vN7EeBu7C7tTfSVogYryn4akeV915HBecUZbsev T9vaSLH2CkX0yMcrX7poOXKdwAfoNE9h2RgWTSTlng3BI8SOCu2qBQQAo94LS+WVDT 77yqa5YwGC84Q== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021801.me.com (Postfix) with ESMTPSA id C1B66201011A; Sat, 22 Feb 2025 11:00:33 +0000 (UTC) Message-ID: <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> Date: Sat, 22 Feb 2025 19:00:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() To: Peter Zijlstra , Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> <20250221200137.GH7373@noisy.programming.kicks-ass.net> Content-Language: en-US From: Zijun Hu In-Reply-To: <20250221200137.GH7373@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xYMDZO87E-9u-9wzotp6QmCV6S-rGtqV X-Proofpoint-ORIG-GUID: xYMDZO87E-9u-9wzotp6QmCV6S-rGtqV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-22_04,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxlogscore=885 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2502220088 X-Rspam-User: X-Stat-Signature: hpcxrqzq93hfiieu6u9axjdn3e8h9d5a X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0BE7680012 X-HE-Tag: 1740222053-365720 X-HE-Meta: U2FsdGVkX1/1LzTk2DFO12a8sciQQ++dFjCKXGvPgehMxubaGrNFWJOxC9rK6WVHVAhEtN3DCMpRBk0p7Y26fDDjtWEKjOr7yqeLvCGzZDZszuRqNzUsNRh/v/gDWuhLNg+vPRzPpRtaxd4HinuPM3SzntCgvgJgkNd/2mXB4mSYv2gUflMIoCwm7qpZTY8Eb78vnviWnQWsLJ/1RxFN96aofFpYqOaX4YAoRhUkbbtmE58bevZgZSZE1sssPc8D8Nih2o7xas7E+ghGIiLdS5R2V/m+urAOJxPr919lPUnct7MlTzurtt+Wr/z+9beDwGKjkmrO4mqEFUEOfy/3tm5ErBRCUKzuxbr9evEW14+C4q9sQ7UpOI0ARYzMnNHgeKbv6FFM8OqgTIH28FB77H4IoCdxdf1qeJW43RniBKbgvEWXb/16gGuEtvEgcxNfuCP58VGywdeDXMFtzCMqbTMB5ljLbdJtEZmpX/uTvuFideLefEbyagpkHkUCd+WuJeo/oITlWkaQiXFJQ96ZZobgKtf48LNu6kVGrK3ri0vu/Hb0s8OEOTRyNVBdprOMgTWcGE07o1x3QK1ixDrI9pqwgZU6TpyEbbeKzNV+VuzED1crZbtCaihz61FdoWlfn+pKtwXdRTKA3S6WDHoa538EJg9BoGgex8qwmkqyvNLXb/Jrjk1Qd3qks0pzxReAJyQqeKworzDNZIxQb30tahQK8VQfVOGT3pS5/o+HGsAPetSKVSPPr91vd2HA8g9ONxC8VJMQBfqjc2YoMqH2nmq55oG1MAGTOyrbfxkDmTK3BzkGViHP6ZS3Dcx8lSTHfnWJLTwss0c5qkW1GmoVYMOVoGIZvsXkWYiaDMiPcxg/WhUGRYlB6wk4TcAZKRdmjclwYzeGoYaLY7nJoGWU8eILf1a6sreepsRUWateuDl/5+lrU7hx0Y8ZRmqNPWxCF7bk9YenzKSn8D2ZGIh VP8daNS5 jbLGNXq5XxQUJcTGF1MUnPT3kj3x5uHeGyY4I9EkLVcIsGLfZj5liE98hs6XH48twaOUzTtuCERfY93sBJ+i7I6cDYOweEYhgXCKdiZgU8u4r6lTbcfMYj/3UoExu5edhpLVTtHq12+hfGWqENFiD9A4I5uus1lVF/9OcCXTVBNyujeZPt0TT3CXfl39p3wyntaT02MY6wPHiBpWMuZDWMuzKPKTSV5ZPgrb493bwQ//sIpOu6ffYpHltyU1Ovl7HgJJl+CR8gvmBiBxXFgmp3NmcljrcyGhEhI+WxO8N8lKReKoxMv8iF0sat+PvuoY8gKIMWXK8vORbh/xrRHOK/hsjNxYtgBcoY1xyYe8L5ZEioyBbuYb/I2ofu9c3+9K6cwMngFsreJmDR+vjAervFQBz/Hpbkl3h3VR3WnIDNdE5Q7OJ2MEBw8Fx6uZmq5RuXRAAECmI37NMRkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/22 04:01, Peter Zijlstra wrote: >> */ >> static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) >> { >> - return tlb_remove_page_size(tlb, page, PAGE_SIZE); >> + tlb_remove_page_size(tlb, page, PAGE_SIZE); >> } > So I don't mind removing it, but note that that return enforces > tlb_remove_page_size() has void return type. > tlb_remove_page_size() is void function already. (^^) > It might not be your preferred coding style, but it is not completely > pointless. based on below C spec such as C17 description. i guess language C does not like this usage "return void function in void function"; C spec such as C17 have this description about return statement: 6.8.6.4: A return statement with an expression shall not appear in a function whose return type is void. A return statement without an expression shall only appear in a function whose return type is void.