From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F37EC433E2 for ; Thu, 3 Sep 2020 12:33:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3A29206EB for ; Thu, 3 Sep 2020 12:33:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="FJtYgXCV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A29206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28C466B0002; Thu, 3 Sep 2020 08:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2147A6B0003; Thu, 3 Sep 2020 08:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 103816B0037; Thu, 3 Sep 2020 08:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id E9F936B0002 for ; Thu, 3 Sep 2020 08:33:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A627F1E04 for ; Thu, 3 Sep 2020 12:33:52 +0000 (UTC) X-FDA: 77221691904.18.gun19_33009ee270a9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 0F66E103CBB22 for ; Thu, 3 Sep 2020 12:33:50 +0000 (UTC) X-HE-Tag: gun19_33009ee270a9 X-Filterd-Recvd-Size: 7066 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 12:33:49 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 083CUO3a052761; Thu, 3 Sep 2020 12:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=pnt6yrvPVsGGeisWZY0J+P6NELmvBBU3ffWJ5H3d+nA=; b=FJtYgXCVJfkeZ3Gc7BV543BzoGEPTY4tmiFpoODhVfIEsXhnemc+VtRcCh4tWn+e1ngm yrTS9a4CnJa8OUslxYvjC4fBly4wRRlpXGOONA9k4wwsWoCghy75bgwj3/SdlRki6+Vl A4d+YW0T8Rb8QptHFO8gHoFoZYbv5vRws9tlRyU/wmnsDI1I1FJTR4bOyDKjiP33Ks2V yKMpk7QI+UCAhNpbvMQct5zHfybmqjE9jcABAfR1ftEF4MZ0etpyckp6NpW5bUJ2JA9A jgocdBRbBjtnIApDYLm7CRhc9t+ZmyeVng8+UAerknndOTU+Ctt0VmJxXXgERJk+1NEA hA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 337eymgc3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 03 Sep 2020 12:33:47 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 083CUwiU163608; Thu, 3 Sep 2020 12:31:47 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 3380x9twa1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Sep 2020 12:31:47 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 083CVjwP029200; Thu, 3 Sep 2020 12:31:45 GMT Received: from [10.175.217.242] (/10.175.217.242) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Sep 2020 05:31:45 -0700 Subject: Re: [linux-next:master 3093/3958] drivers/acpi/numa/hmat.c:658: undefined reference to `hmem_register_device' From: Joao Martins To: Andrew Morton , Vishal Verma Cc: kernel test robot , Dan Williams , kbuild-all@lists.01.org, Linux Memory Management List References: <202008311538.99SbVGFx%lkp@intel.com> <20200831123802.e23a24b03ef54bfd5091ecff@linux-foundation.org> <2d7f64b4-b3f6-fb5e-4e44-2b9e987d74d3@oracle.com> Message-ID: <8f34727f-ec2d-9395-cb18-969ec8a5d0d4@oracle.com> Date: Thu, 3 Sep 2020 13:31:41 +0100 MIME-Version: 1.0 In-Reply-To: <2d7f64b4-b3f6-fb5e-4e44-2b9e987d74d3@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9732 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009030116 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9732 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009030116 X-Rspamd-Queue-Id: 0F66E103CBB22 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/1/20 1:57 PM, Joao Martins wrote: > On 8/31/20 8:38 PM, Andrew Morton wrote: >> (cc Vishal & Joao) >> >> On Mon, 31 Aug 2020 15:11:42 +0800 kernel test robot wrote: >> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: b36c969764ab12faebb74711c942fa3e6eaf1e96 >>> commit: f7782cc946fea99b8a4a0a83b6c3775a6beff8ce [3093/3958] ACPI: HMAT: refactor hmat_register_target_device to hmem_register_device >>> config: arm64-randconfig-r016-20200831 (attached as .config) >>> compiler: aarch64-linux-gcc (GCC) 9.3.0 >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> git checkout f7782cc946fea99b8a4a0a83b6c3775a6beff8ce >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All errors (new ones prefixed by >>): >>> >>> aarch64-linux-ld: drivers/acpi/numa/hmat.o: in function `hmat_register_target_devices': >>>>> drivers/acpi/numa/hmat.c:658: undefined reference to `hmem_register_device' >>> > > Here's a proposed fix (first patch) but I'm not sure if there's a better > one, though. Also, after fixing the one reported above, there's an additional flaw > with the reported kconfig. Specifically ARM64 with NUMA=y and MEMORY_HOTPLUG=n. > It wasn't reported above, but we would see it right after. See the second patch for that. > > The two patches could be just one patch as they are introduced by the refactor above > ("ACPI: HMAT: refactor hmat_register_target_device to hmem_register_device"), but thought > I would split them up per-issue while we discuss the fix. I can attach them merged if you > prefer. > lkp now reported the second bug, but the problem is introduced elsewhere when we start using phys_to_target_node() in hmem_register_device(), which is unrelated to this regression. I'll comment on today's failure with the adjusted fix. Meanwhile for this one, see below the scissors mark (re-sending it as I forgot the Reported-by). --------------------------->8---------------------------- >From a902a7304a5cdbd3484bdc4cdcd762520edbfd20 Mon Sep 17 00:00:00 2001 From: Joao Martins Date: Tue, 1 Sep 2020 07:29:44 -0400 Subject: [PATCH] device-dax: CONFIG_DEV_DAX_HMEM_DEVICES should depend on CONFIG_DAX=y HMAT requires hmem_register_device() which is now placed under drivers/dax. ACPI_HMAT is a bool and built-in, and to use hmem_register_device() CONFIG_DAX also needs to be builtin. Reported-by: kernel test robot Signed-off-by: Joao Martins --- drivers/dax/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index a229f45d34aa..a66dff78f298 100644 --- a/drivers/dax/Kconfig +++ b/drivers/dax/Kconfig @@ -49,7 +49,7 @@ config DEV_DAX_HMEM Say M if unsure. config DEV_DAX_HMEM_DEVICES - depends on DEV_DAX_HMEM + depends on DEV_DAX_HMEM && DAX=y def_bool y config DEV_DAX_KMEM -- 2.17.1