From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCA2EE4996 for ; Tue, 22 Aug 2023 15:21:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F602280042; Tue, 22 Aug 2023 11:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A63C94001B; Tue, 22 Aug 2023 11:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 546F2280042; Tue, 22 Aug 2023 11:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 43F2294001B for ; Tue, 22 Aug 2023 11:21:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 12D921A03DB for ; Tue, 22 Aug 2023 15:21:18 +0000 (UTC) X-FDA: 81152104236.13.9BC891B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id B461A80039 for ; Tue, 22 Aug 2023 15:21:15 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhksWGvO; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692717675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K+4dLM+qjKpedR3SxcMNZWwteZnGWMqZ2x4IrF9xwmE=; b=TNM2MUYiKe6BTnC+MgqvM4TzGEmflsZLru6H1SAC5d+yUmFJB9UDXG5Rr4JQnSfgS3f2Fn xILIw6+tQoZ7/q9OGdqz+m+JOPXCGwSfUtXGs4bTSqBl19YZ1zyndT2DiQe8RIcvrm8YOb 91Ygz7kYbyt/Ot1lk8CZoKm+6LFI1yw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692717675; a=rsa-sha256; cv=none; b=kFvH/gGXQbPCQPrax0ky7xIsrozqbFWW7KcK5Oxkw0oyRhNNzSeNbNaXnqpYQalS9COm/6 rUr9AcS2jUNpaFTSOxI+LpfFgrQK67H9gY0z6VoWQwkoMNZTNDQt1zPyLjU5NHdR4SRbuR JR1zq2CZ8+ERJd/G+Rz+tmWIPSCS2wQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhksWGvO; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692717675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K+4dLM+qjKpedR3SxcMNZWwteZnGWMqZ2x4IrF9xwmE=; b=XhksWGvOujynlzvS4ImTi8AXCHbF/+RC2HFdzjfdePZw4G+w5BHMtkFUwC2tLgFIqeYnT/ raiaJsyAhEk3yuzXHlvDIMAQM7rZLKhzvyK+VaQ7zym6ealaHlpmGSX0kxVrYW5tJp7w90 Gb8MlHHpW9UMP8VW5d2D/KVOBmvQmPM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-4k3lKUYRMK2gIdzy2ZJA7Q-1; Tue, 22 Aug 2023 11:21:13 -0400 X-MC-Unique: 4k3lKUYRMK2gIdzy2ZJA7Q-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31aca0c0d63so2748222f8f.0 for ; Tue, 22 Aug 2023 08:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692717672; x=1693322472; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K+4dLM+qjKpedR3SxcMNZWwteZnGWMqZ2x4IrF9xwmE=; b=HmInwwiGVG81m6vjPdo2zWqlScLIsCCziZCBYm28ROI5CJ1No/+8r3ayQmPSY0hfEr z40Hspe9uWH4VPEaHWLfN4qU33VqkKAtbPp19nIMZs1sW0S9bQ5tc75BRfdF2a3XvMAk Pu4XaQoS0myUkovvwp628i1t5Olc3Mlj7tQsdyroc+i4bFQcWoEYNRoY8KdGiN3844OO QjSCO3JKrp43rSoCgeaXfV7IfUaEGpnmjG/X9XTCEQxcIUkTmuX7t6Tg5/DZhsNoHEyd NpyJP4faWBHaMUMT/qdLz5pP4GAb/TsZNX2l0JzJnPljEfD0Z5Y+tlzMW91ICtjSKOCX 4icQ== X-Gm-Message-State: AOJu0YyPRLXyQj4Rg0q1qzlEnYYXDrVUD4rlZtrOlylkQJc1CIBAEcBz iGklOlt0nbZ/elsHGOsgiDLyyPO5IsRvks08qGaS2RFfn1kbldQJ4/h38gZyVTA0uVJ/JX2dfV2 ad1rHQiZnqoU= X-Received: by 2002:a5d:4ccc:0:b0:314:1230:29b0 with SMTP id c12-20020a5d4ccc000000b00314123029b0mr6891005wrt.52.1692717672411; Tue, 22 Aug 2023 08:21:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvvahb1vrGoYIb2vzRiaZnzgGGGa/+gqBYlj1b7B5EZtm9phlubqZT0TsAOsELNEsT5eF4fQ== X-Received: by 2002:a5d:4ccc:0:b0:314:1230:29b0 with SMTP id c12-20020a5d4ccc000000b00314123029b0mr6890972wrt.52.1692717671988; Tue, 22 Aug 2023 08:21:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:7400:83da:ebad:ba7f:c97c? (p200300cbc706740083daebadba7fc97c.dip0.t-ipconnect.de. [2003:cb:c706:7400:83da:ebad:ba7f:c97c]) by smtp.gmail.com with ESMTPSA id n4-20020a5d4204000000b0031c5dda3aedsm3811087wrq.95.2023.08.22.08.21.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 08:21:11 -0700 (PDT) Message-ID: <8f2cf5af-cad7-a69c-e8ec-39f48deae1cb@redhat.com> Date: Tue, 22 Aug 2023 17:21:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 11/37] mm: Define VM_SHADOW_STACK for arm64 when we support GCS To: Mark Brown , Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy Cc: "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20230822-arm64-gcs-v5-0-9ef181dd6324@kernel.org> <20230822-arm64-gcs-v5-11-9ef181dd6324@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230822-arm64-gcs-v5-11-9ef181dd6324@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B461A80039 X-Rspam-User: X-Stat-Signature: jd1nbk4e16rswnjdphg5tsfwnnhyuunz X-Rspamd-Server: rspam03 X-HE-Tag: 1692717675-620400 X-HE-Meta: U2FsdGVkX1+JyeLJFuh+K7OrxJuYbzsY9m3GOzNTiKU6Q3OEdxS35bP6fjO72V41dhLVKfZxFs3Qhyy0mPEKXBjbQcIX2JvxdA1TnujlKQgYAXR5LOynHlmr3KUF03Dmn/KJWu8axilojs7Jg2Pw1j57a8Lz2eYBS/E2YlkjHIBFZD5oHEKD7e2BdHIsXP6DBE0jBYgEmZOOaIPRrKSHnkMjP5ybp8aV5ULXxpGQnlcMt1ibGbR9yF7nqtoXTESHQfpzeWFqMaSEcaops+DZCf3ZOFkini4KrqBqJmxWLcpE6bbgdZuq7TUHYnX8z6YxV6TJYN3hky1k/t/4ARu1aciXo2W3AJGWmW+MmEWOxG6Ch8EX/ib1hchhzP78ReXYe0hzZ/NkmAa3LLAhuLL8fISZ2HZOq5FfJZ/IAfcWD8jEAQD6pkHCahuQJk1/jnNwFqneCtfHxYA2abkH7U9Sl8wYXTnstMb3ta3al+RNFGPFKSb+oxSN6eI6EFxeW+G2K0B5ED5qIeVxNckIJy5aBRmV8WcYBcGw3LHoia5Mx7YWp8bLil23JHaeasHVLffNsMGxfEPsXDPDfqY3Dnzzowpa7pYMmpfocYmcCcT+cZevD05VVoWDINrwORPCLDaZsnMZawbGVbRtJPKvGcFUJisAEk8Skhmvcx0oMPIGJgskymSsHECThghCCVNOdrHrRkcJmk72LLSH+unHQppBqomcIaGKYBO0a84SPPbuxS51idp65ZnEuXD6IpsF8a5QAzY+4sIomCrfPIu6fl4k5rfS4VXbaY1xXYsTXqy38UYKk1BP9ZSIuECvVHP1ar2eQCLf+oqE2hfM7YCOIYjek40ySBoi3t0UizFX7fS2DxoBjbL4tvQ+0yoTIlN7I+3ctFWniGjyKlUlx22m1UPR/2ltaPBjAGwHZOGxD322yockOQKgHPgKoHZcn0+H7gvCkcx2Pk7yF6MT3TdMraf cmYVeGpW oYCQbMYJjbcvHyvl+a7qdHqBoXUZDpugZhtub5cw8aG0EDHKF3+ENWtx+I6Yhnl1qQQoqV1I25GJiQATt80oASFBBiHyeDZwVl0zUzod5FYCZdmSvlB8ZEqo0K+hvcj+TccSzJRPkZNpHyHPhiSBm8nK3nzzC1wQczA2LnDPHpIPHEUq4K05fuZ7HiPs0lo0OziytZiXn5UGz6KYSzVr68NeV7QKj7+qz6Ac12bpMzzvFulHYVAx5PyxCw+bvl0M1bIOpZdLgNyuTL8bvIovnGMrAdKywcqMXgpTXSTt0WiVVr1SjmSzVbRe34r53DeXttp+GgrtUc2wa4YS+uarfRVvj8QShn6Caicn2NlVvTe3yiv7YUf9Dz52yXzsyRLQS5YczwTwrgw1seFkqfukJQw6LzOzbQ8kB/8H63Db4tvTTZaeyJ1ZSbscHbzZkcsbeEuLymBfFkHmMQJmNr1yEBhZNCE33iTSdJqhYTz1v8vGPA9PqgJ6B8bFUUo9Ucksp0XDZ6hSVTGBdFd78o6LbbOr2PlPlBd3pw6mpsnRSxA9DnxIYOc5I91nN1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.08.23 15:56, Mark Brown wrote: > Use VM_HIGH_ARCH_5 for guarded control stack pages. > > Signed-off-by: Mark Brown > --- > Documentation/filesystems/proc.rst | 2 +- > fs/proc/task_mmu.c | 3 +++ > include/linux/mm.h | 12 +++++++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 6ccb57089a06..086a0408a4d7 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -566,7 +566,7 @@ encoded manner. The codes are the following: > mt arm64 MTE allocation tags are enabled > um userfaultfd missing tracking > uw userfaultfd wr-protect tracking > - ss shadow stack page > + ss shadow/guarded control stack page > == ======================================= > > Note that there is no guarantee that every flag and associated mnemonic will > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index cfab855fe7e9..e8c50848bb16 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -711,6 +711,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > #ifdef CONFIG_X86_USER_SHADOW_STACK > [ilog2(VM_SHADOW_STACK)] = "ss", > +#endif > +#ifdef CONFIG_ARM64_GCS > + [ilog2(VM_SHADOW_STACK)] = "ss", > #endif See my comment below. > }; > size_t i; > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 43fe625b85aa..3f939ae212e5 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -372,7 +372,17 @@ extern unsigned int kobjsize(const void *objp); > * having a PAGE_SIZE guard gap. > */ > # define VM_SHADOW_STACK VM_HIGH_ARCH_5 > -#else > +#endif > + > +#if defined(CONFIG_ARM64_GCS) > +/* > + * arm64's Guarded Control Stack implements similar functionality and > + * has similar constraints to shadow stacks. > + */ > +# define VM_SHADOW_STACK VM_HIGH_ARCH_5 > +#endif Shouldn't that all just merged with the previous define(s)? Also, I wonder if we now want to have CONFIG_HAVE_ARCH_SHADOW_STACK or similar. -- Cheers, David / dhildenb