linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>,
	Shakeel Butt <shakeelb@google.com>,
	Seth Jennings <sjenning@redhat.com>,
	Dan Streetman <ddstreet@ieee.org>, Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/zswap: fix potential deadlock in zswap_frontswap_store()
Date: Mon, 3 Apr 2017 16:46:52 +0300	[thread overview]
Message-ID: <8f29ec95-50a8-c776-30dc-e79e6b0d7349@virtuozzo.com> (raw)
In-Reply-To: <28e47653-96d7-288a-0c9b-e065b29d7c45@suse.cz>

On 04/03/2017 04:28 PM, Vlastimil Babka wrote:

>>
>>
>> Seems it was broken by
>>
>> a8161d1ed6098506303c65b3701dedba876df42a
>> Author: Vlastimil Babka <vbabka@suse.cz>
>> Date:   Thu Jul 28 15:49:19 2016 -0700
>>
>>     mm, page_alloc: restructure direct compaction handling in slowpath
> 
> Yeah, looks like previously the code subtly relied on compaction being
> called only after the PF_MEMALLOC -> goto nopage check and I didn't
> notice it. Tell me if I should add a check or you plan to send a patch.
> Thanks!

I would be glad if you could take care of this.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-04-03 13:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 15:30 Andrey Ryabinin
2017-03-31 17:00 ` Shakeel Butt
2017-04-03  8:47   ` Michal Hocko
2017-04-03 11:57     ` Andrey Ryabinin
2017-04-03 12:29       ` Michal Hocko
2017-04-03 12:37     ` Andrey Ryabinin
2017-04-03 12:38       ` Andrey Ryabinin
2017-04-03 13:28         ` Vlastimil Babka
2017-04-03 13:46           ` Andrey Ryabinin [this message]
2017-04-03 12:45       ` Michal Hocko
2017-04-03 13:14         ` Andrey Ryabinin
2017-04-03 13:23           ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f29ec95-50a8-c776-30dc-e79e6b0d7349@virtuozzo.com \
    --to=aryabinin@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=sjenning@redhat.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox