From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BBAC00A89 for ; Sat, 31 Oct 2020 01:15:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51869207DE for ; Sat, 31 Oct 2020 01:15:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51869207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C3FB6B0036; Fri, 30 Oct 2020 21:15:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54EAD6B005C; Fri, 30 Oct 2020 21:15:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 415166B005D; Fri, 30 Oct 2020 21:15:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 10AC56B0036 for ; Fri, 30 Oct 2020 21:15:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B04783624 for ; Sat, 31 Oct 2020 01:15:49 +0000 (UTC) X-FDA: 77430453618.12.lace04_430a7a52729a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 8E2A618002A58 for ; Sat, 31 Oct 2020 01:15:49 +0000 (UTC) X-HE-Tag: lace04_430a7a52729a X-Filterd-Recvd-Size: 3047 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 01:15:47 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0UDgCrVb_1604106938; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UDgCrVb_1604106938) by smtp.aliyun-inc.com(127.0.0.1); Sat, 31 Oct 2020 09:15:39 +0800 Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled To: Johannes Weiner Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-3-git-send-email-alex.shi@linux.alibaba.com> <20201029134648.GC599825@cmpxchg.org> <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> <20201030140420.GB666074@cmpxchg.org> From: Alex Shi Message-ID: <8f288275-da78-335d-e83d-7e073fcd3b88@linux.alibaba.com> Date: Sat, 31 Oct 2020 09:13:26 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201030140420.GB666074@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/10/30 =E4=B8=8B=E5=8D=8810:04, Johannes Weiner =E5=86=99=E9= =81=93: >>> Acked-by: Johannes Weiner >>> >>> This should go in before the previous patch that adds the WARN for it= . >> Right, but than the long ops may not weird. Should I remove the ops an= d resend the whole patchset? > You mean the warning in the changelog? I think that's alright. You can > just say that you're about to remove the !page->memcg check in the > next patch because the original reasons for having it are gone, and > memcg being disabled is the only remaining exception, so this patch > makes that check explicit in preparation for the next. >=20 > Sorry, it's all a bit of a hassle, I just wouldn't want to introduce a > known warning into the kernel between those two patches (could confuse > bisection runs, complicates partial reverts etc.) H Johannes, I see, I will exchange the 1st and 2nd patch place with above comments in= commit log. I guess you could give more comments on other patches, so I am going to w= ait you for more comments and send v21 as a whole. :) Many thanks! Alex=20