Re: [PATCH v3 0/3] tmpfs: zero post-eof ranges on file extension

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2025/11/21 23:22, Brian Foster wrote:
> Hi all,
> 
> Apologies for the quicker than expected respin here, but during
> discussion with Baolin on v2 it became apparent that I factored the
> first two patches in an unnecessarily confusing way, and I wanted to get
> that resolved more quickly. Otherwise there are a few smaller changes
> here that I think are incremental improvements.
> 
> Baolin, I left off the R-b tag from v2 just out of caution and how I
> reworked the first two patches. The end result is mostly similar, but
> I'd appreciate a quick look before adding that back. Otherwise most of
> the functionality here should be the same as v2.
> 
> Thoughts, reviews, flames appreciated.

Overall LGTM. And I tried to do some tmpfs read/write tests, and I 
didn't notice any obvious regressions. Anyway, let's wait and see if 
Hugh has any input. Thanks for your work.

> v3:
> - Reorder changes in patches 1-2 to factor out existing logic first.
> - Use local scope variable in shmem_writeout() fallocend block.
> - Tweak combined zeroing logic in shmem_writeout().
> - Clean up commit logs.
> v2: https://lore.kernel.org/linux-mm/20251112162522.412295-1-bfoster@redhat.com/
> - Rework to zero uptodate post-eof folios on writeout and full range
>    from EOF on size extension.
> - Misc. cleanups: variable renames (pos -> end), code relocation,
>    comment cleanups/removal.
> - Update commit log to call out POSIX requirement.
> v1: https://lore.kernel.org/linux-mm/20250625184930.269727-1-bfoster@redhat.com/
> 
> Brian Foster (3):
>    tmpfs: factor out folio zeroing logic at writeout time
>    tmpfs: zero post-eof folio ranges on swapout
>    tmpfs: zero post-eof ranges on file extension
> 
>   mm/shmem.c | 135 ++++++++++++++++++++++++++++++++++++++++++++---------
>   1 file changed, 114 insertions(+), 21 deletions(-)
>