From: Markus Elfring <Markus.Elfring@web.de>
To: Alexander Potapenko <glider@google.com>,
linux-mm@kvack.org, kasan-dev@googlegroups.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Aleksandr Nogikh <nogikh@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>, Mike Rapoport <rppt@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v2] mm/memblock: Correct totalram_pages accounting with KMSAN
Date: Wed, 24 Sep 2025 15:23:26 +0200 [thread overview]
Message-ID: <8f0366c8-f05e-4687-817f-90a5b47922c9@web.de> (raw)
In-Reply-To: <20250924100301.1558645-1-glider@google.com>
…
> +++ b/mm/mm_init.c
> @@ -2548,24 +2548,25 @@ void *__init alloc_large_system_hash(const char *tablename,
…
> +unsigned long __init memblock_free_pages(struct page *page, unsigned long pfn,
> + unsigned int order)
> {
…
> if (!kmsan_memblock_free_pages(page, order)) {
> /* KMSAN will take care of these pages. */
> - return;
> + return 0;
> }
…
How do you think about to omit curly brackets for this if statement?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc7#n197
Regards,
Markus
next prev parent reply other threads:[~2025-09-24 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 10:03 Alexander Potapenko
2025-09-24 13:07 ` Markus Elfring
2025-09-24 13:23 ` Markus Elfring [this message]
2025-09-24 13:34 ` Marco Elver
2025-09-25 5:25 ` Mike Rapoport
2025-09-25 12:37 ` SeongJae Park
2025-09-25 12:45 ` David Hildenbrand
2025-09-25 14:50 ` Mike Rapoport
2025-09-26 0:25 ` Wei Yang
-- strict thread matches above, loose matches on Subject: below --
2025-09-24 9:56 Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f0366c8-f05e-4687-817f-90a5b47922c9@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nogikh@google.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox