From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Yin Tirui <yintirui@huawei.com>, <robh@kernel.org>,
<saravanak@google.com>, <dan.j.williams@intel.com>,
<akpm@linux-foundation.org>, <david@redhat.com>,
<rppt@kernel.org>, <Jonathan.Cameron@huawei.com>,
<devicetree@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: <chenjun102@huawei.com>
Subject: Re: [PATCH v3] of_numa: fix uninitialized memory nodes causing kernel panic
Date: Tue, 19 Aug 2025 20:03:53 +0800 [thread overview]
Message-ID: <8ee28bfb-9434-4c3e-b039-6c80c00af1cd@huawei.com> (raw)
In-Reply-To: <20250819075510.2079961-1-yintirui@huawei.com>
On 2025/8/19 15:55, Yin Tirui wrote:
> When there are memory-only nodes (nodes without CPUs), these nodes
> are not properly initialized, causing kernel panic during boot.
>
...
>
> v2: Move the changes to the of_numa related. Correct the fixes tag.
> v3: Only amend commit message with no code changes.
>
This part should be moved under "---",
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: stable@vger.kernel.org
> Fixes: 767507654c22 ("arch_numa: switch over to numa_memblks")
> Signed-off-by: Yin Tirui <yintirui@huawei.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> ---
> drivers/of/of_numa.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
> index 230d5f628c1b..cd2dc8e825c9 100644
> --- a/drivers/of/of_numa.c
> +++ b/drivers/of/of_numa.c
> @@ -59,8 +59,11 @@ static int __init of_numa_parse_memory_nodes(void)
> r = -EINVAL;
> }
>
> - for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
> + for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++) {
> r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);
> + if (!r)
> + node_set(nid, numa_nodes_parsed);
> + }
>
> if (!i || r) {
> of_node_put(np);
prev parent reply other threads:[~2025-08-19 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 7:55 Yin Tirui
2025-08-19 11:03 ` Mike Rapoport
2025-08-19 12:03 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee28bfb-9434-4c3e-b039-6c80c00af1cd@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chenjun102@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=saravanak@google.com \
--cc=yintirui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox