From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431FEC25B48 for ; Thu, 26 Oct 2023 05:25:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6F606B0356; Thu, 26 Oct 2023 01:25:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1FAA6B0357; Thu, 26 Oct 2023 01:25:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7156B0358; Thu, 26 Oct 2023 01:25:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9C2976B0356 for ; Thu, 26 Oct 2023 01:25:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 697341404EE for ; Thu, 26 Oct 2023 05:25:37 +0000 (UTC) X-FDA: 81386475114.23.F2ECAE8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 4C4ADC0009 for ; Thu, 26 Oct 2023 05:25:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPcJdpII; spf=none (imf28.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698297935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=264fWZxxGW0DECTaVAjBqKdK5xaDEeBQUM+BQhVJXr8=; b=dXCH+8YGe7qKgEeL8yuTmuZDC15m51uFqDPy2WwkgyTZJfOtY+srX6VHe9CclChsTiHoJb 3B1iWPia9jbhhO3fvMkI6YqSlHnf3itOxDOnDvY0Ir95jX4j/01feWO+nIH0qCoEUmfZZ4 VlAqH4f1a3096f6zbwhw7bUmjql1qaQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698297935; a=rsa-sha256; cv=none; b=8YK1AJhmrn0H4MAyTei6MrT5rIbbfm1mUUC/g44iS1SjmN9OpfKDPa7tHBHzvbm26uSvPB Ic0kYE9/CyBVFC8wHVD5C3O85wSMyP7Ci2vDdiiG1Ox+9ut6YaEQVzPW1BwXHHhFaRigBW hLmi/0fbVumVgyOkNfNgYajMMQcNvxA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bPcJdpII; spf=none (imf28.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=264fWZxxGW0DECTaVAjBqKdK5xaDEeBQUM+BQhVJXr8=; b=bPcJdpIIRjy9nbG0xYgLhFYaKc E7Kwik4J0iRTYo2zaHoFt+mjojzBkRX3xn9HWrtIkGlgX7F8jQbP+rXdbERNhPUZtDvVgzXfa9j4t XjSTYZpMP5XghxXMxgpG2gP4nuDGos5rL94dWtTqMlrrcRLaJCmcYlh57HE4JoN1i1vOZ9S2XZqd+ PEEe7lf7gZFXvep0xNdNOF3v8fKi3UWWSB31Txls96MS//ZegmOE5RIxnCEWUVv2TLYp/Gjbkwu65 goOzl2KYpQIhpg4cZL3FUNH/CpNCoJQX9oAOedPsjaxzHgZ6rMrJzlpYYWTp37+vYcHNHTH/ngjFR GQAAOAvg==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qvss3-00Dh6y-0m; Thu, 26 Oct 2023 05:25:27 +0000 Message-ID: <8ed89012-9018-473c-9007-8c34bbb57bcf@infradead.org> Date: Wed, 25 Oct 2023 22:25:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' Content-Language: en-US To: Christian Brauner Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List References: <202308172003.O1QB7TgB-lkp@intel.com> <9a05d92f-60c5-6ede-2105-829f09c737b7@infradead.org> <20230830-koiteich-ehrerbietung-8191852e752b@brauner> From: Randy Dunlap In-Reply-To: <20230830-koiteich-ehrerbietung-8191852e752b@brauner> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4C4ADC0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8nxyedkfxm77i6herty93zaqqqf3uoir X-HE-Tag: 1698297935-945481 X-HE-Meta: U2FsdGVkX19nLJul33K3fFgBJjJdqHvqP5Yy7NGlH48ynETAWsXtS2Qt7fuxMKOU3OodvbV0hHZcgsv1nVJmK1EPF6o827j5tnvy4D9UToBBTaLUcTYt/SZQ+bPs7RSqptZI/4dmviyYhJVHQUKSBWYcg0d0UHWWY6ZoRkVzApXBWJbfGGxrvC0AT/8xKodZSTzntmGrMCdT/WNj9h59FFFEI1+ICOu4SBrhzyjD6D4CuJikgFFH08bM/M3CunqUkrmz6ZSR9aevFf2MSp1L3z0Azc17nq2iikdWMIHggbRIzRzFmHKYhhh9Cd3HBR44uPt0maBYsHjMayPKZX+lmxbXt7httsJz15gcAZtWExNfLU3pIdftnL+ko4sEQCRpHYIu+qHGkBq91scYTQ2vVyIruszBSjNR96QH/PiaNpTNF7Z1HMVS2IGRe8wNQAP8f+rT05qHg/boxdms04Y9+4Lei7Z3IgliREhiNmZNiF+L26Is91xPqN6zmYXGWPSyHjnrGeGU9dnOz0UAfj8Qv7h/mlDKj4vjr5C2/ecjLLqvkiuNPZPsmTfi6yxVhnj1JQNN3QisCAJyoYXQq+JtyH0XOwarPaGphQPlKKfJS5TeG5kfpOf/gdlx1G7n4/kqh+/UgjKqi+GDnHAo4LaWmhqIf2a5T6FkAi7COb7pAJzhia2eOJVB9yIIE9HUcsrfZ2eEPhseNVPRCFuDxlSsm7h/DoCbpgZ1O/pdVVTtlRO+qSwIM+OiqrWVpDVoyBiPyrs2+DYbMVRuvy2D3I3Djsv0JPj/8CW+UEAMaOzm/kBJdh0QSaOgL8ickuGnP/oBeZl5rEs8o+7y+R5bWcivfivxtjxlYMlPPrZC5ulCzm63836IRXuHDU8GMCvrfT5FdEeg8jFQQ2GL1IvrmcfQrr+awp8R4HIo5fCP+Tqx0KcPRTYnuFIHmqS/GChEmYobvFK6338eexnwzQH2qvj iK2L4X+L 2J0y1MKuIpPk1ZNcrhkA6NplFxV1UtiBww+0hoUdXMQTWed/vvurjNAX2mVXYpzvkEpZynBU0SdcC8lD3NK9QeOP/SnFzNOiPCdXhRhMN8A8lSHXFSgYoPAbb7jyR/fEJirwKHV3TbiH0mxK7vAj4NyGfFOKeHQgYbg/wE00iHqhBWycrt5L9zk2OqPGj+tEoJmvUScG0/IZwSoyzv3zJw5+A6P5TT2BRw5gbr148pk0L07icRkYq8jlah506um9LPGPPUqObcX24MpDPneb+75bV3ag3/qK5uhCXEbbMwnEZRx3bzBwQPKTb+vnOKHAvYrjylLE81rvW1mDoZwDmtjoLEioW9RmiJnzboBv0Km3EcNI6HI4CuhWN4HWC59vc30EPFxPgSdvKbItknXgZJ7KIY5cj7bB4Wp/fhJZ75O4IkQFymXof8jeYK0CSvD4GCuCTBRIUZZthqztBn3ZgHxR1CQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/30/23 01:24, Christian Brauner wrote: > On Mon, Aug 28, 2023 at 10:13:06PM -0700, Randy Dunlap wrote: >> Hi Christian, >> >> On 8/17/23 05:56, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>> head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6 >>> commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation >>> date: 7 months ago >>> config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config) >>> compiler: hppa64-linux-gcc (GCC) 12.3.0 >>> reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/ >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' >>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key' >>>>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key' >>> kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id' >>> kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id' >>> kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max' >>> kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max' >>> kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max' >>> kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max' >>> kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base' >>> kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base' >>> kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base' >>> kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base' >>> kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base' >>> kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base' >>> kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base' >>> kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max' >>> kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max' >>> kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max' >>> kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent' >>> kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent' >>> kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps' >>> >> >> According to 'git blame', all of these come from additions that you made. >> >> What do you think about a patch that converts all of these into non-kernel-doc comments? >> I.e., change "/**" to "/*" for the functions and struct? > > Yeah, sure. Hi Christian, I sent a patch for this on 2023-AUG-30: https://lore.kernel.org/all/20230830163215.13193-1-rdunlap@infradead.org/ -- ~Randy