From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A384C021A7 for ; Fri, 14 Feb 2025 18:07:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5DDD28000E; Fri, 14 Feb 2025 13:07:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0D20280002; Fri, 14 Feb 2025 13:07:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BADA928000E; Fri, 14 Feb 2025 13:07:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E56E280002 for ; Fri, 14 Feb 2025 13:07:32 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E9CBB0E3A for ; Fri, 14 Feb 2025 18:07:32 +0000 (UTC) X-FDA: 83119332744.12.14C2204 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf01.hostedemail.com (Postfix) with ESMTP id 65A7440011 for ; Fri, 14 Feb 2025 18:07:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QlPgqy5t; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739556450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+U9qgBEdUJx2kwrhcUibZnTZZyZAmW3jD1b7GebZpfg=; b=8Su9RMPl/dqVSqCMl6JYy73HZE3uJtDtmnnWEHi9n2ZU3eEFHZ/Yt01veSWWW9bDlvaVTe p1VLxbbasnkjy/G3HYtlGPnM+IKPxwaNYYyuZe3bBt7WOnYFyFmcGaP/Xktc2XmQX1ZMXT huLEdj3cGOXtKzy7vL3e3u1hu/P0dGQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QlPgqy5t; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739556450; a=rsa-sha256; cv=none; b=jbau6nw+EwQC00wYqa9WeAH9xOK4lJtdT0hz3b3oLq8Zrq2rJneEdZYYpOIEUDsAd32mLY nGOc2zO5edG1Qk4gTTuzj1io07t37ZXpJfPMVIhP5sK2IjUmeVYDqbNeLywzAkQ9x+0mmh qxD2iAFek+M0Q4YcF1gqOODVaU0xfr8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739556449; x=1771092449; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=h6OUqOhwd9RZ6Pz/Vm7CxoSwl5EfLkLrNYFaXI0zqVY=; b=QlPgqy5t7AtboS/LmJSS8+av7N5S9RU6IGzutpczKkVIoKlfQPnp5pWe 9AHKaE10L17hYstMc1OBzw1UQb6zk5zBTESCQ+phCt7G7bnwkvnNw2tGp mmTE+rdtIKvqT1Yo/5fmkfePiXp3Qb5QQEyNur5z9TjtAv3I2vbyP7DKw qDgMg5OeheBcohG0Z9ZYLmLZy/0aJeqbWcbVT+UNlJ95t8AsPD37+cxJB inn+UefvQ35YQCVHWUZTYKQq1YBhkplTFQgmfGdmVWtdfrQayngwsjhV9 RUsSsbEeKSxwFyUk6Hni1ImikaNpXpiZJxxpU1RdLU1Jjd97WCxIEkbiN g==; X-CSE-ConnectionGUID: L1ucL5bTQ1Gk5L1jd+ckLw== X-CSE-MsgGUID: RIBFMT7iSKqqc3eeewyM8A== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="65668522" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="65668522" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:07:28 -0800 X-CSE-ConnectionGUID: S0KmD6zTSqeR4/7Gn7+rKA== X-CSE-MsgGUID: 9YMIBWkaQzGn7674Nn8G7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="117649868" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:07:27 -0800 Message-ID: <8ed78428-7f3d-4fd2-a690-456da62ff7c3@intel.com> Date: Fri, 14 Feb 2025 10:07:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 03/12] x86/mm: consolidate full flush threshold decision To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-4-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213161423.449435-4-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 65A7440011 X-Stat-Signature: apsxw3mdzjortq4mpw4geeuf7bqmypui X-HE-Tag: 1739556449-275339 X-HE-Meta: U2FsdGVkX1/Sm0vqqlEI0s7pFuOwUODubvcCucgSUXyKwq7Yry0dK9W1WbhtbZC1oQwRktO9pHKb4u6istmpah0EK564s+urv6r+vVeS7xBr7AejGgeBHQx+kfeSwZz8YfLYlzxIJgR18/eogxWJ3VMn8daU/BH/Y+VJFVkGM6ud7rUXWmWdm1tQ08cpA1+wIFoYBZUq9daAz582/b3yXVtauAlUchdqMfVveSIlSld6TNUdF9B9CqMW1HgZoYPq9nbGYEQlXsFmO+tYLXWIzqGCdbXS+/sHCDSdd+att4QxHbpTthegjGTZJgTdOkSruWj7SVK3qdzaiQbB1fJztqBnM59GeLbYwiSSwvmAXtuYeW+Dd350zBPcoxlUf6JiCvNr56Br4I+PgUgx0QxMu8OFlT8h/C9KXjrc6pm/yIsLjPqKinv3CH5w9Y1XJmw2xTzYihgWQQGccwNGHS6eWROMiejV7rSgiCYiUoGvU4v8UukZgylwuTvhikFCkOHOuyVK8tL6JsKl8zyjN/qyg3Vack+JYqiptOOg6J430tpstrPlnqRrOZ2Bpq7B3T0k+ZZBGbIt+0e7eyjf7xvl79wbPAo49Uas+PbHtyqh+6R0TlxMVO7iaatjCfK/PvMdFPNDw0iuzEDRJiyV+9lHps/OdUF9i6Ch2PBUp0l0JgLvEDq+mImMj6KRzKMSestulmFtHvLKEdXMHE//4IbvFHnZbz36VWiyAMSCrGVLHqwmOzXOTnW1GGmrr0hAKRc2KTsCpwlmA8sjtuRIdkLQrUM1oZwlkc/RL9et4dHWnS+ys/pvF+wvUOkOaUIaoQBEIQ/ee4S/+WyUuBQ6PaVjZPofvj2bGyIci9Tc0kCAGHNbcj/rgwQBFPl3hSrCkfAfnUXWvmLH1k4OYqo148FEJT/uLNHg3ovi+sYD12HaN6IS8RJXpPvA7vAaKhO6UcgEeiC+NGinWIxNK8kPyJG J8IVGc4s eTBj50nof2VR6b1ScgQzZ8SEp1JPb5IACdvK2uW/tXufUitCfEpp8DtbjbYpus/LcHfyiLVTVRFhDn64NJwupXpINqxb60g2Fza0TtbmdwEtrDnFwquqivcRAVyohJ5wZgeaxDqSU0hvdhDIpG1ckXqFceDUZvdBBQ9825ilrAlTtqv+pjc1DPzZMLSqqSyEPeC9mBRWYe3QgbE7iSwXMe3qyfv+mmzs9t6OXGRPesZO4WOmuXB5o+VedTJ71dGocQOC8u/Yl3wjEJgGsIc8+k5ivIb+XbZYKVMLPIi3eNhPopOppGHaTzkz2bJlZAWPDQX+5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 08:13, Rik van Riel wrote: > Reduce code duplication by consolidating the decision point > for whether to do individual invalidations or a full flush > inside get_flush_tlb_info. Looks sane. Not a ton of code savings, but it does look a lot nicer: Acked-by: Dave Hansen