From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C41CC4167B for ; Tue, 5 Dec 2023 14:34:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0CCB6B0095; Tue, 5 Dec 2023 09:34:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B968E6B0098; Tue, 5 Dec 2023 09:34:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10906B0099; Tue, 5 Dec 2023 09:34:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8EA786B0095 for ; Tue, 5 Dec 2023 09:34:21 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5E00BC0113 for ; Tue, 5 Dec 2023 14:34:21 +0000 (UTC) X-FDA: 81533009922.16.73A7DBA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 1743140017 for ; Tue, 5 Dec 2023 14:34:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GVQWobUn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of pstanner@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pstanner@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701786858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1oo9wYlZR3izMsicqmb+vabDeYW3Sk3a+FflIBcT0I=; b=UXR0fy5l/zJTdCEmDC29fvTC3DPQENR72Ecx7NLr8awzMrq0TXnboj9HrbH3IRmHWsHVAK t/r02vJ6u/6nIgK3jN6ynU/+FXvzxMiDgOLFKExC5gpUPZDG1mhGMgLAdhgLQcG0YXmy0J Jnw9puiAQh2Av3oq8h29fm9vQwhEOQU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GVQWobUn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of pstanner@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pstanner@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701786858; a=rsa-sha256; cv=none; b=Qu0JmMVbn5p5/afYXz4m85FRTYa8VtyzP7Cr7dztp4WalEcE5bS1qNpcMUYrZPbWhLA62P dRUR3DGoXZmOyOyInypcG1/acU1a8O08ENBI3BgwgCEgygzCIxxI4ZO6k/RDj939EZ7Sah IraMHxhsDNit9dv9+7m0w15OxUp+tYg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701786857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t1oo9wYlZR3izMsicqmb+vabDeYW3Sk3a+FflIBcT0I=; b=GVQWobUnwaS7ZwD/3+ejPfo79fa5G/kMUVLcvAjt/G7Hk44ZwzYUAeYOpiuaM+lB6PA1KX WQJFPzj8MhJCOX77Tqw6IofFUYzwa66Koo5yxgivl9+2Cm0HnU0NMFo+e7xyIRMRImQBUB hgwaFprS0VLDTP5YX1YT/QUPtzuyPE8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-UjCfyH0sMBicOpfD4el_rw-1; Tue, 05 Dec 2023 09:34:15 -0500 X-MC-Unique: UjCfyH0sMBicOpfD4el_rw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40a3d918dc1so11654355e9.0 for ; Tue, 05 Dec 2023 06:34:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701786854; x=1702391654; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t1oo9wYlZR3izMsicqmb+vabDeYW3Sk3a+FflIBcT0I=; b=Vf8sE0R3JnyZWzqJTlckGkqcPQZCWxNFtn/tE9cEaBDjTKZKbUy/Q2CqZ/eqhaWExk 41N+HUA4E3ozpVmQHkZz2HTXuu++4v2KzVg+v8hk+BPfd6Eh9ctLlaxzotegj15Z1JfU JCHUaTl+G4ohJa2jfHiMqUV263grU3mj9APUB+0ySRLzWPVEBy2qvnw5aNGaHS9CSbqc uLCHwi1dJq3e42kPs8uKYwIbymR3KJoS2Mi4K0IC9Xl/0o0YbdF4hmcJu8OCnmghjuSA XuAcOjT4tJU9FPhVBBdVh8NI+HVhVrA6fmgwYEbYk7WuOS7H9B6sRsrQTu/1kk7OhfmZ XKZA== X-Gm-Message-State: AOJu0Yz29O+IuwBiLeD6wwSCti03f1AJUIvL4TNLMmWBDXooxXXSuP1G 0UApy4pi3vYV1HnFdBtq0/4IB/kudZfrzVetMxPSO4+mziHXl+1gr7NJ0g7uigk7n/lpPb8BHSn PLtdC3kncfzk= X-Received: by 2002:a05:600c:5024:b0:40a:771f:6a56 with SMTP id n36-20020a05600c502400b0040a771f6a56mr24476164wmr.4.1701786854237; Tue, 05 Dec 2023 06:34:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGPNdBwDu9dr6enHkkgXCOXz022qJVffHzVjL5DyqXAOhz0Bn+IqdhhmLHKvXQvWYQm8QVxw== X-Received: by 2002:a05:600c:5024:b0:40a:771f:6a56 with SMTP id n36-20020a05600c502400b0040a771f6a56mr24476128wmr.4.1701786853892; Tue, 05 Dec 2023 06:34:13 -0800 (PST) Received: from pstanner-thinkpadt14sgen1.remote.csb (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id t17-20020a05600c451100b0040b379e8526sm22411354wmo.25.2023.12.05.06.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 06:34:13 -0800 (PST) Message-ID: <8ec1ae92206c090c79a9ab9586bd17349798b08f.camel@redhat.com> Subject: Re: [PATCH v3 5/5] lib, pci: unify generic pci_iounmap() From: Philipp Stanner To: kernel test robot , Bjorn Helgaas , Arnd Bergmann , Hanjun Guo , NeilBrown , Kent Overstreet , Jakub Kicinski , Niklas Schnelle , Uladzislau Koshchanka , John Sanpe , Dave Jiang , "Masami Hiramatsu (Google)" , Kees Cook , David Gow , Herbert Xu , Shuah Khan , "wuqiang.matt" , Yury Norov , Jason Baron , Andrew Morton , Ben Dooks , dakr@redhat.com Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, stable@vger.kernel.org Date: Tue, 05 Dec 2023 15:34:12 +0100 In-Reply-To: <202312051813.09WbvusW-lkp@intel.com> References: <20231204123834.29247-6-pstanner@redhat.com> <202312051813.09WbvusW-lkp@intel.com> User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1743140017 X-Stat-Signature: t5acg1jsf1pu9ztr96f1onx5tp3petqt X-Rspam-User: X-HE-Tag: 1701786857-285809 X-HE-Meta: U2FsdGVkX1+s/qsw01hI9/rkr4WZ7M77JyDxfyhinI0GzxuTw1bP8n88gp8tqtoTLkDP+P7YN1EYLzmKlT5oC9C5G/9PkS+EWeOdc/U+YIvZRL4LGq4LOyf8uMl7pQ0UjTppq12jWp/WX9XNYRxni79A4z381lN6YrE68vigVzX8CX/LRCRG9yeglI1gS/bv/jarGSYu+LMumGnFCzKd9j05lpKeeBHQgJgSrAXKZdEUAl2mPXNNIWnWzK4SxUDxhvfrTc4MzRhUniHsQ+VN1qzjrjDxP3mpX7WK2YypOb1/P9inYID/P2f9C5aOZeSqTxVrKDFFVmLPhIm80iqadkupw2CcMnA6gUNKPb0xR4kHhE910t9pjbc/Q2kRNRbLJcNY4QecG1Gtf3tJhZbevFYbY0YNp4887QgIRXKNKwp8CthDv6pdVmk1iukRa3FPY42/gisX8KQ0Eonj0fupiJxLu1OMH3ve/0GYjDEm7M0oHuiufFwSyUYqjUR8jYW8Y1KWd/DcE73Fa6Kkw/2s/s25lpK++FjYtwuJOfGMuoLkzL01g+T6QVsAS4kkATw8TwBIbsZoGkZCWqwyLfyJawUcf4m0hn0Ru768EMW6Ghl0/emwPRBTvOVorNMp+6uwbL6GIAAW2iR8+b0ZDdStGAacF8OwSprcVkPzmbU5ylt7zywWBrpmDj9RhS8KUnU42tvEadKIVPOH+8vtSgOIX0oO3xerTHK0oSPv+eSwYKYnNiZf57qoMy/lpLPyZP8CMN+p9VS5KchJ4AT7qoPTsMUCinLP8bqocoQiUdgbgsUs+j1XKetcB0abcMNE5XfgQZ+j/OfZe5NpX7CrAHowlRlTHh5+spzb0RBnXT3J4+waZzTyEqhUdQ6ZEFr81CbQWSmaff5CZINETPG0G14h0Bk9l75cJ2y46ufI1Pd0nQGRWu/qtsyaA6jBZhr4iTMUCasrnmC7rV3GOHYJHb4 25rMgeCK fsyxwVcvjSaKuIb/3sM7gvNLH71BpOykZvHG/yxCVnGSgjpCuuzgCns99CTSXKsewkPiR/gOlZnh1Rn0XBAefmLPUTK3WfLia85tSR2Yn9TwpwgJfCEv5o93C0NAntswrHw57Gg+k4bpqoFAEEPX6HWso2Of4gEAG4FgmKe1iCkmL0YosM3WnQKtrls7/m3+5TDFpG0KZwDpw4a04q/30UKld+yakXqLp6IUVVLecaiRdzsfMJ6AaeUVKxGfvZeBV+OgcBDwMsuuWgNVlK9RZQXGbksOmtyZEyL306LhMb7KDvex3lzHuvx0uyHCXiQAayuGSPO3VC7iqHjDz2k4nL9g08/VmzSY5Owp58mc6PFwsl/TvzrQgW6tYXIoRBkunh2Ix5N+yBEJn+thiO2zJKvQjbXgC+fIKxMBn1YmvKtStfAGopq1ODm4ck8+nACulr+94Uc0QSAbQsolwpF1737RUa17VZ3a6soYZv//37pvzGHiv6tHRpdjCjkgjpiOwmR7alJXbOTc89qQ5yhO9LFZPPKQtTvCr25AX+6SMjiZ8kd6wI7+W+DAVhVXKWjsY8lDQsuRCLicvgH3/75iPemmJ6yNicri4oh7NPAzmiLuPmm87kjnzf5NVCwH2bfFa96xkrM432FvTtudQAaHSdH64CAYly7KaHC8emvNdjSXSanHVebW6z0aQy2zB4LDnizZqXzeHjHCStL1Q90qFKWbHZUlyU7vqUObuPzrxkXU6/iBDdvFygqvfmPz3RhECB2kQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Alright, so it seems that not all architectures provide ioport_unmap(). So I'll provide yet another preprocessor guard in v4. Wohooo, we love them... P. On Tue, 2023-12-05 at 18:44 +0800, kernel test robot wrote: > Hi Philipp, >=20 > kernel test robot noticed the following build errors: >=20 > [auto build test ERROR on pci/next] > [also build test ERROR on pci/for-linus arnd-asm-generic/master > kees/for-next/pstore kees/for-next/kspp linus/master v6.7-rc4 next- > 20231205] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://git-scm.com/docs/git-format-patch#_base_tree_information] >=20 > url:=C2=A0=C2=A0=C2=A0 > https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/lib-pci_io= map-c-fix-cleanup-bugs-in-pci_iounmap/20231204-204128 > base:=C2=A0=C2=A0 > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git=C2=A0next > patch link:=C2=A0=C2=A0=C2=A0 > https://lore.kernel.org/r/20231204123834.29247-6-pstanner%40redhat.com > patch subject: [PATCH v3 5/5] lib, pci: unify generic pci_iounmap() > config: openrisc-virt_defconfig > (https://download.01.org/0day-ci/archive/20231205/202312051813.09Wbvu > sW-lkp@intel.com/config) > compiler: or1k-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=3D1 build): > (https://download.01.org/0day-ci/archive/20231205/202312051813.09Wbvu > sW-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > the same patch/commit), kindly add following tags > > Reported-by: kernel test robot > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202312051813.09WbvusW-lkp@intel.c= om/ >=20 > All errors (new ones prefixed by >>): >=20 > =C2=A0=C2=A0 drivers/pci/iomap.c: In function 'pci_iounmap': > > > drivers/pci/iomap.c:155:17: error: implicit declaration of > > > function 'ioport_unmap'; did you mean 'devm_ioport_unmap'? [- > > > Werror=3Dimplicit-function-declaration] > =C2=A0=C2=A0=C2=A0=C2=A0 155 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ioport_unmap(addr); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ^~~~~~~~~~~~ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= devm_ioport_unmap > =C2=A0=C2=A0 cc1: some warnings being treated as errors >=20 >=20 > vim +155 drivers/pci/iomap.c >=20 > =C2=A0=C2=A0 144=C2=A0=C2=A0 > =C2=A0=C2=A0 145=C2=A0=C2=A0/** > =C2=A0=C2=A0 146=C2=A0=C2=A0 * pci_iounmap - Unmapp a mapping > =C2=A0=C2=A0 147=C2=A0=C2=A0 * @dev: PCI device the mapping belongs to > =C2=A0=C2=A0 148=C2=A0=C2=A0 * @addr: start address of the mapping > =C2=A0=C2=A0 149=C2=A0=C2=A0 * > =C2=A0=C2=A0 150=C2=A0=C2=A0 * Unmapp a PIO or MMIO mapping. > =C2=A0=C2=A0 151=C2=A0=C2=A0 */ > =C2=A0=C2=A0 152=C2=A0=C2=A0void pci_iounmap(struct pci_dev *dev, void __= iomem *addr) > =C2=A0=C2=A0 153=C2=A0=C2=A0{ > =C2=A0=C2=A0 154=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0if (iomem_is_ioport(addr)) { > =C2=A0> 155=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ioport_unmap(addr); > =C2=A0=C2=A0 156=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return; > =C2=A0=C2=A0 157=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0} > =C2=A0=C2=A0 158=C2=A0=C2=A0 > =C2=A0=C2=A0 159=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0iounmap(addr); > =C2=A0=C2=A0 160=C2=A0=C2=A0} > =C2=A0=C2=A0 161=C2=A0=C2=A0EXPORT_SYMBOL(pci_iounmap); > =C2=A0=C2=A0 162=C2=A0=C2=A0 >=20