From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C55C02198 for ; Fri, 14 Feb 2025 07:19:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 667FF6B0095; Fri, 14 Feb 2025 02:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF98280006; Fri, 14 Feb 2025 02:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 492786B0098; Fri, 14 Feb 2025 02:19:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2A9AA6B0095 for ; Fri, 14 Feb 2025 02:19:48 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C511144EDF for ; Fri, 14 Feb 2025 07:19:47 +0000 (UTC) X-FDA: 83117700414.10.A26FD96 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 09C6B40009 for ; Fri, 14 Feb 2025 07:19:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739517586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rDpMt5awBq4TY6TUR9KTajb7IJ7XbOB9taLnkbXepMw=; b=zcdtSnDadWgInK7vA5O07Awyst1MnhqAP1WdyXsp8Hz946iqjO2uslVC48meiFTmDVR9rj e/jfkP6cqM1lAf6WDak4SwxND9OAdnV3F4+csFWOdR/dsefcTAIbeuSoJv/EyLnJmB7y4D FfPluXFx4/ZvM+2QYR2T1+fGGnSfipI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739517586; a=rsa-sha256; cv=none; b=mp7Ea4h/GYC+SxNqVWncTUc78hH9H7AVDqgbc32BwhTe0DqK22ybdOtS1exCfp2yfTPNzI 4J4lTjUwrEOtNFhB3snL4N/YSYT0VeFTpL0V8ONQAEMeTQ3eDmEgENqsQm2d0CA1LGeiLu 3joVNcu4mE9FMvngYpy8gxBUct9tBKg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B87B2113E; Thu, 13 Feb 2025 23:20:05 -0800 (PST) Received: from [10.163.37.128] (unknown [10.163.37.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 01C283F58B; Thu, 13 Feb 2025 23:19:35 -0800 (PST) Message-ID: <8ebbc47f-c56a-49a0-bf04-930b0a9e84e8@arm.com> Date: Fri, 14 Feb 2025 12:49:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Steven Price , linux-mm@kvack.org Cc: christophe.leroy@csgroup.eu, Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 09C6B40009 X-Stat-Signature: k368romywotg8nktobk3khettgm18rkt X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739517585-192107 X-HE-Meta: U2FsdGVkX1/nhOMZDxvdUMwdALOOHDaH7gj0GKy1JdQj784ZHdd4e+O3y2Wgi+FzRLnLC5wL58RXoXUtnGwCHmQNJtwdbEsgiAlnfWigh1rkNnu99SnS5+6U7PcsdmRPkb4wWeasxgaLWfBXLRdBnFSaUuFUGhUZqORogfRpJ8uN+otK9UN2Y/F7i031awxLfl/OlJQR5omHsWwvONsIac5J8o59sVkPvJxsvA7Dy1KMcPL6Lrh/JLVfWgLbpNOtLm2AaVMAqli5+/wI2KHynlaXe39kabRq4Eqdg1Xxd0rpAdXQFKhQhnAxmvy/CdjCxOFUwMwfmyubzOhRlu10gw+SIZEg5evzz3voQW1GGP+3FB8Y+fBtPy6HGtb+rvSnsRFwphfUhwK2063kPVZlB5VoeIkkZY4j1OcLcT1YjkbRv9Y90n63ZSr4oJXTVSx0a8MdPtqLG3mELsGpADJ71NJSIieJ4LDvHlcLk408lhBoU4gAwce6rVKu17O/6O48OZO/KZ5vSzyhPG656nbZoRI7KFsE009H3Bv7o5ho/riqaVL/kzG3/chXyGGcesnF8/5ze98uMDlRS9huwDyLC8jdWV3fXLeCvusaYXPjhcjcSm9cpe7cFeXQnOcl4RHAOEq52gxNWOxGZjSR/MbNbMbNoypzu7e1FH1/ZreQfPfa+iCVYXliHniHGzFrCVPTmveIsEWo7IfJD3foPTG0ePdIQI5JuLsKwVJAh3S72GebfbCn7pkVISzc/bzP4iuOh3on6bhrHgNAA2jlb4HXjzQEvHRIQ8GXO87Xk86qyEo/SflWJeXHmxMn/AksEyyjWJlahRlR20vkGzGgLhCWOfCDyOxjuMYE8wKcm5ge8gTPt/vj5pz+CiHIBGM52AENu6kO9Lj2HZLk9PBlz2Wk11FLNyyl8kUqociP7am/XsDREgkZu5+8zrvgSg0hts4FRHtEazRVinSifk47nVj vXaxWIhe ZeaA88rF0eA7XSxcuhh5cu9MhfFtWvchJayHj7XbER34U9FRRAFmcdKg4zDfB5QtWuI90W8CvYfqpB57BSYR08iqZsbd2YbZXWdFClB+uCpuRyp3/Ymqjx5ouIo+fq2YqpXRhri+r46T63hIm4RwGeZQUfInPDfEYzCdnZw1+MDbJc5m7etLTX1xbevQ9msMidpYrHNC+PqD7dslNwaNjm4D+5Vb001d5hsXx/vBNKNy1KkjXh2/W5uuzjRZjhemjmjM4GcVihV/UFbXNgmktFHl9PnH37/LSA2Ux93oBiq4qUF1J2eUuaZJ1RIrI6hgJpQ6DjCpoTVxtKhMMAelBBe8GOwywbRxGAdtRQZBODLafjIt1yDxrXU7iZTNqUIp5LtHv4TyO5uokAO1ljZlhOcB84Y4XBwvkyFxJAW96k66XYvMIxOC2CQSnzB34n+MrHLnyFCUn6W1sNg8iFqOdiOfW/OYpVkbcOLzuSgBtW+kF7FzxweITyy2qY73Iu7nqvbe0XvPiizFeqWnHKRxKXCu5tWrFLWJT1NXEn+Ae5CckwUUS8szExUrgGO3Q9ZZE4KjUj+Pj0XJ3kiH+PdqXBWCkjnaA6GwWr4Faw/LqRuUS0y0QPAkreb3n1jtEgR6GG13WRuuAvOD0EoqFfPT9Oo0v4hTWDRxt46UPWOwjP9ONmTXgNRTU27DbjUHLwGgHgKm22uZnuBnZteKRvoo3diENQlvCztR8J6FIgmxsrhEqyTmk/D9gjLyw11F5QiYMwP1I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 16:53, Steven Price wrote: > On 13/02/2025 04:09, Anshuman Khandual wrote: >> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >> is confusing as they sound very similar and does not differentiate between >> platform's feature subscription and feature enablement for ptdump. Rename >> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >> readability. > > I'm not going to bikeshed over the naming, but a few points below. > >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Jonathan Corbet >> Cc: Marc Zyngier >> Cc: Michael Ellerman >> Cc: Nicholas Piggin >> Cc: Paul Walmsley >> Cc: Palmer Dabbelt >> Cc: Heiko Carstens >> Cc: Vasily Gorbik >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Andrew Morton >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-doc@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: kvmarm@lists.linux.dev >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: linux-riscv@lists.infradead.org >> Cc: linux-s390@vger.kernel.org >> Cc: linux-mm@kvack.org >> Signed-off-by: Anshuman Khandual >> --- >> Documentation/arch/arm64/ptdump.rst | 4 ++-- >> arch/arm64/Kconfig | 2 +- >> arch/arm64/include/asm/ptdump.h | 4 ++-- >> arch/arm64/kvm/Kconfig | 4 ++-- >> arch/arm64/mm/Makefile | 2 +- >> arch/powerpc/Kconfig | 2 +- >> arch/powerpc/configs/mpc885_ads_defconfig | 2 +- >> arch/powerpc/mm/Makefile | 2 +- >> arch/riscv/Kconfig | 2 +- >> arch/riscv/mm/Makefile | 2 +- >> arch/s390/Kconfig | 2 +- >> arch/s390/mm/Makefile | 2 +- >> arch/x86/Kconfig | 2 +- >> arch/x86/Kconfig.debug | 2 +- >> arch/x86/mm/Makefile | 2 +- >> mm/Kconfig.debug | 12 ++++++------ >> mm/Makefile | 2 +- >> 17 files changed, 25 insertions(+), 25 deletions(-) >> >> diff --git a/Documentation/arch/arm64/ptdump.rst b/Documentation/arch/arm64/ptdump.rst >> index 5dcfc5d7cddf..a2e527377da3 100644 >> --- a/Documentation/arch/arm64/ptdump.rst >> +++ b/Documentation/arch/arm64/ptdump.rst >> @@ -22,8 +22,8 @@ offlining of memory being accessed by the ptdump code. >> In order to dump the kernel page tables, enable the following >> configurations and mount debugfs:: >> >> - CONFIG_GENERIC_PTDUMP=y >> - CONFIG_PTDUMP_CORE=y >> + CONFIG_ARCH_HAS_PTDUMP=y >> + CONFIG_PTDUMP=y >> CONFIG_PTDUMP_DEBUGFS=y > > I think we should drop CONFIG_GENERIC_PTDUMP/CONFIG_ARCH_HAS_PTDUMP from > this list. It's not a user-selectable symbol so there's no need to be > documenting it here. Sure, will fold that in here. > >> >> mount -t debugfs nodev /sys/kernel/debug > [...] >> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >> index 77306be62e9e..db005618690b 100644 >> --- a/arch/powerpc/configs/mpc885_ads_defconfig >> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >> @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y >> CONFIG_DETECT_HUNG_TASK=y >> CONFIG_BDI_SWITCH=y >> CONFIG_PPC_EARLY_DEBUG=y >> -CONFIG_GENERIC_PTDUMP=y >> +CONFIG_PTDUMP=y > > I'd suggest dropp this from the defconfig too, just like patch 1 dropped > it from debug.config. Agreed.