From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C8CC02195 for ; Mon, 3 Feb 2025 08:23:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 989FB6B0082; Mon, 3 Feb 2025 03:23:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9137E6B0083; Mon, 3 Feb 2025 03:23:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 765616B0085; Mon, 3 Feb 2025 03:23:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5877D6B0082 for ; Mon, 3 Feb 2025 03:23:32 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D6F36A258B for ; Mon, 3 Feb 2025 08:23:27 +0000 (UTC) X-FDA: 83077944054.14.C11D0E7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 5C105180012 for ; Mon, 3 Feb 2025 08:23:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZuBqgcKe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7iIKn+5p; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZuBqgcKe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7iIKn+5p; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738571005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QscREU66K8X2sJefqq0tXxJIsX54WV/2ZD1yiZ66+GM=; b=VAyUmcQMKvGDmoTfmrN9NmDOOxllHrvowtq7rptXqPoQQxMxn0GZxMkWgqJnZ6kdymeLdc MDGVnbd38Ghdgz7VHikcWA+tuhIusGr70VGNJhxFfI0fv1HbEa5eLOMldgeWlnkAOMB4qD d0Os9klO9POHtkTc0onlUgigpDdUuPU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZuBqgcKe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7iIKn+5p; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZuBqgcKe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7iIKn+5p; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738571005; a=rsa-sha256; cv=none; b=OBBztJ9It0MkefAA0WQkpNyBLc5sCZZjwtgox75ea9V+TzXqL0kl/D8WTIemI055FUyqf0 sdENfwzWka5TwpidgxS1Kw98Z+rkeSveCTWmreiRCykDN8mAYcTeHTTpV4UudzuBkv1r/O CPSsM0sAgR4/H+Y4FgNx9AeS5pU8m5s= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6A4591F37C; Mon, 3 Feb 2025 08:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738571003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QscREU66K8X2sJefqq0tXxJIsX54WV/2ZD1yiZ66+GM=; b=ZuBqgcKewhedPzXiWdk4R18UeVLCwQxz+RFP4c2m57oYbtQk9gydo7Trv6XfKcm08UJiuY +xiP/JXT5u236FGjd0z9ff3QMK0zZvUvdF1QXHZl3hcaH3YXXtRqHrbuZNCqaObb3NW29d L96FDFG0OyfdjM+ZtvROr4Q52rTOX/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738571003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QscREU66K8X2sJefqq0tXxJIsX54WV/2ZD1yiZ66+GM=; b=7iIKn+5p0NhOtU+E+UgXJWa8ESz6G1NFNA/01G7zM/ZJKAtiBvfk04odoi/i78PtzNOOYF jSXdZhXysUXr/0CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738571003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QscREU66K8X2sJefqq0tXxJIsX54WV/2ZD1yiZ66+GM=; b=ZuBqgcKewhedPzXiWdk4R18UeVLCwQxz+RFP4c2m57oYbtQk9gydo7Trv6XfKcm08UJiuY +xiP/JXT5u236FGjd0z9ff3QMK0zZvUvdF1QXHZl3hcaH3YXXtRqHrbuZNCqaObb3NW29d L96FDFG0OyfdjM+ZtvROr4Q52rTOX/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738571003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QscREU66K8X2sJefqq0tXxJIsX54WV/2ZD1yiZ66+GM=; b=7iIKn+5p0NhOtU+E+UgXJWa8ESz6G1NFNA/01G7zM/ZJKAtiBvfk04odoi/i78PtzNOOYF jSXdZhXysUXr/0CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 47A8813795; Mon, 3 Feb 2025 08:23:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HeXREPt8oGfSSgAAD6G6ig (envelope-from ); Mon, 03 Feb 2025 08:23:23 +0000 Message-ID: <8ebae11c-85bb-4535-bebc-646dbf575f5d@suse.cz> Date: Mon, 3 Feb 2025 09:23:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] alloc_tag: uninline code gated by mem_alloc_profiling_key in slab allocator Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, rostedt@goodmis.org, peterz@infradead.org, yuzhao@google.com, minchan@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250201231803.2661189-1-surenb@google.com> <20250201231803.2661189-2-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250201231803.2661189-2-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5C105180012 X-Stat-Signature: 87qqn3eirctr6tq1t54jbkdd1ukdxatp X-Rspam-User: X-HE-Tag: 1738571005-891183 X-HE-Meta: U2FsdGVkX1+dGTmmG7YEpFIpChVWGX48QieTsUtUhsRoyYlpsIYqxFf2IASZVXmcl7mt52RoqtwSydETtWuX9YTxiesDLuVVYSkGLq87aKVkURRVC8JVC48E4J/RgU5iYMJlXB5r4wNmpaBMsmIKYzw7yV2sPWOg5wr040Y2sTB11iyrNq/XunFJNdWbU2pFOeCLCM9+LRYC+8k6KVtLlpfzbbMTlWZ6Y/lOrmQVilApXQuKxl5rdzCiBG9ZQIntV3VC3rN5YUOgb5JCe2NrYPou3DdpawkS65PQGWeTrHLN75X9yhL3YSnVCN80LVPcEAy5RbfZ1tbPOH0rIl6v7X4bv5JkNdM2bFzGwAHEIBSY4z3QwNWiSmUJKowxJGRXtuX0K0C3PzLHEbK6GHuMIkohhVdskxRvLub1eJTJDlinl3Zoe4VV1C27Gx/U4f+iL9BVnRgL5YADFYQqsmWNfDCLkin1IzDEzDgjanzc5I/LuIe1mNFpOmAlv2skpp0K1enT1BgBWly+dGUygcnK9U7a34e8rnU0KYboD3PFlhyWuZpStSS6e/6CK7Cg7L20m7R4Iz5+tt5AWK5BhquuwYlA6MA7GEzJZrFFiR57yl2bhW1ME2/P6JnVPnxVolG2sby1fQdorXe+hP+aiLGV1FIi/P47NUms9LYRr+Qa/cluYcOrJXK6ANvhNGlbiU9MJUjd9WQGXUFa+SBAIgzHrlIZC29q9xpsRLKRl3xpobmcsS3TIcJuXyFRfSSnzNKkcu56Yrk6J7Ajz81My9ys6x3f19xN2a7WfKCRvLTs6gibDaHBo+1zQvZnYSCTpYHfiowEw3qqffyJsBZotLc0PqyAGpnB0lrZydJBGEJyHaUXoULz4sGGZ/6FXStDlubBxhGhvxG+4bUVJgxVCbZ/n/6QsbJi+9t0qwg9TYBG0WcbYDhrZdDXutHsP1s1IvV5ul8RQCvHmr7bEQFvw8U Y5hQ0xdT HeYbr6j4JkFSHY2/yBWhT+me1B0kLM2lmLAD13sCvVQ3vvhNGvB3O2K2EghDjXs0CCkhBdd4+ENoafHD0ULw6CmbTucBrseSZOITG5TLmE65OuJCNygBLO4oBpfCMHWpohVEExmLBn/7KmMQM06Ss6+tZsDqgl4oDu3UTBQPQd4ZrdaUBYV+Wl2EDikU6iobx204QSYj9dSrP+FWHvbAuQrlNXuS4UZHNNmBwO0K4l7/Tkwy2WFRsBT3RZ6ay41hkgyCE9pdbqkk2Kw9Pu00otI0io5I1CWmvyI0/Kw+L+PbC0Dx3d9Xl7Yo9p58Hp8o7lCPHodetw4RReUw0yFTaZID8c/RTjWfLoVlXIPp7OzhB9s0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005805, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/2/25 00:18, Suren Baghdasaryan wrote: > When a sizable code section is protected by a disabled static key, that > code gets into the instruction cache even though it's not executed and > consumes the cache, increasing cache misses. This can be remedied by > moving such code into a separate uninlined function. > On a Pixel6 phone, slab allocation profiling overhead measured with > CONFIG_MEM_ALLOC_PROFILING=y and profiling disabled is: > > baseline modified > Big core 3.31% 0.17% > Medium core 3.79% 0.57% > Little core 6.68% 1.28% > > This improvement comes at the expense of the configuration when profiling > gets enabled, since there is now an additional function call. The overhead > from this additional call on Pixel6 is: > > Big core 0.66% > Middle core 1.23% > Little core 2.42% > > However this is negligible when compared with the overall overhead of the > memory allocation profiling when it is enabled. > On x86 this patch does not make noticeable difference because the overhead > with mem_alloc_profiling_key disabled is much lower (under 1%) to start > with, so any improvement is less visible and hard to distinguish from the > noise. The overhead from additional call when profiling is enabled is also > within noise levels. > > Signed-off-by: Suren Baghdasaryan Acked-by: Vlastimil Babka