From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA65AC5AE59 for ; Thu, 5 Jun 2025 14:32:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39DEC6B014F; Thu, 5 Jun 2025 10:32:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 375416B0150; Thu, 5 Jun 2025 10:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28AC46B03D0; Thu, 5 Jun 2025 10:32:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B0876B014F for ; Thu, 5 Jun 2025 10:32:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91128120C1B for ; Thu, 5 Jun 2025 14:32:54 +0000 (UTC) X-FDA: 83521588668.10.7A297F1 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf26.hostedemail.com (Postfix) with ESMTP id C4609140010 for ; Thu, 5 Jun 2025 14:32:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hQJ6vm58; spf=pass (imf26.hostedemail.com: domain of jirislaby@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749133972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IHxtiZq8OHtxNHVgJsZjWzxWLg5oG1CcdC/fLDa2kQI=; b=gZ1UVSVSyVsEGIzzhLtr0V6rELg6FlGxpGHLSc73AzFio5buQ9btwSz0fW0bVipe0wnL+N n4dUl6cLLjvOe6U6eZHOuM2cdIlGjYn2jfx4i0TQrsvFjj4PshjmtgK5Dy1LfdCY4xpd8J CdidvYT/RplOZK62vhVtO2D55RgxRy0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749133972; a=rsa-sha256; cv=none; b=HXZdfYUM47+sP7Go5SQtjTIdFiLWfgoWqVQDrCGNqcscGTea62I+nXk9N84VgMM5HebRHq ioxgMsW6lAyTOf4rzUSIIuvariwlHJKf9qMLyaNAkM1J6l1/DzgsvdlK+ksLs5kiGPJ4GJ BfzmhoyY6FchP8CTmTdKTU6K4KhYzXI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hQJ6vm58; spf=pass (imf26.hostedemail.com: domain of jirislaby@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D9D376112E; Thu, 5 Jun 2025 14:32:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A35A7C4CEE7; Thu, 5 Jun 2025 14:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749133971; bh=dJhCM9RPviR0g7JT1D5tY8Qs8gank6kHriTlr+jVdk8=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=hQJ6vm58a9sKrWs9pbShbS3RA6iSmi0wkOqOIohbxsH9H+Q56BxXzsFbZ+ejQ1ycp 3HiA6msSez1IKjXj45/iK33pnzB2iuvu+keB9Cfeg+Xgut99Tu90vSSq1zRkSeOMGO fbKbvoGkG/hF/zHS7/Wz1RRGwQwUFZHoANS2Xw+kzuh7GQES6DzUaYmOkKr1PLmepz k9VBLzQG0R6cbmHU+tgErk05+UtA79vzuWFGsQgQBgb1M3fM1u6T1d38LkHS5bLh/m V6zUEf7o8M06Dv8P+qWU1JspV1TZXG/+kxnPZ+jlj7V6H0rSt13SJOXVlpFSV8StHm bkkhv+tpwoK2A== Message-ID: <8ea2aefc-2847-433e-b56e-5caad49e54f2@kernel.org> Date: Thu, 5 Jun 2025 16:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] From: Jiri Slaby To: Uros Bizjak , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org Cc: Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu , Alexei Starovoitov , Daniel Borkmann , John Fastabend , bpf , Martin KaFai Lau References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> Content-Language: en-US Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C4609140010 X-Stat-Signature: 6opdxadem79cnxp9i37cdiz6qkaxaeew X-Rspam-User: X-HE-Tag: 1749133972-555829 X-HE-Meta: U2FsdGVkX19uFMhuwPcHUQ3wOHa2CGDqajgc335GCliIk6LeNfEJqkFd3EZKb5DKN9zFQ77RkPvDTN23UHjG58OdJPBKTciA+L5+iR+w6nrSQ0NWExIa2xm4Fjfk54+tQwbmEzEBqYRQOTrMrDyczKU4VXI84a9v7fxwmcUQMDMpYAdSRis3s7f6yukr8mPOo8ek/oHxyxQ8eumqYfC70zjFaqtB1nFY7XUvHxhkvpZo9NMMlivl0lhiyqJnqaBWSsgrmuqu43UhQ9FpMwVHCY5rKwQKaA6DhgGPZxijDCf1yd9e0g6QRRxkQNLxvYg0IFfhq7R/RPgV+xhD3BleL6Y+x2sFk9X7gDtV2lyhDVjISK7dW498bog1bmij7c3vXYq3ys0QgeHvuLDHXvgGCNBlIN6CcQdEaoA8fb8Itz1rIvNmSnd6+6kouJqyKGfq+aSlHnmyY3wbbSicKTLzWK4ilKlcTymBAb9L19H0PkOKF1JKPMO96zGsbDcvQyrZUiFgA+Ckrii6Knf3liqTXCvTH47K6plUFBe7TMQX5RTAuj68mygpWEsfpYUoc6IjlcF916930KLPri/Hp+Ln8c3eSZobYcw1gwBGvIDpEs1B0vvKPGzZWw+iL75oav9H14MTkcSZZOnYy1Qp3288bW2ywPNNTwaJBDU4fvRyonJ/aaW21nov1Fhv/nqz9fEG8Y9abllAATMEXDsKPD2hPP8Im7C7YTGOorOzJEnMk3gte+c1phwas480Cih41V5fEYadvfvUkgiU/hoPLGoqmfH++tTOEv0HBzQhcwKYJQGYV4f43cZwzjDttpH1yOLsFesgF/78qeYRrmJeu7UJiy3/BsnWCZn0Z6PPvpBp9TnU2G9+peqesgESyq9S3Z1kg5tTZ9qnx4kQVFX6WzwKoSjJrtZKNVThrgkcbaEFTDX1PkO66yStsG1eVA78g1Lwd1UgdUQbEnxwzesKyOD Q0LR8rxT xQiW9i9np+a3wYUHZilPJqCWTJpJAa5d32sC0XMfDEPfwL6R7JkhyogEmgVHg08oFhHqxPCLdqzVrWPIuTh0TdOI5h/YL3X6LZy7fvDDRXG3K3KeLMv9SM1DQMQ33nSEwrqjk0GcKpaNZirBVI6AzfLjCdjY1WIrGgom3pWFiFji3ZZ4aBoywNS3x6VA69TTJEecFTTKMfqkTe4acCfIDJJjDbRdAxZlSOYpnbJ2nXe88yNIhjB98JvIberSd0NGtwak84Se1A/UI4GiUeUZVEKYZIXvNjvDh+lNKBJlpp9GGk7oSKRtZGqtC8TBLxkpDWHxmpGxy38djpUy1gzO8JwiiTWX4NudSRM2HpnOHmCDsMK2ZQ4a/WFGepFkj0NzhH6/z4N0AC4nwMoEpf2qCSSpxaNGUimoUnB9Ffj0Iy6zcrgyq89wfEvKQc8FViO3UBWS7SHOQSDun8fkgANtyFs0VKaT3Ch2Up9fPSsCy3IE9K8n1gIGZwD6ZmVugB6QXS1lxrcvS9ngZxnT36BrvazVjKXWGGyJQma2jZHeItsbfk0pui/CiLOprju0vNL0uVT3FcKC9oXHHLECcICuvCjy0k2iA9XwgscFSemnUyvCN+Tv270i+9btBPCmtAZFHZBY/U0t6Wx3luQMvmyNJNlKZ7f6a4cQN3l7aPCJKfgym9USRbrREKj/SkJmUUP+Owk1p4NYaYs6zbCB2HRAGANPydQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cc BPF people, just so you know. On 05. 06. 25, 16:27, Jiri Slaby wrote: > On 27. 01. 25, 17:05, Uros Bizjak wrote: >> This patch declares percpu variables in __seg_gs/__seg_fs named AS >> and keeps them named AS qualified until they are dereferenced with >> percpu accessor. This approach enables various compiler check >> for cross-namespace variable assignments. >> >> Signed-off-by: Uros Bizjak >> Acked-by: Nadav Amit >> Cc: Dennis Zhou >> Cc: Tejun Heo >> Cc: Christoph Lameter >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Borislav Petkov >> Cc: Dave Hansen >> Cc: "H. Peter Anvin" >> Cc: Linus Torvalds >> Cc: Andy Lutomirski >> Cc: Brian Gerst >> Cc: Peter Zijlstra >> --- >>   arch/x86/include/asm/percpu.h | 15 ++++++++++++--- >>   1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/ >> percpu.h >> index 27f668660abe..474d648bca9a 100644 >> --- a/arch/x86/include/asm/percpu.h >> +++ b/arch/x86/include/asm/percpu.h >> @@ -95,9 +95,18 @@ >>   #endif /* CONFIG_SMP */ >> -#define __my_cpu_type(var)    typeof(var) __percpu_seg_override >> -#define __my_cpu_ptr(ptr)    (__my_cpu_type(*(ptr))*)(__force >> uintptr_t)(ptr) >> -#define __my_cpu_var(var)    (*__my_cpu_ptr(&(var))) >> +#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL) >> +# define __my_cpu_type(var)    typeof(var) >> +# define __my_cpu_ptr(ptr)    (ptr) >> +# define __my_cpu_var(var)    (var) >> + >> +# define __percpu_qual        __percpu_seg_override >> +#else >> +# define __my_cpu_type(var)    typeof(var) __percpu_seg_override >> +# define __my_cpu_ptr(ptr)    (__my_cpu_type(*(ptr))*)(__force >> uintptr_t)(ptr) >> +# define __my_cpu_var(var)    (*__my_cpu_ptr(&(var))) >> +#endif >> + > > Another issue with this is this causes all modules in 6.15 are 2-4 times > (compressed size) bigger: > $ ll /usr/lib/modules/*-[0-9]-default/kernel/drivers/atm/atmtcp.ko.zst > > -rw-r--r--. 1 root root 10325 May 13 11:49 /usr/lib/modules/6.14.6-2- > default/kernel/drivers/atm/atmtcp.ko.zst > > -rw-r--r--. 1 root root 39677 Jun  2 09:13 /usr/lib/modules/6.15.0-1- > default/kernel/drivers/atm/atmtcp.ko.zst > > It's due to larger .BTF section: > .BTF              PROGBITS         0000000000000000  [-00003080-] > [-       00000000000011a8-]  {+00003100+} > {+       0000000000012cf8+}  0000000000000000           0     0     1 > > There are a lot of new BTF types defined in each module like: > +attribute_group STRUCT > +backing_dev_info STRUCT > +bdi_writeback STRUCT > +bin_attribute STRUCT > +bio_end_io_t TYPEDEF > +bio_list STRUCT > +bio_set STRUCT > +bio STRUCT > +bio_vec STRUCT > > Reverting this gives me back to normal sizes. > > Any ideas? > > FTR downstream report: > https://bugzilla.suse.com/show_bug.cgi?id=1244135 > > thanks, -- js suse labs