* Re: [PATCH] kpageflags: detect isolated KPF_THP folios
[not found] <20240705104343.112680-1-ranxiaokai627@163.com>
@ 2024-07-05 14:03 ` David Hildenbrand
0 siblings, 0 replies; only message in thread
From: David Hildenbrand @ 2024-07-05 14:03 UTC (permalink / raw)
To: ran xiaokai, akpm, corbet, usama.anjum, avagin
Cc: linux-mm, vbabka, svetly.todorov, ran.xiaokai, ryan.roberts, ziy,
linux-kernel, linux-fsdevel, yangge1116
> - } else if (is_zero_pfn(page_to_pfn(page)))
> + else if (folio_test_large(folio) &&
> + folio_test_large_rmappable(folio)) {
> + /* Note: we indicate any THPs here, not just PMD-sized ones */
> + u |= 1 << KPF_THP;
> + } else if (is_huge_zero_folio(folio)) {
> u |= 1 << KPF_ZERO_PAGE;
> + u |= 1 << KPF_THP;
> + } else if (is_zero_pfn(page_to_pfn(page))) {
We should also directly switch to "is_zero_folio(folio)" here
> + u |= 1 << KPF_ZERO_PAGE;
> + }
>
> /*
> * Caveats on high order pages: PG_buddy and PG_slab will only be set
Especially relevant in context of:
https://lkml.kernel.org/r/1720075944-27201-1-git-send-email-yangge1116@126.com
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] only message in thread