From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA33C30658 for ; Fri, 5 Jul 2024 14:03:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DF386B009E; Fri, 5 Jul 2024 10:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18F6B6B009F; Fri, 5 Jul 2024 10:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 008896B00A0; Fri, 5 Jul 2024 10:03:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D6A346B009E for ; Fri, 5 Jul 2024 10:03:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C81840166 for ; Fri, 5 Jul 2024 14:03:24 +0000 (UTC) X-FDA: 82305866328.12.32CC4DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 32EBC20020 for ; Fri, 5 Jul 2024 14:03:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="a/I4yayE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720188182; a=rsa-sha256; cv=none; b=MoqtdI1pYK5+gE6WFu2VgKajSXB40SxBUN/f+XoOF9TEUXSpxCMlzxg5lMLcLGmLhwr04t OxxRxjGha7+Pz2D3tNp6+xapTNJlrdumw36zC/flBfJEk8dC93Lj/VoFz7O2vWIL2ilBxD 39PihE4IAHTFHvXyRSq9o/5Q1nh4jxc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="a/I4yayE"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720188182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tcFyaq/x3BT52iyZhmpXyGxuAICYLbboWOWxjG0cb0I=; b=8dDsYBOqCaVrkNbRgg9f5RTzCJ7aSfTkJf+wpV5qTmP8GL24BXrqG2yxHJA6rw6Ma7G1hC jgTCrUxeXmLB2D/qAk3nsv7mqT8elfrjKJVbI29zXqu9MoiwC/pTcQ/nsNPyqc8QkvX4fY JZxpVAD4U6xkWXyvG8XuG0d3R9Qib8c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720188201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tcFyaq/x3BT52iyZhmpXyGxuAICYLbboWOWxjG0cb0I=; b=a/I4yayEFPe4HsmBMvtettY7lTyMyny1xMkp2Ias8MZmZkprIOf05f2ByA1PdVEs9QOf97 WmqiuSNihYe3XFg5Z/NjU7iX2BXmXsrXCnphwToNoD2helCi/rH0hHFmn8dwyH6PNz4j4K 9JGLQA7IbaTUnTMTi0+P3jqGhnO9R38= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-qRAxgKMcMO2hkp1qplWYmw-1; Fri, 05 Jul 2024 10:03:19 -0400 X-MC-Unique: qRAxgKMcMO2hkp1qplWYmw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4256718144dso17552805e9.1 for ; Fri, 05 Jul 2024 07:03:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720188197; x=1720792997; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tcFyaq/x3BT52iyZhmpXyGxuAICYLbboWOWxjG0cb0I=; b=EZaMT1Cido5tm/lQ0409HcddRUp/OIoKK7iPaR1ttxt9pCqDa0BRV5L6ePc3F0+w+w OW22cPJjYxCA3I84jcnUxsaXCw38PSDfngWaHGWWVyX4QRPIHo3URrkj0Bse7n35w8WB bLY4Gnb6ECOQAzdPkbUafezXHp9xY02cvZrlSFiSX8dU6SIZV7KvGMAjaGS3dJkLjWEV R959sLf589SBGadQmwlxQmTWgvUJ/SQ5FSqGFw+vGzZLNO/lyykDOBe1mVjt/vf/7HFc v7p1dRAzkM+hQEXdYDeuMyvm+zb8XlyTEBnXyQQqo0X65r5AKf/8Iz95Lt1IQFUb3urf IoIg== X-Gm-Message-State: AOJu0YwLifnRa699CCemW9xzRX7k76/p3/ZZnauKLbxnlmhJHxR1AOOO UYJefYMBJWW+Uu719fuLmhPMqsBdaSfp89Zfv6YcDfTWcFv6Xh7unN4l6wAf5Rdlag0FxACiDls MJL+yOQzN/6IoP4O2ato4vFJLVrEuXqvJdkqESd9bBbXAyYYY X-Received: by 2002:a05:600c:3b0f:b0:425:63b9:ae2c with SMTP id 5b1f17b1804b1-4264a3f3080mr39700025e9.27.1720188197482; Fri, 05 Jul 2024 07:03:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLP0Y16Pr3AIIKxriH+7I8UOU7YRcbiBw1n4dgPEZPtVME9hnXFSCpZehbQPgJaJAlIq4dFQ== X-Received: by 2002:a05:600c:3b0f:b0:425:63b9:ae2c with SMTP id 5b1f17b1804b1-4264a3f3080mr39699685e9.27.1720188197060; Fri, 05 Jul 2024 07:03:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:b500:3ed7:a1c7:447e:2279? (p200300cbc702b5003ed7a1c7447e2279.dip0.t-ipconnect.de. [2003:cb:c702:b500:3ed7:a1c7:447e:2279]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a2ca5casm64150655e9.32.2024.07.05.07.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 07:03:16 -0700 (PDT) Message-ID: <8e9da8da-20f5-4316-a449-5544d9883c1e@redhat.com> Date: Fri, 5 Jul 2024 16:03:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kpageflags: detect isolated KPF_THP folios To: ran xiaokai , akpm@linux-foundation.org, corbet@lwn.net, usama.anjum@collabora.com, avagin@google.com Cc: linux-mm@kvack.org, vbabka@suse.cz, svetly.todorov@memverge.com, ran.xiaokai@zte.com.cn, ryan.roberts@arm.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, yangge1116 References: <20240705104343.112680-1-ranxiaokai627@163.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240705104343.112680-1-ranxiaokai627@163.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 32EBC20020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3shuhoqw6gpzxu9fgd548sdjio4yhehf X-HE-Tag: 1720188202-503340 X-HE-Meta: U2FsdGVkX19A6Py64hfAuLNreDl5L8U6hnbm0kzcvhOllwKuZ3ssgthybKCoPp4oDm2xoM+RDz7cVi5KXYvT9QpzEBB7Hmqtu99yipUKvQXKAiA/cSiFsk3hfnkymXU32cM1eIeQA9TiHXe+whgCgk2IZuE8/nD7HYtOZVp+2k9ojxxCVwEiNTLyjvR9MOrLCVydGCEsns/96wzZ2JniGZ5JhnLQi8TqLWmvL2xbtu1+ZUSLfpR4U0P47a4tnR+l74u7F5gaWFAHzBVdZNbc88GAiZA7DMMDgYa52iE8jQ6DM2zLtZLbXbngmmGJ+og7l/1dmoIRL7MyU2vwB0c4VAuflROhvDbn2ASqOePKG7JrJN+9uY2P5LllCgovbXxjYjPw0EmB6C4gukTJ28ywrOmv2aUeV82UJNElWggUIanqPsHCb0fKsZYFJGAE3rjeblJICEPkO/xgLwB9ZVrFuEGAqgT9Whii2evf9SdT9ajU2H8mIi6E/zYHMDfjGFkAbpbpBEWe902iI9JTC/q/uCExGGC4xMWzd3kydnbQnQFJKQYDy9DP3mRLdEoUdCXL8PE6YNRx3dRKo/l1ksCWkygJUC4kc8Yt4LDzbioCi4zAe4l8vN5c6G6UAqtuFbAedb0jn+dwh8DbQPx9+LNlWhxPg51Ix6PG+sVE9lbqXQUtTa7665uFmeImCEb1Krcg0doI3rIz1tc5U6sh0t4EhiXreMCkOM3wH/Ar8HNINBd3dyMZFNAnSOuw/Fm2EchiONmjGKYSDA+ml8408IlmLOkzo6xR0NHK7rnHcK4sxe7kuz+2xMyDarzEs65rkOQD72kWSljMaPJC08f8kfbeoOKabnX9zI1TVUrcHS2L5Od4rZ5bl17i7FqwJGLto4IApQNoKnz3alIN5m/FuV/pWB0zhldFArpzrqFVQOAsa7VIeehrhI3n/v3Y2UCxssW0yJ683cfLrp+FJHRenyh J6MduubI RrFORBcQ6skfZGukxKWeZzphlMR0/6LE0Wm707mB0lHHdtD6ghqN+zMKAIcB9hE1oDKqM8LvIkKkAm9YeYE8Pfj+bAHuJalHQkJe85aK2vtfRmhWf3KXvkIKqaXW0d+0k5Ca0r1retII1rYQWaJjj+8Wq6Uwel8jqOeqAHWPkTlCXU2UTbPR4Jal4iu/mBzCWVQQ4AWoM8h6vT3zQ83TkhNk0VBbXQKlDIJzPY9GtYfz31dxw16hn8ksR5bSdEPWOqIWRpDhuKApUscv5P6kWM6VzLXF2Z6H3capNh4SI5g3ncHsqvAwAlNymbesF1C3pkiN5081Fqr0j2VJWvRpyq7pEyIWFk2Y72g+c2hnX0rMP4p/xiAbNlG384rLuAzvcU7DXry1R3BDhkQaPaHR+8g48ciCSHS1l03MuAwP24vsIvDJNSVT1A8lXbkznoWqlacdpQXsgXK/l0ykakywsNx4fw+zKh2ItTBke719nUUoCPMb2nBykV9xOpY7B9eBEcdvgdwGBcxSKsrsH6sbVa121FqhPwiuaFfFeTFUGIyCmrLI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > - } else if (is_zero_pfn(page_to_pfn(page))) > + else if (folio_test_large(folio) && > + folio_test_large_rmappable(folio)) { > + /* Note: we indicate any THPs here, not just PMD-sized ones */ > + u |= 1 << KPF_THP; > + } else if (is_huge_zero_folio(folio)) { > u |= 1 << KPF_ZERO_PAGE; > + u |= 1 << KPF_THP; > + } else if (is_zero_pfn(page_to_pfn(page))) { We should also directly switch to "is_zero_folio(folio)" here > + u |= 1 << KPF_ZERO_PAGE; > + } > > /* > * Caveats on high order pages: PG_buddy and PG_slab will only be set Especially relevant in context of: https://lkml.kernel.org/r/1720075944-27201-1-git-send-email-yangge1116@126.com Acked-by: David Hildenbrand -- Cheers, David / dhildenb