From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BB3FC6168 for ; Fri, 13 Sep 2024 17:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37086B00BB; Fri, 13 Sep 2024 13:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4C26B00BD; Fri, 13 Sep 2024 13:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D37936B00BF; Fri, 13 Sep 2024 13:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AFA5A6B00BB for ; Fri, 13 Sep 2024 13:21:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2EF0E402CE for ; Fri, 13 Sep 2024 17:21:51 +0000 (UTC) X-FDA: 82560382422.08.AF368A1 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf19.hostedemail.com (Postfix) with ESMTP id 3F4A61A000C for ; Fri, 13 Sep 2024 17:21:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AHIukaGe; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726248079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79/o/xeQuArc1/2zAHjCjM9ULnnYMrBSWHdVAhyawN4=; b=DqsYVh4At9uxbRvkJCru/W1uFd/du0jGpLfQUJZQG9+f4QMC0S4qSbsI687lTmsg1dGL+8 aCBoO3DiBYjoDBEiZUpjLmT2Aif33N4BnS2WdhDD4G4KqDaRxiqhYrlnh/wBfwgeE74WAt 0jf4AIv3lETCLd3iU3k77xWcdhibFdk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AHIukaGe; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726248080; a=rsa-sha256; cv=none; b=hoXFhzE3yQT79EJOHiOp1788fmMm0HvPO3DML73/UYob+RwxJVpFdgA+/+xES9T5exwjEy Zjhp2Gz5vuH1PXEnkemx4V5ypz3JXbqAnJzl9w3hD9LA9WWmRcCjz0vhlzGNKqZRYE1EGb 4m2m1sogZxlNWS8WWwcMoWrw3eujw+s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726248108; x=1757784108; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vdnM+CZTeCR9vtc54KCM3CD6QuawVpzxQ5fBCGrQFYI=; b=AHIukaGeYfxsI2fbqHsTCZWI3I8zu7bVbXP8pfmIH/YcP4Bk9GLWADkN XKmRppM4yHxAFLc1yhxcxWF3SWbxrWTYWF9+qy9aigmnc1x6ULDFQ0M/b RySYMZ+Xyn0CLMg1hJHkpo9CWJymX2SwuqXq4e3mWIMskHvLBLCDaAROm sgGQ2a1SSC21gZ5LtaGV4wrsP8HzbDJ7pwFNRgeCNZg7ucnIiqQtQlLt9 zf5CcjmVc5aAGkW43s/dreioCZJi7ykAKz3JvM0YRo31Ugq+tDm53jGUv jpv0vNOcsIR9LE+n2qGlJPV6DorqBxZlRJ9JVOqkrHzFTX1x8LUmK2LMl Q==; X-CSE-ConnectionGUID: g7sz9oCjTye60wUWYkKQdw== X-CSE-MsgGUID: +yGcenvFRF6NYIDyHHlAcQ== X-IronPort-AV: E=McAfee;i="6700,10204,11194"; a="13515753" X-IronPort-AV: E=Sophos;i="6.10,226,1719903600"; d="scan'208";a="13515753" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2024 10:21:46 -0700 X-CSE-ConnectionGUID: pZq42LnVSmarDZKTdgSiuA== X-CSE-MsgGUID: 8DBsX0MoQL+CuXku25so0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,226,1719903600"; d="scan'208";a="98978570" Received: from ccbilbre-mobl3.amr.corp.intel.com (HELO [10.124.220.219]) ([10.124.220.219]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2024 10:21:45 -0700 Message-ID: <8e8a94d4-39fe-4c34-9f5d-5b347ca8fe9a@intel.com> Date: Fri, 13 Sep 2024 10:21:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] x86/mm: Drop page table entry address output from pxd_ERROR() To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , Ryan Roberts , "Mike Rapoport (IBM)" , Arnd Bergmann , x86@kernel.org, linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20240913084433.1016256-1-anshuman.khandual@arm.com> <20240913084433.1016256-3-anshuman.khandual@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240913084433.1016256-3-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ut5gphntz8goigfe6grwj4qg5o9wdnsm X-Rspamd-Queue-Id: 3F4A61A000C X-Rspamd-Server: rspam11 X-HE-Tag: 1726248108-889723 X-HE-Meta: U2FsdGVkX19eusUXxxU8kHf3fkXA1ZfHnc6LQmozJA6NpklKpCDwG9ErNsVRTrf2yAHcm2k+7nVI8bk/mzGUUhs2Rpu3yZuR0xR8zJkw7c7tFo/J3M/cIV5EKS3p6EPkKZb3NCnuG6YhcW4XdoSQZDIhtspRhK1deeOE6C90vSzt+0YkervpHBPBqC+CQ43zK8eiRU2DdrYOZA5330bFMsdM+7F5qrRExXphN0D42b4Wa5ut5lnpw09fqTQ0AdVDo0tRxnFGKitSW69mgK6+NVBf2WIzb7EFJeaEGX3PpLNK0AKuX7O1Bkyc4SGbJtbsFVKFkvJ1VjsFcT1nlThmfwarKpBnuh375ajW9HrAxp5KDjA7IGrVM46C5NXA7GMQXLnHqb3+tUuhgTesXk5pafOz07JhLxTXGGFLnUNpqOMPMMkW1YaED6V94wiTqCmGdea0OkHBarY/Va7yMnshrmes+Q0VEyqw7GjBJAwR4se33wyErknV0uSN/NWoaxI2jeG66s6w3p0OaQXV0RGaemPYVrZexR6fm2/kORDtwYOK6yH/Dp+w3l6y+VKHtqkiolsGcwXgr6cwIcbG3+ohVTZycBPPJJTj6Vww6X583OCfya5d2KhOlxz5wbjb58h5u67hvstmk4W8xgE4Vor+qaEqq02mTOfQNtNJdSS1f3FwZLBxrqf30dCKiF9Pdb0CZfjgMVOj/8HOCq8hRCrKDyw6NhiMtvYUIOoADjjt9VBxn3mimgwESGsA0kZ8Nc8vCI5xKuu9ltUEU2SP4xJEGubn19XrVrW0HSjm4YkBQW6nymlc5RS9iaAJ148H6LQwXzvgi3rmJFfBBSR1ScX9bwmQAblxO+lLbhPzzBmWR8cHcI8c6BYJIaO7Aj00tx+qWKDmS/sWKbORg+gDeL7lg1M8+vvpx4DheGn0XQo7CficMtlwMOFEgzsLAyrwqxqmNHJDyLENxpT+YUYTWGR xoPcoogG AcXeggKNecS9TFA5tRDSNUnMljvdgzZ/vVOXqmcLKylcKQD1Iyw0LV4kzkFTBQ8/dIbC/V4QhXEGg6coBNNFLF/49AggXK7guUfurwCAEEWnpFujDsQWcuVDKAczq/EWCerX/60Zshmie52CFun1ulccCL2n/5dfBJ/bOeidVkyTFyU5zi6FoqdPBTpmEHvq6Rc9a6ajpCFNEfEzBkNawXibOxuMws8tSddVOdIhrhvhTabSyJ8h/BU0xWuScZlgeUxct X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/13/24 01:44, Anshuman Khandual wrote: > This drops page table entry address output from all pxd_ERROR() definitions > which now matches with other architectures. This also prevents build issues > while transitioning into pxdp_get() based page table entry accesses. Could you be a _little_ more specific than "build issues"? Is it that you want to do: void pmd_clear_bad(pmd_t *pmd) { - pmd_ERROR(*pmd); + pmd_ERROR(pmdp_get(pmd)); pmd_clear(pmd); } But the pmd_ERROR() macro would expand that to: &pmdp_get(pmd) which is nonsense? Having the PTEs' kernel addresses _is_ handy, but I guess they're scrambled on most end users' systems now and anybody that's actively debugging can just use a kprobe or something to dump the pmd_clear_bad() argument directly.