From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>
Cc: nyc@holomorphy.com, Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>
Subject: Re: mm: BUG in resv_map_release
Date: Tue, 28 Mar 2017 17:07:34 -0700 [thread overview]
Message-ID: <8e87e893-526b-7324-33fb-783a544bab11@oracle.com> (raw)
In-Reply-To: <20170328163823.3a0445a058670be9254e115c@linux-foundation.org>
On 03/28/2017 04:38 PM, Andrew Morton wrote:
> On Thu, 23 Mar 2017 11:19:38 +0100 Dmitry Vyukov <dvyukov@google.com> wrote:
>
>> Hello,
>>
>> I've got the following BUG while running syzkaller fuzzer.
>> Note the injected kmalloc failure, most likely it's the root cause.
>>
>
> Yes, probably the logic(?) in region_chg() leaked a
> resv->adds_in_progress++, although I'm not sure how. And afaict that
> code can leak the memory at *nrg if the `trg' allocation attempt failed
> on the second or later pass around the retry loop.
>
> Blah. Does someone want to take a look at it?
I sent out a patch to address this and Hillf Acked. Unfortunately,
there was a typo in your e-mail when I sent out the patch. So, you
may not have noticed.
[PATCH] mm/hugetlb: Don't call region_abort if region_chg fails
http://marc.info/?l=linux-mm&m=149033588500724&w=2
If you need/want me to send again, let me know.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-03-29 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 10:19 Dmitry Vyukov
2017-03-23 10:20 ` Dmitry Vyukov
2017-03-23 17:25 ` Mike Kravetz
2017-03-23 18:02 ` Mike Kravetz
2017-03-24 8:56 ` Dmitry Vyukov
2017-03-28 23:38 ` Andrew Morton
2017-03-29 0:07 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e87e893-526b-7324-33fb-783a544bab11@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox