From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921E5C83F03 for ; Thu, 3 Jul 2025 14:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EC44280001; Thu, 3 Jul 2025 10:50:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C46A940007; Thu, 3 Jul 2025 10:50:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DB34280001; Thu, 3 Jul 2025 10:50:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0AAB8940007 for ; Thu, 3 Jul 2025 10:50:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AAFD7140297 for ; Thu, 3 Jul 2025 14:50:33 +0000 (UTC) X-FDA: 83623239546.21.51021A6 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id 0FE644000D for ; Thu, 3 Jul 2025 14:50:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xb7GqeE0; spf=pass (imf11.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751554231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9YMey3siK0wqCW94xx52T29gHvYnSHgMxewAlTL36Sc=; b=xhQX6SzvlLV7BRkaFc5ACI/aTpgpSAn3f0fVV+kOr0H53kfaicdfRPEadhP8CAL9VwliqI 1tuQFbCH+nayrSK/C4ikEBf4NpjxqSnbpTvKKxmnNGePZVtq4l/3QooQbK8dCWWY0Uow0v QPfKar3qcIgHEZprC+Pw2uqSd8F5i/U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751554231; a=rsa-sha256; cv=none; b=PTJGuH4IJSV0Pip5uZ8Ln//mO409JgNaEr2XLIDmPb9doEw4Aglz+brGYaPBsG1b1n8/B6 W1ZCIO355pYR8D+CAAoekcy7Up7VrN9wB5arx0wx2gT6bT1QaWN3GPW9p6abhQKP2pnsye 5++MP5yTUAE/PbZVEWGzukfpWS7dX84= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xb7GqeE0; spf=pass (imf11.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5637tVk2024499; Thu, 3 Jul 2025 14:50:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=9YMey3 siK0wqCW94xx52T29gHvYnSHgMxewAlTL36Sc=; b=Xb7GqeE0Ka16QsK2x1h1/g kjn6/hLU2kGhaMO8qHz8vqnpzA05xGuJoFeohppV9BCfk6wmetUaUPLPNRZDXBwo sTI+bHEzHnI2tXdlpHnCXZQlhcdGnL574YN0e/mPJnj7De+LHG8ZEVPZaoZzIe6N It84Lnhn7sFQU5NhwA8Qu/c29J2D1oMIp8cSSMXkTWJ029am+UJN1fIiR5/CO3tS LEQDA8rd23vvX8fLe8h95REamA14wQygQNzzvu4C94Hb2gfH9Tsn3iNALrEx03xu euuHIzgF0mhMR+yqEgCj0SR7dk2ma2OkDycjY967FQ2aA9VRffg7kyRGoCTCdZWg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j8314fm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:50:25 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 563EmXvm009354; Thu, 3 Jul 2025 14:50:24 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47j8314fkx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:50:24 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 563EmbvK021385; Thu, 3 Jul 2025 14:50:23 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 47jwe3n49w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Jul 2025 14:50:23 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 563EoMZB25952806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Jul 2025 14:50:22 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7ADD258059; Thu, 3 Jul 2025 14:50:22 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C0FA58043; Thu, 3 Jul 2025 14:50:17 +0000 (GMT) Received: from [9.109.245.113] (unknown [9.109.245.113]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 3 Jul 2025 14:50:16 +0000 (GMT) Message-ID: <8e7dbebe-59c5-42cc-bc44-570842b8e82c@linux.ibm.com> Date: Thu, 3 Jul 2025 20:20:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] selftests/mm: Add support to test 4PB VA on PPC64 To: Zi Yan , Aboorva Devarajan Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, david@redhat.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-3-aboorvad@linux.ibm.com> <5FA05361-1FA8-4CAA-AF23-7BB0974DA78B@nvidia.com> Content-Language: en-US From: Donet Tom In-Reply-To: <5FA05361-1FA8-4CAA-AF23-7BB0974DA78B@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: TfIyuWwW6FDd5tr5QLsQNmpp_EvBf-eo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDEyNSBTYWx0ZWRfX7to6koSyXMzN J3j2/Lz/QeMgvqWVX5bwlcBr5cZzYCoJKFka6CrYoNdojMfbyrsThtsgfhiuFOnYVTUUS5ksOJ0 LkXGbEoNgSUFjjGX5/6Biqca8V8E6tW7YSN8+1HpgLbLoAT5iiYPAAQ/Ki0OazoPQBF5r/eq+pz bcX2VJiYxh1ioG4OW23S/Uyd11R4/UP6Kn+fSvh0zvf55dudBvGRA+gbW4Wcw6O7npjj3b48qjE JTj9rOv4Op/WFZcN6mOsJ3m9rh3Ca2l9+Zey/4AL/RfOZdOjq77x7GRvdcotA0tB+/jpu37FU98 ExeLt+HA0kNL00yX8BcF8h0njI/IR/ONMjFQMjK4eSW27AosBXZe8sI5+nThbdem2RyDaV0XnZR pcAYxlGyN6KnJK0CFZWSJlvtZ8U3z0b0WFIDbP2v+YNQ28Sh5mCngWduFqG+NkTgdFlxRq07 X-Authority-Analysis: v=2.4 cv=MOlgmNZl c=1 sm=1 tr=0 ts=686698b1 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=Ikd4Dj_1AAAA:8 a=R9CAwAD-EEtMngcwLj8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: lgvv0nC3QP17oZr9MFbZFZXwQiTKAVGo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_04,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030125 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0FE644000D X-Stat-Signature: o16uxc65ugob5tcecrbb47mn3h8n6yq5 X-Rspam-User: X-HE-Tag: 1751554230-413113 X-HE-Meta: U2FsdGVkX18zdJjFG3MU4amGnACcAbdgcDxVKTr/o8sbLJ7ki53r9OLT4V2X//XlTuwW+YxTol1bheonyRzWRCaEnUi3yAA6exrg1n8g3t1kzzJfqemXi71JEV6MREVY/j+KYsDsUKyVFOAMduuLje+IrYsPMO5qTJm0ubbiovivQDxJkfK9ilKXWcZ9mrQacLSMcJ9GstIroEGjLzI7Ya1ZohJxrGbzYeYI0RrR/SiBMpXj7yJa21zTTAGLr6ZrErGKtrhqZen+y0Cr3wYcpfBX5zvAB9QyTFDHrnF8VNQd2iUuoI5tY1DQE6Jra4EU0d+9Jf0nk/RELX1lAi46mbt39SU3ZzYdWAeHHloSLezE8/Jqj0PRvdaUEzDMyt0Ah1lO9dkdg/pX0ejbU0FH4nirgy3tLxBSz0SjM/O0IUuZas21IfV5unXuQY6uMTjdeXWy62FyXtWEA4RaW2xtlMobPMn+SMkMS9cY4um8ExCWLTWKOKf8LeFbGRg8KmD9fkn8MQkyRoIlT/OmtlfeaM/MDAphf0/5yoevD7fLuFY7gWreoLBD/H3Mx5XAsUlUVaACTY1XDApGg3u+Em1iaSWBhr99YV1SC4kkjGCqL+VpBn9FgApWscHXgxNY8CvSUmAeZpn1O4IjKrCNuAIzWBnFjY8XAPWDJHhq7CQz3BKSbvcnYN2wAO2owhiDcePg2WeoQCVA7TzMIB77gjOYCAZQsXpC2Dk/dFOIb3F5KI84brkg6BJlW+ZYphZ3WCi9S2IKQWCYfiv7EEb8Bhw5syXMM1E60Qzx8hUbgr32vBDgRfHmgAU8b3J8Oh85sb9dym+Da/WJB/wAqbcDLmXBORW8fgD2ZB5snlibxK0HsUOravrTLxHG//pD1Ott/cC6aeEQ3YK5SVVu8gs2fM21rCRYSddAOWktsNfaZOx8dJZT/k8CPhTwAe0y+0Phjg9D2x3n9rLTizqOQ+ZgzX8 /YopYQs+ IVQgjNw01kBiMg7A61NhyHB7lWRenxCui8L8JWPFTNUEW4KPBoay5WeWCVrfmMT+KZKTHdcoUVAJ5iucbnd3gTuAJyXTXo5YZ0u8g8He3pL32NcrLb4bern2dyvzDTo0O34yqOvMeOYIP3Kdm+dK/v86JbHtpwMkzsYx8dJOW501dJTAAIhBMv3ATwMiOLKlMsI4tVPPzQEol3MyhqRT+IYNGxHQeVemJYj3V9ywMqCMrgo1N7/cJv83BIfZrR3aiQd5OamXwJCCje2hzE15+CLdYFWufkzCxEaVEsvmyj/GoFN5doA6qbBc8G7vSF7YWKEZhnZrFe0LP1OsI7Mh8COn0zcR+ZK+HIiPyr8eWGoErdpmlGyjWOFMrImZ+V34bmF/+xDgxqrgdtoCIuBwQ04FUUfepqxTNDXmAn0y/HXKtXKRjOEIVj0QnHi56VsElSsXm4yqx7iF5C+HcFXeWiV+Rvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/3/25 8:11 PM, Zi Yan wrote: > On 3 Jul 2025, at 2:06, Aboorva Devarajan wrote: > >> From: Donet Tom >> >> PowerPC64 supports a 4PB virtual address space, but this test was >> previously limited to 512TB. This patch extends the coverage up to >> the full 4PB VA range on PowerPC64. >> >> Memory from 0 to 128TB is allocated without an address hint, while >> allocations from 128TB to 4PB use a hint address. >> >> Signed-off-by: Donet Tom >> Signed-off-by: Aboorva Devarajan >> --- >> tools/testing/selftests/mm/virtual_address_range.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c >> index e24c36a39f22..619acf0b9239 100644 >> --- a/tools/testing/selftests/mm/virtual_address_range.c >> +++ b/tools/testing/selftests/mm/virtual_address_range.c >> @@ -50,6 +50,7 @@ >> #define NR_CHUNKS_256TB (NR_CHUNKS_128TB * 2UL) >> #define NR_CHUNKS_384TB (NR_CHUNKS_128TB * 3UL) >> #define NR_CHUNKS_3840TB (NR_CHUNKS_128TB * 30UL) >> +#define NR_CHUNKS_3968TB (NR_CHUNKS_128TB * 31UL) >> >> #define ADDR_MARK_128TB (1UL << 47) /* First address beyond 128TB */ >> #define ADDR_MARK_256TB (1UL << 48) /* First address beyond 256TB */ >> @@ -59,6 +60,11 @@ >> #define HIGH_ADDR_SHIFT 49 >> #define NR_CHUNKS_LOW NR_CHUNKS_256TB >> #define NR_CHUNKS_HIGH NR_CHUNKS_3840TB >> +#elif defined(__PPC64__) >> +#define HIGH_ADDR_MARK ADDR_MARK_128TB >> +#define HIGH_ADDR_SHIFT 48 >> +#define NR_CHUNKS_LOW NR_CHUNKS_128TB >> +#define NR_CHUNKS_HIGH NR_CHUNKS_3968TB >> #else >> #define HIGH_ADDR_MARK ADDR_MARK_128TB >> #define HIGH_ADDR_SHIFT 48 > Could you also update the comment above this code to say PowerPC64 also > supports 4PB virtual address space? Sure. I will add > > From the comment, arm64 supports 4PB but its NR_CHUNKS_HIGH is only 3840TB, > whereas PowerPC64 here can get to 3968TB. I do not know why arm64’s > 4PB is smaller. ;) > > Otherwise, the patch looks good to me. > > Reviewed-by: Zi Yan > > Best Regards, > Yan, Zi