From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFC9E77188 for ; Fri, 10 Jan 2025 18:04:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D8556B00C0; Fri, 10 Jan 2025 13:04:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 786F06B00C1; Fri, 10 Jan 2025 13:04:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6025D6B00C2; Fri, 10 Jan 2025 13:04:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 448936B00C0 for ; Fri, 10 Jan 2025 13:04:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B0E161C7CF7 for ; Fri, 10 Jan 2025 18:04:53 +0000 (UTC) X-FDA: 82992318066.14.F90B7DB Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11020140.outbound.protection.outlook.com [52.101.46.140]) by imf14.hostedemail.com (Postfix) with ESMTP id 67C0A10000C for ; Fri, 10 Jan 2025 18:04:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=T4TIPQ0b; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of yang@os.amperecomputing.com designates 52.101.46.140 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com; dmarc=pass (policy=quarantine) header.from=amperecomputing.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736532290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RZlodS/+YjaPswdujYZe8+RcDNwdbiaeFltqKioq2R0=; b=6Q9Nu8Z1wT1YeBKHLP8zLYlThPjtk+XFnsI+tMoo7Jy7C1ECPhDa+6f0EA3ayFFiLCK0gb b0qn7BUDa00EHreESoQVV/NpDcNMx9liEbhovp4/QyFb+peW9IZO8wPjJdZir6Aitfk4oE Y9CNR/Ma/z6h9Pto/3HoTHJyUh6R9gs= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736532290; a=rsa-sha256; cv=pass; b=kN3R3Sxw/38B1N44MYI1k87Yja0/hrlZ4VhRODAVhWHFZhH1gQq9fTYxNmkp1sH/T2rQ4w ynf2OTPL0JnpA/X3L6ce7jFy92QRaRZp8rjLqf+/OYrfIVTVjSEk2AZzo4AnBiINhYU103 Ji3PIDh2t/J7Y+/DvXP53OzF9Wjv5JI= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=T4TIPQ0b; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of yang@os.amperecomputing.com designates 52.101.46.140 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com; dmarc=pass (policy=quarantine) header.from=amperecomputing.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WOJjaIL42n8YAP/wC+pkx0VUGQbwMgVAuoAitJDqwk2nFbyFu523yK0jHdQMMXvN3DhAn5SjrRF2QdZnnStcrpni3Mmn+ZDGdIBkz7OXs1pxcO8LfsT1abDosx617JHr3iyqp+Emi9mfIogjwlCnEJLTi0Lv3389Sx9uv2vRbchKbQZkb7FdwPnrP1a1/PH0L1oW6QdCe1QNRGHxuNaFU0PwpOteGGNLOwqfo1r21m7hizSgSPcogxJB25TFAz0gNkx58PsgDZFi8aqkNEOa6OHjznhwDpcsCajRycpQ3wUCWWYhsfkXE+9hRC3ADdAw90wvZMjg0828+4kczS0OWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZlodS/+YjaPswdujYZe8+RcDNwdbiaeFltqKioq2R0=; b=MiZvl9Q4fhTcnVUBv3AoDfL1WFu5/PNDACorO5UAjyGLAhpFtY8hD/MjbDamzFArxsFZiugs9BdafDMbXGxVwFIkZB4U24nOWV3/9HAGwPoeM52QL33HmVJgW/9Xe6WSWHKh3jXp/eFyW0DSBBiWoaxcmSPSXZU9RTNAs7G3I49kuX/XfJG3CfR5hbQ7xahOeBBIe4jPFFJncYT4IGQ54aUJDsr94yj/tdDFJ+CuHOIpw4sg7bh7lCgLkxvIjCWup3e7hjZQsUta6KihkY9yjMwDGnWVeCBSYXTZHe6jPepBDsy2bszNnPCyBklBOZjIY32xbi7i6TdjgyVYGQGijA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZlodS/+YjaPswdujYZe8+RcDNwdbiaeFltqKioq2R0=; b=T4TIPQ0bMWuu34atP7uzUNNBzDXtKaZGu6rqckespgwk9e6F4ywrvDvuWE6DJiYSY7qaaC23Is5EvJBwb0S7rf5607ekDWwOnl6D/ZH1qDtKfOpNGJbc+zxQu4jWFoM+V472Y1yd/JuxqOgSFOtICnw2r42inWq2MrwMwDd+cDw= Received: from CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) by BL1PR01MB7796.prod.exchangelabs.com (2603:10b6:208:39b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.10; Fri, 10 Jan 2025 18:04:46 +0000 Received: from CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460]) by CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460%6]) with mapi id 15.20.8335.010; Fri, 10 Jan 2025 18:04:45 +0000 Message-ID: <8e773a7c-e1dd-4e0e-8349-8aa52f39d85a@os.amperecomputing.com> Date: Fri, 10 Jan 2025 10:04:42 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: khugepaged: fix call hpage_collapse_scan_file() for anonymous vma To: Matthew Wilcox Cc: Liu Shixin , Andrew Morton , Chengming Zhou , Kefeng Wang , Nanyong Sun , Muchun Song , Qi Zheng , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250109070059.369257-1-liushixin2@huawei.com> <037d4442-4d2d-4aeb-8091-5efffc374d36@os.amperecomputing.com> Content-Language: en-US From: Yang Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH5P221CA0016.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::12) To CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR01MB6873:EE_|BL1PR01MB7796:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d81ce7e-e7fe-49d7-8f0a-08dd31a143d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cHpyQzZlTnRZZjJTcG9SSGVUNU44OUVNa3d1TVV1Qm9FMWxXclBLd1YzNERS?= =?utf-8?B?MzY3YnpBM0tDd1NNWG8zSk1aZ2g2cEJmTjdNdk1GdTUraDJEY2NWc0tDS0wz?= =?utf-8?B?eGhlSEF5WENHRGlLN3NHR0tCUFVBTmJ5eVcyaTdWcmNRd2ZDd0dYWWFzTVFM?= =?utf-8?B?dmNLWFlqWlVCTjVub0RLblZzRWdWek9zSlRaVTFjK29TUmZXUzYyTnpKbnVo?= =?utf-8?B?SWFtREpZcEVFRjBIZkRNejR1aVdxVUVHSUswTUc0Vlg1VTNZM000bXJ6UXk0?= =?utf-8?B?UkswL0JHZjJIMUJCRlRlTGlBeVFUY3BZbk95a0p6UzV5SENmSGF2aGNybUNK?= =?utf-8?B?Vm1sWkNUNm1sTWVFUzRUdHlHdDZldzFkTG1GMUtXV0dvMGM3UTYvNVE2aUlF?= =?utf-8?B?T2E5Zm10NXBRbzdrY2hnU2o2R3J0VGZPL3haODdIUGEvcFV6VmYvUnlwWXI2?= =?utf-8?B?TXJXc0VPaXNpTGJHVUtaUFNPQVlYeERKdzYrU3pyY0h6WHQ2MDR6dno0U3dL?= =?utf-8?B?ZC9wSnYvbUtJRjJhY2xDcnBxVXhNVTdSNTFtSkt0TSswbU5FS0JiUUtXZ1Fj?= =?utf-8?B?dXRTZEJkWGtYcGFLdVRiZEJGajU3RStiQUN2clA2MlBWaVB2VEVVQ3NBNVRY?= =?utf-8?B?NTl6UDR3TXhaZ3NmU25jVUY2NStlZjVXUkJGZmJKRVRlb01HVmVCU3hQdGJp?= =?utf-8?B?K2Z5Rzk1ZVZFRzJoU2FnaURVbm11QUlhand1bzN2QjJ2TEFnL00vN2tEbEJ5?= =?utf-8?B?aVRHcHRhOVUxeWVsenFjcy9Edm5ZNXhDeFdVajVKQm5kUXVrTGpqamJna1c2?= =?utf-8?B?dS9kZkVabldaWXFWdlo3NkdoV2lKS2wzRGMydG9oSjVzY2lhaXkzc3pSRXBk?= =?utf-8?B?SXpqdmZvUHdtWkZwR21XUlNsVkpnOXhIek9HMmE5NExwNDhRNFJncDBHT3FM?= =?utf-8?B?WnczdFVmMVIrZTdPV3ZibkVaS1dBdy9sbUtodnhzdGhKNlc4WVdhUW1sbml2?= =?utf-8?B?NHRkbTFUY05sWXJTLzNaTWNRRkI3R3pWYWdiOEgwM2N4TTJLU2dFODlFcHlU?= =?utf-8?B?Wnk1TVFaTmdsbEludDJ3ZjlRWmRqa3JpdzEwRU1CT3Y2WW96TEs0OFRMc3FN?= =?utf-8?B?V1g4T0Fic29HK0hScG00VDBYMUl6cWFadmFsZXpBMzIzTXdXTEdNNUFTUUd0?= =?utf-8?B?T0l4WkZaeFhBNDRmMWdzQzJYVHRnTEQ3djJPUGZqRW5WbFpYWVBnVlpybThF?= =?utf-8?B?ckpiTUVHUFh4ME5ET3ROQzExbkZXRWtyVjlMMjZlTjFxWW0xVk1CQ3d1aVl0?= =?utf-8?B?emdPYWZQREJmMjRYUE8zM0dZaUt4c3I0S3JoemRGTXNYS2dyNWg3djNhZTJO?= =?utf-8?B?amxJSUJPN1RXZTczS0xtQW54aEdMOE5VVmR5QllsZWZKYlhsRTBPZXRqeHlZ?= =?utf-8?B?TTlaaEM3SlVTSG5BQ0tweHltSTJwWGx6T1M2c2l4TUVXYVN2dWEvWFQ3TFVr?= =?utf-8?B?cDlhMHBhdkM3cU1YUFFoSk1EeVkwTXVOcFNzTFZFay9nTStabWZ5YmZqL2VQ?= =?utf-8?B?NHVNN2dJenNwUU5CWGpnNG9uSy9hMHhCRUhVWmFsUUxvTS9wMGFFQWZlL1JG?= =?utf-8?B?Nkc1dGJPd0RTV2tRelFqRVFFZHBML0l3YlNLQlpRanVDTTU0aG5SZWY5UmZr?= =?utf-8?B?UGFqK0l6M0tKbkFBSVQxSjdsMWpENVJIaHFWckYxR0NIbnlMWXpTdFNoV0tJ?= =?utf-8?B?d3h5SEx6ZEsyZTVMYXhra1BWbmYrRTRZU1lqSEtLM01MRHpraFQzenFQVDRG?= =?utf-8?B?VmxzcHpsWGIyeThnRHlpcjVGY1pSa1NsWTF3ejl0V3pKRWdBYnMzTi8vVTFz?= =?utf-8?Q?7W8BofRoaKKGY?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR01MB6873.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnVPc01US3Z2MURydFYvc1RBYUNjVEFjb3J2VkdDY1hsTmw5ZDlBUFhDMnBh?= =?utf-8?B?Vkdab21wSjJXZTcxVjE4a05wYUhQNjhxaTBvellzZUJrWDBwTXdkRkNRbzdP?= =?utf-8?B?VVUxU0hTZFBIRGhRK0VJbnFXZzJYUjM5anZNREx6ZHV2STdaRkRRZ1pSMGRR?= =?utf-8?B?OVlua0ZPT1RPTjZ2YlN1alRlMUtvbFdpb3lnRjFOZ1N3U1RUUHhzSXI5UFVv?= =?utf-8?B?ZzdLZzdrMXdXZkJRY2JETXZSaEdodk8vbFhXSGlZMDhxRENUY21HZUtpY0Nj?= =?utf-8?B?SHFPZituYlYvc1F5NlZMUUJKbnNKNGxvdUpDc0lnOHNXYW5zeDhWdFAxWm9S?= =?utf-8?B?YlpnK3l0Y3BOcUJIUmZNa281TzlkTG5JMktPZ3ByK0o0eXVQQzFZeDAwWnhB?= =?utf-8?B?UnJabWRZVzBtenVudUsxQTR4VE5xVmlVMGhEYU9kSDhFSlF1V2dtakxQa1Zh?= =?utf-8?B?VFJYYmo0U3Y5ZkRjUCsrSllQa3dvVGw0KzZhaXdRY3hRNzRCVzVDNTc3YWRU?= =?utf-8?B?TE9QakFXUDhrRkFBOTdyd0FrcmlZQmIzRW9TZzYwOEY4bllhdC9DNVV6OUxl?= =?utf-8?B?anpoUGMzMjlkdytwY1A2UXI0dzRRTVF6RFViQjUrUGNBS1BsU2J6eTdDR3pv?= =?utf-8?B?dTN2N3FUZkVTbDg2UjZuc1F0cTRYTVNwOTJFam1qbVZCU1lDcHhxbzUzeWZJ?= =?utf-8?B?T2U3V2w0ZVlCN2ZpeDJidE1TZG1VZlQ2RTFVa0Q2YkpadWlkUDZHcUd1QlEz?= =?utf-8?B?WnZBanQwQndrdEdvR2FoMjlkazFFYVZ2MXFRUDlsOXR6R2RiWFFBazV1YXlM?= =?utf-8?B?K1FneG53VnlPOFp1NTlSbG55a3I5dERjVXJtcmsydVlUY0Z4aVdZMmJpRGxo?= =?utf-8?B?dDdJVU1yVFpmVW5rUmNpRVpKOUJreTJoUk1IR0RxNGxMc0x1YTAxODZldUJr?= =?utf-8?B?RURENE5GSGVDcmJsRFFDdWNOQ21yL2dJZzJEM2pGQlhoTmJSVVA0emE0ZTYz?= =?utf-8?B?MktlZ1oyMjR6VWcxRzRmVndkZFRSM3VPa1l2RjdBS1l3REJvUTBYd0JqeWdI?= =?utf-8?B?OUY5WmNMRDUxaTgwS3NERUF1US82ZWYreFlhL0N1R1pjUERQcU5GZmp1eUNa?= =?utf-8?B?TlVlRmQwSmJkMDRMcVYxaHgvdkxXWlVVZ0NHLzBxUHdHMm00anNEMDJmOUNG?= =?utf-8?B?d0ZMRHdabUYyWG5GRk9DWloybjVsaWQ3RXhmR1NnSS9GbCtpbnh1UXhET3cv?= =?utf-8?B?RmhQZjdDbWl5V0p2TUdQaTFJUE42ZlVFRVBMK1pIVEV0YXNYQWdnOVNtY2dT?= =?utf-8?B?c291d2ZMVDdpcWRIQldWZFpRalBtcHRocFFwWm5meDVzSnNVLy9tSXJBS3Y2?= =?utf-8?B?UDduRm1idHdkMnBDSUlPdlhtVFlIcG9wU3hUdEVtMVVXam8va2toRit5SWJp?= =?utf-8?B?dlMybEk4QU9HeWxrTitoV1lRZXMrSHZLeHRyQ1RkeGhpcEYyNlg4TWtGOTZK?= =?utf-8?B?NE1ibkhjRUszd1ErUEtDbGdoZVJoNDZmVUxuSlRHNEJXV1R1eWNhTzhjaHFG?= =?utf-8?B?TWxPMWdYci8rdlRZNXUyT2xWcTM3S0xOV0dsQ2Nacnd6TXF6eGdieXF3cWtl?= =?utf-8?B?VnZEb0ZNYlB4czVZRDkydUVEVlM3SmhlNmJmY1VkMk5NVWdsWGpxdU5LT0kw?= =?utf-8?B?NG12TDZGL0p0V3ZMbFlkdnJ4YmFLZ3hxU2V0V2dVeW5FbWlMaEo5K2F6c20z?= =?utf-8?B?ZVlqNFhpMlA2MEZDT3BNaXgvN1dMT1Y5V0Z1U1BuSG91eXFEWmJMQzhpRW5F?= =?utf-8?B?eXYrSGc2TnFtRTQ4eEhxSmFNaGRSd1VjTkhPNlNjN2JhZjdZdzZHTXJvcG1G?= =?utf-8?B?czFrQm9URENxdmRXelJIV2F3RFRUek5INjhadEVrNUUzMFRsdm1FY3JWcTNT?= =?utf-8?B?eCswbHZaRVgzMGR5eWYyYVBmaVl5d3loMlBheVhTQUovS0paQTZHenY0a2Zp?= =?utf-8?B?aUxWajhFZTFQQ0NObHlRYndabmwyWk9LK0dJQ1FTTDVhS3RsWkRsYmdqbVg3?= =?utf-8?B?TzZDQ3JJMFdmUzBGbTdNT0xLOWQySkM5cTR4TzF5Q0E4T2s4ekRPTEJvYkow?= =?utf-8?B?ZlhyYkpmdEtqeWJvZ3N3NitQcFR2YzBDQkltcWpiK2RBSWVMN1dabXFyQWQv?= =?utf-8?Q?rC+WzZ0GbygMLbYycFLkYJk=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d81ce7e-e7fe-49d7-8f0a-08dd31a143d4 X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB6873.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2025 18:04:45.5558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AlmVdYUDiRtgBMajeANvKt5+e+UlveIa973+x6DDcR1Qxz1ukt4T8NfKbM+Nf3GIOqd4CbSfDIxuC5LfWiNo6ZbFP0YnH37BK2HrjJf8RKY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7796 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 67C0A10000C X-Stat-Signature: yh18ctmgfcp158k6r1e7kfuf4xqjm44k X-Rspam-User: X-HE-Tag: 1736532290-482489 X-HE-Meta: U2FsdGVkX180/N8vt9bMjKNXhsGOmqUHltOw4Ds0AD/n7siADO/7S8iSWjElUXrVzE2npVQbfPoBCwnoygQoBqWNuPr2dqTf7KO0q2qqjfBzykrbjRb3xRTcKADBzQXPZTWQC7ZuvPDcAvGwOLIIvaHlG1q3NsFz8EGsSOQyAk4jlrImCuySwhHGCvewi/p6kWCaHlOryeemUaWPr6VMYNXsRdxtYxBdy7uG/Eo2GKIXHdTIbT2bQuTeCBahlAsA8YLX7NK1Zyg+m85av2J4yQbwl5v4cMUM8RxKhCYFQ+Uyckqsi9jWnvKuN2OSbdlcsMmfqjiw1573wNf4NwUKERyYn8aSqtVAhglxTQ6YpzdpV1uol1Z0/7WbxvtDqBkfDlgSpryY3eowFl0osBXqKTWoRcCtmg5boC1l20GDILKIgAeScrDgsm/tP8+Q4yhBkb67/MaQth1BvvvqGhdRSAUcBjrXTvQhf54ZTbnKnIFc1cKLTnpGqVZUuVFGD50qrm1fQR4JcygII9UZe94DlmK3MsrnZIWW62xU8Zd2aehHpuAM1kigdQbjBjSNNZFzI9mvKBCif69wqJ8WeUfHDc0HLXs2fpNRK0Tor7RU6Jh/McKNhD+m2e3ySKh3rhKAWM1ePY9sUp0dHDJRL9GoBhWIZIOblBL4KWsUBzZP04vAVcmWkijoCzBMZDQtLvNbVUUVbP8IAbXCFeuPKm1nQoj731ZOpP7tQvfselD9NGL8Tndh/I1Rkjqat451lSsyHkS3fiB6HcG7Ye34DYn1H9LmJcVZVbqo0Ab7LWC34spbvO5hFNVwusqiczfnHjq4Zh7efoa8vBF6QnLupY//0A4o1Rz6X9oNxg9oRva12PBB5TwkVqIrPdbcJcHgoi7qYSqxUTGaXX/gYp7aOryZ5PThYzMJV8cI8vOCEaqGoPjDKsBAYoF70avwpNwpJGlk5jHHr5X+h3ustCUc6NK 26+VPK1v WIP8FVE1ClLCZQ1B5deD4ycP/lRsG9zIwYfalHTRa/Zh/pzx5/lF5Glb4uwxpiXNcRUKAadInxLoKzNrVj8tLU1uHx8Igr8K5tCIb2WmeqBV6okw2zWqXYDAuIFTt36euzpkM4uYN/3wvDQUrhb1eDEuSpSMG2ndGprTXr+NidE1gXiH5qkNOFNtg6PlMKPMdnZJ836wYM9XwS3kSLTDOTY0Oj26+5Uyscuc57zK4Pks7dw+aY3tGfoJDTM67qYBP772Bc+2yCNQD838K4Bq/XTP5MKyZ1volB1PVm8o4d49OBKD3bY+QVyuxlVet3LaI5+1i68e2X/HpB21HRAYIL4M2BU7+hHbk13/VvvCLao+xECZb0JVQV9M3cV3OLNTKf17OioxQ2tsKmgKwlcvf+TApLimdEq4qQHvu3OsGVAVxDoxQNc3vDZwrA1QpfEw3ogUuW/39HWFe62Kc/fuof+oYaUSbXTI1G/i52BrtUM53IfVwFGFJZbp130Rky2H6T9v3x/xUgQQ6l06Za8Ru3ilstw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/9/25 8:31 PM, Matthew Wilcox wrote: > On Thu, Jan 09, 2025 at 09:00:24AM -0800, Yang Shi wrote: >> Thanks for catching this. It sounds a little bit weird to have vm_file for >> an anonymous VMA. I'm not sure why we should keep such special case. It >> seems shared mapping is treated as shmem file mapping. So can we set vm_file >> to NULL when mmap'ing /dev/zero for private mapping? Something like: >> >> diff --git a/drivers/char/mem.c b/drivers/char/mem.c >> index 169eed162a7f..fc332efc5c11 100644 >> --- a/drivers/char/mem.c >> +++ b/drivers/char/mem.c >> @@ -527,6 +527,7 @@ static int mmap_zero(struct file *file, struct >> vm_area_struct *vma) >>         if (vma->vm_flags & VM_SHARED) >>                 return shmem_zero_setup(vma); >>         vma_set_anonymous(vma); >> +       vma->vm_file = NULL; >>         return 0; >>  } > I'm wary this might cause other bugs somewhere. rc6 is a bit late to be > introducing such a subtle change. Thanks for the extra caution. Applying the proposed fix in khugepaged code is fine to me either. We can try to kill the special case later. Looking at the code further, I think we should do more to make private /dev/zero mapping an anonymous mapping: diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 169eed162a7f..98cfac2bb01f 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -527,6 +527,10 @@ static int mmap_zero(struct file *file, struct vm_area_struct *vma)         if (vma->vm_flags & VM_SHARED)                 return shmem_zero_setup(vma);         vma_set_anonymous(vma); +       fput(vma->vm_file); +       vma->vm_file = NULL; +       vma->vm_pgoff = vma->vm_start >> PAGE_SHIFT; +         return 0;  } AFAICT, the user visible effect is we will have different entry in smaps/maps. Before the change: ffffb7190000-ffffb7590000 rw-p 00001000 00:06 8                          /dev/zero Size:               4096 kB KernelPageSize:        4 kB MMUPageSize:           4 kB Rss:                   4 kB Pss:                   4 kB Pss_Dirty:             4 kB Shared_Clean:          0 kB Shared_Dirty:          0 kB Private_Clean:         0 kB Private_Dirty:         4 kB Referenced:            4 kB Anonymous:             4 kB KSM:                   0 kB LazyFree:              0 kB AnonHugePages:         0 kB ShmemPmdMapped:        0 kB FilePmdMapped:         0 kB Shared_Hugetlb:        0 kB Private_Hugetlb:       0 kB Swap:                  0 kB SwapPss:               0 kB Locked:                0 kB THPeligible:           0 VmFlags: rd wr mr mw me ac After the change: ffffb6130000-ffffb6530000 rw-p 00000000 00:00 0 Size:               4096 kB KernelPageSize:        4 kB MMUPageSize:           4 kB Rss:                   4 kB Pss:                   4 kB Pss_Dirty:             4 kB Shared_Clean:          0 kB Shared_Dirty:          0 kB Private_Clean:         0 kB Private_Dirty:         4 kB Referenced:            4 kB Anonymous:             4 kB KSM:                   0 kB LazyFree:              0 kB AnonHugePages:         0 kB ShmemPmdMapped:        0 kB FilePmdMapped:         0 kB Shared_Hugetlb:        0 kB Private_Hugetlb:       0 kB Swap:                  0 kB SwapPss:               0 kB Locked:                0 kB THPeligible:           0 VmFlags: rd wr mr mw me ac I'm not sure who really cares about the difference.