From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74733C0219D for ; Thu, 13 Feb 2025 11:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090456B0088; Thu, 13 Feb 2025 06:23:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0181F6B0089; Thu, 13 Feb 2025 06:23:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB5D6B008A; Thu, 13 Feb 2025 06:23:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE1D96B0088 for ; Thu, 13 Feb 2025 06:23:22 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7EF851A0C0F for ; Thu, 13 Feb 2025 11:23:22 +0000 (UTC) X-FDA: 83114685444.20.281B915 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id B7FA8180003 for ; Thu, 13 Feb 2025 11:23:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739445800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JeLebbqDX0WJfyw1CE6wJZuiafL/LoNX99Os8d87jXY=; b=mEpp0PowVtWTnrLEI1v9SMUpH7QoigUg7il3l/uvedtubK07aoqY//bE3uOK/vrixXR5jI f7TZ4CMbkTK/sE42Ul6Nxiv9BgctMrY8EdqrsVFEEb2KhgIR+b3ahE2j2tMG3UzN5gte3t nsK4XkVVkQLzCl/mOgIaQNEg2lja4K0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739445800; a=rsa-sha256; cv=none; b=Gb4OjkLfz5vOceVsGnZbKxIF+QR/k0wl77dv78jLdta4Y07nykjqSSDfFBQzAzfxKcOFDV YRX5ptaTb6ZZ6z+EqEvafeFI+tlXMGRPoX7Vq0e68E391eEa0NUycZn9XcUjsA/PDI+o+D VZ0K8IPCCC4EcVcej4vOCwsXAike8hk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 84F7226A4; Thu, 13 Feb 2025 03:23:40 -0800 (PST) Received: from [10.1.32.44] (e122027.cambridge.arm.com [10.1.32.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CE743F6A8; Thu, 13 Feb 2025 03:23:14 -0800 (PST) Message-ID: <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> Date: Thu, 13 Feb 2025 11:23:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@csgroup.eu, Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250213040934.3245750-5-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B7FA8180003 X-Stat-Signature: hb1e7t3ez549snr7aw9p14yf4oyckbnz X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739445800-885897 X-HE-Meta: U2FsdGVkX1+/TYjIKZ4KwqgkZpCT92AhdsyvPrnmlUs9ikawXLP+jquum/ZUb2ZUZPKWLop96qnc6vtfwfPIiwAGkv70fLMVodBdz2JIr39BAAKHLdoNtZAnAWsmC5XFxpEtBOBIS15adllbU/Pc/Tyv61ZPqYdYsyXPks0oNF8snlTEBl74c62RvMGu+06N6CPN4ntJp7htsoubjpy81nkSDQe1hZXNKWwjs/0wcs6CN9HlFF4Qkd8Uyczj+n8H56h7O7+Bnn61P4IgoJFsyXMr0B12JQdYdzDSLwKYaNHJB3Q9eEG67WSeH/fS+QLuux+GlhkNBGATo63zhaWty70Qq5Qd9J8YHLHbVq9hzLVd7ZiFJQYt1k1/xFs1Q2V88inJJ8wj6B/009/q13Vr8LTthSuXh4XX2IgYso5Ek+OKCahNBhddvDbtJ4V85TsJAPRBo/onw2fJad3/JhIT6HfOM+zlGj4kEkPjkcMLKbMr414H3BmQsV1kPelgMJBMy6ci2LeV8K4NkMoQu7narFAVjZF79AmFL8mKiC7PKMmgR5AgURiXHdZtfv/jnseoZJiySHX4DDvcySVhtfCKOvnKUh9XfG0eNl8fz3OLSxk9Sf6VGkelRV6uyXf3KXu4dVzm9ivJlGe/sFSGkFNbIDrjQeTGQYr9xuEt9CRI6NVdB1ZaqUsAbkFdcxvCapLWKnIQn2Yd6FXtCwp2qgN9A4axI25ulePA85B62b0F8bDmCh9oed2ZK8wY8Nt6OJ9jzf4P+I7KJEBkFGRgk6LfjL0sIYH2/MT3ROVYJ0NqrU6HMAkfGIlGzq8cdO73wyrKZTjonL+gaFWhFCRlgI859KjqxcxLj2PCa0rZKzKrTRCfMe/RgNTKVoyFNKRIas6lASWBaQbqsoeUg8fQZGTib1pMLZTdh79mN99MhRCjaJHO8PoqpyF8HYYGdRtSc89rUxmGDlKnz59aNH2moqf dUoOxvaQ ite9y5NCESuTI+2kfcZVCJgAI0QV6Dvhii3cWZBEe48y4DIXuTnQQKtfM4atEfg3bgsJ8r9r65/V/NIH7rJjqthnY+9RQnKp0fRzHe2YqjbVnCc/LxltDAuKXblnifJavupjU4XeHAMYeQHz2dyUqxheo6GK+v7g/jPyRtz82tGExZZ/gCng3ofszLBet7N9hXVbHdlosRsMHMWKpYHK5kFEhkfELBhCx4eMcjsQu/mtTd1N/5AkJjdn7zaNJe7i5LGuvbhwlmJEUqfwgrFppDxN1OI2Qp+QQQwIxQmaCgB/r6fAXKtNAK+CPb5Sx4xnQKHrRVAFhsqPNqpJwlI/ts/guV1+/qX4ddkjYrsY+7coIjgZh1rmTMde9zHqRsM0M/p57owEF9XYqjfleD4THG0CfIWOZqq7HwmL+zbFZKVVeSsg/EnlcDSRvB9EsC+qeyLw05NTPLfEC5Xz2segy7AnLd2UpXktuiZvhPZqDxZEjHO78sww/GLQ/D8EovRFdssJ8pB33VpqNfnWVPpru27sjOwuCIH6UqhF0K8i64eiP7XmYvuTW9RYKgN6r4Ag4v2Y03viBsmq++j/Jy6faVl7AfubsD4vb7Wtcw/rVE9w69WLfVk5zw+t2nNfunoSy2dzqnaxktiptfG5qW4epunFqMDbNgnnOxi0+yhTYyjHyebEwhi8Ng8R7ok2lS3TZzLhrmZ7YjbkIV4ZmrPJdwQwXqxkfSihgae6CeoY3vrKO6gpnzO3R/mYQeiDQztUn6DAH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13/02/2025 04:09, Anshuman Khandual wrote: > Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. > But generic ptdump gets enabled via PTDUMP_CORE. These configs combination > is confusing as they sound very similar and does not differentiate between > platform's feature subscription and feature enablement for ptdump. Rename > the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve > readability. I'm not going to bikeshed over the naming, but a few points below. > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Jonathan Corbet > Cc: Marc Zyngier > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Andrew Morton > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kvmarm@lists.linux.dev > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: Anshuman Khandual > --- > Documentation/arch/arm64/ptdump.rst | 4 ++-- > arch/arm64/Kconfig | 2 +- > arch/arm64/include/asm/ptdump.h | 4 ++-- > arch/arm64/kvm/Kconfig | 4 ++-- > arch/arm64/mm/Makefile | 2 +- > arch/powerpc/Kconfig | 2 +- > arch/powerpc/configs/mpc885_ads_defconfig | 2 +- > arch/powerpc/mm/Makefile | 2 +- > arch/riscv/Kconfig | 2 +- > arch/riscv/mm/Makefile | 2 +- > arch/s390/Kconfig | 2 +- > arch/s390/mm/Makefile | 2 +- > arch/x86/Kconfig | 2 +- > arch/x86/Kconfig.debug | 2 +- > arch/x86/mm/Makefile | 2 +- > mm/Kconfig.debug | 12 ++++++------ > mm/Makefile | 2 +- > 17 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/Documentation/arch/arm64/ptdump.rst b/Documentation/arch/arm64/ptdump.rst > index 5dcfc5d7cddf..a2e527377da3 100644 > --- a/Documentation/arch/arm64/ptdump.rst > +++ b/Documentation/arch/arm64/ptdump.rst > @@ -22,8 +22,8 @@ offlining of memory being accessed by the ptdump code. > In order to dump the kernel page tables, enable the following > configurations and mount debugfs:: > > - CONFIG_GENERIC_PTDUMP=y > - CONFIG_PTDUMP_CORE=y > + CONFIG_ARCH_HAS_PTDUMP=y > + CONFIG_PTDUMP=y > CONFIG_PTDUMP_DEBUGFS=y I think we should drop CONFIG_GENERIC_PTDUMP/CONFIG_ARCH_HAS_PTDUMP from this list. It's not a user-selectable symbol so there's no need to be documenting it here. > > mount -t debugfs nodev /sys/kernel/debug [...] > diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig > index 77306be62e9e..db005618690b 100644 > --- a/arch/powerpc/configs/mpc885_ads_defconfig > +++ b/arch/powerpc/configs/mpc885_ads_defconfig > @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y > CONFIG_DETECT_HUNG_TASK=y > CONFIG_BDI_SWITCH=y > CONFIG_PPC_EARLY_DEBUG=y > -CONFIG_GENERIC_PTDUMP=y > +CONFIG_PTDUMP=y I'd suggest dropp this from the defconfig too, just like patch 1 dropped it from debug.config. Steve