From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B741C02198 for ; Fri, 14 Feb 2025 06:49:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B5836B0082; Fri, 14 Feb 2025 01:49:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D7A6B0083; Fri, 14 Feb 2025 01:49:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E47596B0099; Fri, 14 Feb 2025 01:49:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C972E6B0082 for ; Fri, 14 Feb 2025 01:49:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4B857B4918 for ; Fri, 14 Feb 2025 06:49:49 +0000 (UTC) X-FDA: 83117624898.07.9298DDD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 3956040005 for ; Fri, 14 Feb 2025 06:49:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739515787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IQ/KeB9CJIcnA70aNYUHnSsZiI9ewD2Pgt2oNQAajOw=; b=68v5U4NEmumwE3Rhsyw8Sak8dnPFVhz17anopQDJ9yZd5yHuuTdF+m04QHQC+SgguYKg1L TuVrOlftbhnWgZ5PhCPjtLWSZ4cOblWivMryYNb2DitU3pxAFg/3jBWcfAcX0bDn59ZRBR qeTW91IOoPQMr1SzoJ6LW8+JifOawlg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739515787; a=rsa-sha256; cv=none; b=i8DL6gDmcNeMoFD9Efg5W4c1JeqvrJR79ALpTtdzuosFIC+kqgVt6wnviK5BhtOvTTFiOR tItSaPCUfRMdH9HsJOax4k3ECmQheXaty+ZGJ7p62HYOaMHur2Ggy67sVmEQJc2cZWUmfW wtgw/KR2/GrqD+dq3LHapRq+wkmHDaE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B05E4113E; Thu, 13 Feb 2025 22:50:06 -0800 (PST) Received: from [10.163.37.128] (unknown [10.163.37.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 052F13F58B; Thu, 13 Feb 2025 22:49:42 -0800 (PST) Message-ID: <8e60766c-8567-4954-9d99-e1d702d0fcc3@arm.com> Date: Fri, 14 Feb 2025 12:19:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: Make GENERIC_PTDUMP dependent on MMU To: Steven Price , linux-mm@kvack.org Cc: christophe.leroy@csgroup.eu, Paul Walmsley , Palmer Dabbelt , Andrew Morton , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-4-anshuman.khandual@arm.com> <5504fadd-6174-41c4-90a8-d3ae7f76d7f6@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <5504fadd-6174-41c4-90a8-d3ae7f76d7f6@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3956040005 X-Stat-Signature: j5qp8t76mw4pmpwpt868skfx3w6urtb9 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739515787-310198 X-HE-Meta: U2FsdGVkX19xqEQ8Fr3N/DEqlkiqQD8jsGhTqXrjFKpWwgZ+II6W+Y6P7kIBqdtsCTty5rm9xZUT5Nup6+WQFQ8L3uwQIc40OQvUI6VtJeBRz+ElJWwi+a8ZvYUxF8EVgNwtomamD2bcejAAzVAbx4X25ew7nXRGRyAwrpnG8eO/NcazEJxl029D4J9lY7UJPOJu6K1w3pdpqgUCP6xlReMIT/RKxw2IxNoRQmlU1gt1YXBtHjTb3SOHVOi+Ogy5f6i03hpZtapHP9XR6mUSPTRd1ftP2arrEqz7lAYE0Vr+N757MYDthtkVJLL+hl2vwA9CqqiYEu2OUOTkK626IwFoLMZDCHWE+ttbt5ZTC57Thlp+DyZeGnzMfLkWIC9js8ZEhFCAeTYmu3dbCj9IzWuJQEKFhH5fWJuTw7zWe6O+SUiKn/Vo26v5VyQuHlypeHEsVv95ZWmuI2HeKeglH9oD7qdwDBMDH7bra3jT1G3f+rD3YCLxPWUQ5EpRdYBKQyHuJBKXlTlIA17njMXQ6huGjgaax+ym8CG66VksEeb9G1iQVV7lEZUh8Ese5dG9g5WqrBc10XSyCr9YWmyLfkC4Rw1Nhm64jC1GvZAtcRKqOTc32hAp9oKTYq6dwJbRDogy7lOPCGbEC75LZMZHJKihwkIbidWv3rMtUPuU14+l26P1HAkS5MP6Vp5JdaRYpSFUgGY4hjfyvc1lP5wWuAdPMAP70jXkvNKmF2gZHY6qzFpvJ/T31OUwYa+McY26BPOJFiKXYVHV225KsQdTpL48HHLrXbMDh+kdyEhOPWE7w71lF/8Ab2LP8gh0aDZiA62beU7ZxqzWEVKPcRUo6Hea3LUkeGM6MrnreOBDTXDnuGzmrmYZNpsso0yn137+DEJDI83uvprlwxI6ElO6TJ7oNMo5G/O8d/7Vtj+4zDX+UyvfO1bou7yMaqV0SG9Zkgmn07ayEPhTGh3bHyi EQwbDWN9 569oAFTs4JYbXts3heN9FGhs7kesLs0KhT9zc4V6sBPu3LH104W0rsoYle/PUEFOtiuOvkiOW9AdcW2n9KG4A14yMxjJwvVgCot1gWVg9YcjnaI6ee6O7sWJF6q5jlJBAAmYbd2SXAYBWUz2YKnXTWItsBN/qT/BF5R2ikUXwM3In9TNkcVbb29ey9EUj6s6UQs8P0XwlgbU0AmFuuCr1o6AQ8tCDxzaW2ZtPq3b4GUg/kJaZUM7tYYFOjfY4NlyPon0hjG/bC7n4/7hwS7kplGu3ycdN7RGRBjQPzr9aFxy+xtnPdSAsti3mLm/qRXD8HKRpifmW5Ot6GoDtTinyE5rQvO//s5qrSBXbRzGsijJrdA01ak0yVRYtgJVn3XenVxHdCp8Oels3K3qjiB30ZazVfr/JP6xh72EmCuPWYOH3p8Ij0B+iA+lvFiBjJik/x/60N+xac7AwZPBmtbH6WbDKOkzaOFkujQLFBxPzshJ7YDh0z+b1fGOQP5Z7v4P0qLLrf79KiBDUdLPWLqg9epfz95b2oHx+JiL9p1gsHlTsz8aGznW4K0eSnJeMnphXsHzD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 16:53, Steven Price wrote: > On 13/02/2025 04:09, Anshuman Khandual wrote: >> There is no page table dump without a MMU. Make this dependency at generic >> level and drop the same from riscv platform instead. >> >> Cc: Paul Walmsley >> Cc: Palmer Dabbelt >> Cc: Andrew Morton >> Cc: linux-riscv@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org >> Signed-off-by: Anshuman Khandual > > As Christophe has pointed out - this is broken. The select will override > the dependency you've added in GENERIC_PTDUMP. Generally have "depends > on" for symbols that are "select"ed is broken. I'd suggest just dropping > this patch. Agreed, will drop this patch. Thanks Steven and Christophe for the explanation here regarding correct usage regarding the "select"'s construct. > > Steve > >> --- >> arch/riscv/Kconfig | 2 +- >> mm/Kconfig.debug | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig >> index 7612c52e9b1e..c4cdba6460b8 100644 >> --- a/arch/riscv/Kconfig >> +++ b/arch/riscv/Kconfig >> @@ -112,7 +112,7 @@ config RISCV >> select GENERIC_IRQ_SHOW_LEVEL >> select GENERIC_LIB_DEVMEM_IS_ALLOWED >> select GENERIC_PCI_IOMAP >> - select GENERIC_PTDUMP if MMU >> + select GENERIC_PTDUMP >> select GENERIC_SCHED_CLOCK >> select GENERIC_SMP_IDLE_THREAD >> select GENERIC_TIME_VSYSCALL if MMU && 64BIT >> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug >> index a51a1149909a..c08406760d29 100644 >> --- a/mm/Kconfig.debug >> +++ b/mm/Kconfig.debug >> @@ -214,6 +214,7 @@ config DEBUG_WX >> If in doubt, say "Y". >> >> config GENERIC_PTDUMP >> + depends on MMU >> bool >> >> config PTDUMP_CORE >