From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D70ECAAD3 for ; Thu, 1 Sep 2022 16:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 790BA8000C; Thu, 1 Sep 2022 12:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 741386B00B8; Thu, 1 Sep 2022 12:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1C58000C; Thu, 1 Sep 2022 12:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E0346B00B7 for ; Thu, 1 Sep 2022 12:30:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F0A0C0FD8 for ; Thu, 1 Sep 2022 16:30:10 +0000 (UTC) X-FDA: 79864053780.19.C72A3CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 9AB91160062 for ; Thu, 1 Sep 2022 16:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662049809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLuHDLzRcMC/7r5bScPI3onM/CzOE/9m3NqNJ3imxUc=; b=c2npPZb1P8vtt/oudm9vgbPXpeR1D5225HEu3X7lTQSctcckOkcf8ELuqEZezS42HwnQYW a4QbiX5zLiZY4BrNMk/x6nUqKLr7Jh5ZeRa+ynUTS6afEqztpvafiaXbsOzpn2LGfM1VP1 7HooZ/N7QviPgzWKnsVhnrF+19nGrSY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-136-Qg-CMhPGNbuJn51x5WOlvQ-1; Thu, 01 Sep 2022 12:30:07 -0400 X-MC-Unique: Qg-CMhPGNbuJn51x5WOlvQ-1 Received: by mail-wm1-f70.google.com with SMTP id f18-20020a05600c4e9200b003a5f81299caso10063583wmq.7 for ; Thu, 01 Sep 2022 09:30:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=fLuHDLzRcMC/7r5bScPI3onM/CzOE/9m3NqNJ3imxUc=; b=RmtRqdl886ZUk+Rn2bqYjW9FyJ27nLHBJnRj00MJaVFPjKfXXw4v6m/8bo2975Tk7n r8ZqUYPNeQ8cYkGYzz2+tLmr57K9jskxgogLRAXeVziATrz56kbHWfFw9RDb/fSNzxG/ 4eTQspuxIqMUppd1JLdnMpK0K//alsq9C54D8Yu1WnX5qjeNpVD8plsve5KPOKOtrDGi WLbVsvoQrr91rsQtPTWJVSDujCVrqKmKt07CjMvhlLh3AMRxixQ/S6LGALcVaIY5kAgl NVFDRV/ThW+s/wq9eaxi4HAFzo0yAie+OhDqDHzdPreFrMo1nKM3QYJKX+u//L/QM6ys bLxg== X-Gm-Message-State: ACgBeo3h1Io3XsdyaQ3jDNCC/QfyyQ1BtQQE127XNSeL+eY2oU995/JB H4Mtez7AzE2dboSS+QAVHaqjw3d7Jqx5kzfvcwrgyC1B3gBHGoulMNCLSLXM19N/NSYJJ7SAZgW elB3u8p7Eckk= X-Received: by 2002:adf:ea51:0:b0:226:dd73:8b88 with SMTP id j17-20020adfea51000000b00226dd738b88mr10662027wrn.175.1662049806701; Thu, 01 Sep 2022 09:30:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR5NJHbqnyKjsbcgDD2m9PqfCb+kWWILrc8Jstl6MuxgmJZniixWAO/kTIg/6AMvhAbZ+lXBcQ== X-Received: by 2002:adf:ea51:0:b0:226:dd73:8b88 with SMTP id j17-20020adfea51000000b00226dd738b88mr10662013wrn.175.1662049806449; Thu, 01 Sep 2022 09:30:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id r7-20020a05600c35c700b003a5b6086381sm6575410wmq.48.2022.09.01.09.30.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 09:30:05 -0700 (PDT) Message-ID: <8e566857-d552-86f4-cbbb-5eed9de6acca@redhat.com> Date: Thu, 1 Sep 2022 18:30:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A . Shutemov" , Sasha Levin , "Aneesh Kumar K . V" , Vlastimil Babka , Jerome Marchand , Andrea Arcangeli , Hugh Dickins , John Hubbard , Peter Xu , Yang Shi References: <20220901072119.37588-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1] mm/gup: adjust stale comment for RCU GUP-fast In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662049809; a=rsa-sha256; cv=none; b=i55m0IYVGC5RcDM2lOxbJsbJU00F9FguEQ3DyM7nTxHPxkpM4ATNz4M+Omv8rRU86lwzIf +YsCEQDYWo3no/uVSbgSTLPtwCdbELcjJ5EickyqV+Lrq4gGnYLqMXcTmoPZUZvUE0ic4Z JDYMOqih8adrkP9SoQuBrKRLvfe8j8M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2npPZb1; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662049809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fLuHDLzRcMC/7r5bScPI3onM/CzOE/9m3NqNJ3imxUc=; b=7EXoLMQOWurkxUpr9IE+9QkyKqWXpLGfbOdHJ4QJxdHtAcIgdb6nAP3MlKlCHGfB0i+Erc 2krGn9HOpkMkHufcE4hgKdb6lmcZyTjM6EXT/BT8NgMfUiWR92rpXT0euQSHYM6SF2eBI4 /7gnuU2SSCFTOtem37eHUYx4Q8sNJNU= X-Rspam-User: X-Stat-Signature: anu9zfyctpshw67ujx9xw67hgscff7ds X-Rspamd-Queue-Id: 9AB91160062 X-Rspamd-Server: rspam06 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c2npPZb1; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1662049809-739381 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.22 18:12, Jason Gunthorpe wrote: > On Thu, Sep 01, 2022 at 09:21:19AM +0200, David Hildenbrand wrote: >> commit 4b471e8898c3 ("mm, thp: remove infrastructure for handling splitting >> PMDs") didn't remove all details about the THP split requirements for >> RCU GUP-fast. >> >> IPI broeadcasts on THP split are no longer required. >> >> Cc: Kirill A. Shutemov >> Cc: Sasha Levin >> Cc: Aneesh Kumar K.V >> Cc: Vlastimil Babka >> Cc: Jerome Marchand >> Cc: Andrea Arcangeli >> Cc: Hugh Dickins >> Cc: Jason Gunthorpe >> Cc: John Hubbard >> Cc: Peter Xu >> Cc: Yang Shi >> Signed-off-by: David Hildenbrand >> --- >> mm/gup.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) > > The comment a bit above seems to need touching to: > > * protected from page table pages being freed from under it, and should > * block any THP splits. Ah right. Will drop it as well -- thanks! > > What is the current situation for THP splits anyhow? Is there are > comment in the fast pmd code explaining it? Not aware of a comment, I think it just works naturally by always re-routing references taken on tail pages to the head page refcount. Before that, we had "Tail page refcounting", which -- as I understand -- was a mess. ddc58f27f9eee9117219936f77e90ad5b2e00e96 contains some comments. > > But this seems OK too > > Reviewed-by: Jason Gunthorpe > > Jason > -- Thanks, David / dhildenb