From: Gabriele Monaco <gmonaco@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, "Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2 2/4] rseq: Run the mm_cid_compaction from rseq_handle_notify_resume()
Date: Wed, 24 Sep 2025 17:22:09 +0200 [thread overview]
Message-ID: <8e51adf20a9eafd3046c1189989f87734576bd57.camel@redhat.com> (raw)
In-Reply-To: <d5183516-92ea-4a76-9506-2f7e4da0b0ad@efficios.com>
On Tue, 2025-08-26 at 14:01 -0400, Mathieu Desnoyers wrote:
> Your approach looks good, but please note that this will probably
> need to be rebased on top of the rseq rework from Thomas Gleixner.
>
> Latest version can be found here:
>
> https://lore.kernel.org/lkml/20250823161326.635281786@linutronix.de/
I rebased and adapted the patches on the V4 of that series.
To get close functionality I went back to the task_work and I'm scheduling it
from switches (rseq_sched_switch_event).
Quick recap:
My series tries to reduce the latency caused by `task_mm_cid_work` on many-CPU
systems. While at it, it improves reliability for bursty tasks that can miss the
tick.
It reduces the latency by splitting the work in batches. This requires more
reliability as compaction now needs more runs, which is achieved enqueuing on
switches instead of ticks.
While this solution works, my doubt is whether running something there is still
acceptable, considering Thomas' effort is going in the opposite direction.
My tests don't show any significant performance difference, but I'd gladly try
different workloads.
Any thoughts on this?
If the approach still looks reasonable I can submit a proper series for review.
You can find the series at:
git://git.kernel.org/pub/scm/linux/kernel/git/gmonaco/linux.git mm_cid_batches_rebased
Thanks,
Gabriele
next prev parent reply other threads:[~2025-09-24 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250716160603.138385-6-gmonaco@redhat.com>
2025-07-16 16:06 ` Gabriele Monaco
2025-08-26 18:01 ` Mathieu Desnoyers
2025-08-27 6:55 ` Gabriele Monaco
2025-09-24 15:22 ` Gabriele Monaco [this message]
2025-09-29 22:01 ` Thomas Gleixner
2025-09-30 10:18 ` Gabriele Monaco
2025-10-02 1:22 ` Thomas Gleixner
2025-07-16 16:06 ` [PATCH v2 3/4] sched: Compact RSEQ concurrency IDs in batches Gabriele Monaco
2025-08-26 18:10 ` Mathieu Desnoyers
2025-08-28 8:36 ` Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e51adf20a9eafd3046c1189989f87734576bd57.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox