From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B86BC001DF for ; Fri, 28 Jul 2023 14:35:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F7588D0001; Fri, 28 Jul 2023 10:35:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A83B6B0074; Fri, 28 Jul 2023 10:35:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46EFC8D0001; Fri, 28 Jul 2023 10:35:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 37C556B0071 for ; Fri, 28 Jul 2023 10:35:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B52E2161184 for ; Fri, 28 Jul 2023 14:35:15 +0000 (UTC) X-FDA: 81061268190.19.66A3BE6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 50B0118001B for ; Fri, 28 Jul 2023 14:35:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dSVtRjN9; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690554910; a=rsa-sha256; cv=none; b=dCXGPmq+HSGFoWC4f6TkLJgwUyxixjUgUBKJ/W2VaVioaMEmOj05dxdVOljWLFDmtynDMX rYa0gq5ZvX+u93gwYAqm7bjMw8o2Cf5YR2E9Bh+OnEmHuwqU3u+wRyUQ1PLa5JsVyUH556 lm/XfZAae5z0H7K3pLI6kHsodm1HTs8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dSVtRjN9; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690554910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8f2jcEWHe85NAwJ+QYf2QWkY01PugbZbbWPEErvXII=; b=HJVtui8WmH5p+nSoX+iIgR5eTXH0d7EaC75i9Nkj8IIu/otfCX/4GJ2sSq15m31EZ9vkv3 deqq9v/U08h1g/mD3R+nWm1AV27t0BvyfbQSz5QnPI5HtLsBRVtMa7h/D8v2QKbtvvBDKI tWojyloGS34p/2Hoxy3cdeMqR2XfQnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690554909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T8f2jcEWHe85NAwJ+QYf2QWkY01PugbZbbWPEErvXII=; b=dSVtRjN92KOaajraJrUYmBCnKfqcPZ5pJVGB8DgkLkZKCXXSTBDyuIOYfFlFpwbttnCGCZ 6j/IGfB0tbmaJgceleS4Iw4SFrrc3fGc2pdmOgz4hD3TmXnRKIpcdEuwyNpZFGo7TFnrij IyLDLOIvaIBJUNFJZ7+TG1NN815hnNo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-_MrDCzGjOe2IT5bqhUjOKQ-1; Fri, 28 Jul 2023 10:35:07 -0400 X-MC-Unique: _MrDCzGjOe2IT5bqhUjOKQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fbfc766a78so11753235e9.3 for ; Fri, 28 Jul 2023 07:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690554906; x=1691159706; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T8f2jcEWHe85NAwJ+QYf2QWkY01PugbZbbWPEErvXII=; b=EuqtaBTJsxKvj2PKv461j56M06xdGOBTFIg/tU85l2vBnal3j5V9AoJDq1P+EBelyv upSA5xi4LQgThkh4gmHXDrZ5QQoVn1K+LGsb3e0DRQbmKthHY5kedrcpJss3dIzcbLYm UCeFVRwHwgpVXS9Z0FkPsEw8bNKw8BkyK6hLjPSSJAeZvmPoNRgwd7iuF3HH0+T+509T 2a5r0pXWN+fQAx68AE55B1GLPDcZ9qNKKF/ny8Gcr02UWFCJ5kwMUYEXfm+yTdLqELiT gywA1sWEZAK2kCdp+8MyTxg4mCas/WFoJ+/H7uLoy90gfJkrqoCbMK5DPGTdl+eTFujX dluA== X-Gm-Message-State: ABy/qLZyTLYZgL0eOvY3TEXPYgRzIZcxAvGJKbaIVvFaBntDyRCJco/B 9t4ZIadOG4UJXqGLJfpKOIY0Kw8iz64jOemgLtQmYY2JPTLoJpiiUqugq7pN88BGz3Y4qnPYseA 1fFrwaWI/WZI= X-Received: by 2002:a05:600c:2248:b0:3fb:ffa8:6d78 with SMTP id a8-20020a05600c224800b003fbffa86d78mr1882094wmm.36.1690554906732; Fri, 28 Jul 2023 07:35:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGghZKLFi0VL5qxS7EG+DsAnMC4z1b9QjFmvxxsSdSuv02WebYTiWKZNZ14tKbZSFP1Q1dm0w== X-Received: by 2002:a05:600c:2248:b0:3fb:ffa8:6d78 with SMTP id a8-20020a05600c224800b003fbffa86d78mr1882076wmm.36.1690554906382; Fri, 28 Jul 2023 07:35:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id f2-20020a7bc8c2000000b003fbc9b9699dsm4324357wml.45.2023.07.28.07.35.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 07:35:05 -0700 (PDT) Message-ID: <8e4d9fa7-7550-87a9-ead1-2d2a8691cdab@redhat.com> Date: Fri, 28 Jul 2023 16:35:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] selftests: mm: ksm: Fix incorrect evaluation of parameter To: Ayush Jain , akpm@linux-foundation.org, shuah@kernel.org, pasha.tatashin@soleen.com, zhansayabagdaulet@gmail.com, tyhicks@linux.microsoft.com, raghavendra.kodsarathimmappa@amd.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimhan.V@amd.com, Santosh.Shukla@amd.com References: <20230728060109.4403-1-ayush.jain3@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230728060109.4403-1-ayush.jain3@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 50B0118001B X-Stat-Signature: ux3br3op1bo4ok1imti19qtbzmidhp6u X-Rspam-User: X-HE-Tag: 1690554910-629744 X-HE-Meta: U2FsdGVkX187pBeLieolNeR6Gp+rKn3y9ft1rzRugytWMrX97thUzpYSOirXrcPyidIJyzTOqxq3NTd9KXkNGvO7eZz+gHdFRTgApE9Qt6x+/k2DBLsaE54OGAlh5MK6oa8j52WBzkYoJhyuwhjxbxa6thUf9tfWQdt1yEVhJUS4FL2OS97csBsHDwju1NIilIsT3Nm1l6U6Niav0CqEf2gLUXkIVRAqbtckcj8HI7FNiGvW+gmNBbahBr2fJdhvBmE04D/0EU8e/8TYABmwz/lZTUmCE2YBA1gELc1Z3ChvcZB3k86SWpFvaSs1dFj4gAF6l422AtsvPLWrTt8VRf+BgP0i1I1/OxRvBtMX0oX3BDBBr9fn9p2TpT0r9EyB4o1pnJwWHYFsvfhfFCu4EsCD7sPS8gPxQwl3QzY3jaiPYlqrJvj6bBFvpLeT3gOO0lIviCn2nOHU3UDAFFBRRh+6Zuy0DSlJbhhgDOrlVc53YPIjnOB0OYu+x4cz2nFw5/0mncJaZAn73f5IJW7l5mNTdicT2iksoYqaP3JklBVaHGKRsNwRhwAiEqfjPkewcgHgn8chSO8BhMPb96LNhxBtNqVTSzqonreulv88+23X3JmSo3IUo33n+txi9RT1nf+iaP14fWmArjITQVSUC22yH5dmicrKW09sS1BiKEeHYbyDFb2lSIYC7aq9o2IXKHyxsbnzdWRwKmFhsxzLOZzWeEvM9WgNNvmezTfCjfQ0OS/tst3YsNzMAz2PPl5RFwVfrVHBwA64BK1CZOz/WpGvNzxFlSjD7xlTVORCnOugevXBWgcsckOELCLKR4PO2OeqOX91ASiR5q5EP2YoUNz7xfQRibIBQoHiX+IzksQXODVNp2YEAWVqVBqQYa6VcjrsL5OhiBNAgL+d/tyPB227+ItakTXb9mLLIOBekRM3KwtbRtJrLvLR7ZaNdN4gcSLKWBYcy7h0cOUIC/7 arRDXtLX TEtg2Va+rlfJ9dKTHuX/4+bJqpAqPz+b+Hw9qac7nhbVBlFKArXeOAK8VTh3HlJfSQ5/9OY5EjRoUwYGjJIEBdGwItMm3aU2XeIDkKrslxrpysudLxsB6sXLcSS7+BPnNUwqrUeQjictUa1X9hujsVlqG7UJpYi2YqXDacJszoQDlha4p6rvMc42ULc7356jFoZdPH7HosaAx0xTLqJawSI2jTMuKPIESFUDdZEJm6zwHcxfTi4dOxB1FvsvyTLCYz+7NKjeh9hOmc6ItJ/7Gg3q9XxixvO3gzccv+O70Rr3mnel5LmjipG9kANq/ATx6Maq/HpKeF28jPxFu7uv51Cl6P6zxGaGkOBRKQZqIHlMkDQ6vcvuapRW653Uu2C08DdlZXSdLV4JEuzbjLlf9/TeQ6fG9Pxpup9dY X-Bogosity: Ham, tests=bogofilter, spamicity=0.001288, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 08:01, Ayush Jain wrote: > A missing break in kms_tests leads to kselftest hang when the > parameter -s is used. > In current code flow because of missing break in -s, -t parses > args spilled from -s and as -t accepts only valid values as 0,1 > so any arg in -s >1 or <0, gets in ksm_test failure > > This went undetected since, before the addition of option -t, > the next case -M would immediately break out of the switch > statement but that is no longer the case > > Add the missing break statement. > > ----Before---- > ./ksm_tests -H -s 100 > Invalid merge type > > ----After---- > ./ksm_tests -H -s 100 > Number of normal pages: 0 > Number of huge pages: 50 > Total size: 100 MiB > Total time: 0.401732682 s > Average speed: 248.922 MiB/s > > Fixes: 9e7cb94ca218 ("selftests: vm: add KSM merging time test") I think this actually fixes 07115fcc15b4 ("selftests/mm: add new selftests for KSM") that added the "t" parsing. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb