From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA368C5479D for ; Sat, 7 Jan 2023 00:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68FC48E0002; Fri, 6 Jan 2023 19:17:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63FE58E0001; Fri, 6 Jan 2023 19:17:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52E7A8E0002; Fri, 6 Jan 2023 19:17:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 42FAD8E0001 for ; Fri, 6 Jan 2023 19:17:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1885A80862 for ; Sat, 7 Jan 2023 00:17:46 +0000 (UTC) X-FDA: 80326089732.03.00BE873 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf01.hostedemail.com (Postfix) with ESMTP id A907240002 for ; Sat, 7 Jan 2023 00:17:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MI5E0H3D; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673050664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ENVVa+/v8d++LgdtA2An71ypm0Z/VuT8M5KbxWNj/pU=; b=VFYgWISsJBeQ8TYLWe7ksbnH0n0sYm20Z26FwXB0JJbIHlAVhiNRjKhpziJ+QXaQGbEQ0w JsurjeMjGqeg68TfYxlzHkvTLMYZ5wyUwxpLc/9hWKHo/vvzZoas1LHz1iqsDvh7gN2lAC ylOG1ntQ8PT2KJN9xN08LS9xL1TLG4c= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MI5E0H3D; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673050664; a=rsa-sha256; cv=none; b=fJCTPS1BOq+xnAPmkGCDljZ2NyJTa/IjJb3ZN6ZfAwSDiMpzIo5kwVNgdAoiYqZ7GD2xnA +sMoHHKJusqDpnrEAzbTiFHuoA++/9cWWEpcDnNujBIY5QfKaejnkcbuXkFyNEBNHFAWzf 6zIgwPHgkJfv+gfFX5FpE5yBZx+OVj0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673050663; x=1704586663; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mfxUCnVszE/gHGtsaclofwX82ZTIGkhFDTZ/pk93hdE=; b=MI5E0H3DxjhfGyDGCzuUwOfgPhx7CNdxJBpg9kLQPlHQhL60jlIJQ1nF PCojotv6F9hj7sf2IUZHlPoQJxgGwShCt/MA9hYjVl9beta4DzlGQIvCv ckRJHDPK2aky4+g6DIAqyt7k2cZyNBt+sMyW3FqAerw75wcrfAcwYoqjE xC/LRmXQRwSo48A57mQb2z3KmBS2V5sFiwbqXs25cSkB4UbnVQBXDIQg7 yWlO3QJkj/UAisGsKeoqF2Y0hRWjnFQ3xee8k9ppFwJVu+dHjKGwNMmEz jGuk4nXUbWr9oxPmSogkER+C2fiByGuZbV/by0rb46hU0n3+Ne3pAGQ8o w==; X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="306112553" X-IronPort-AV: E=Sophos;i="5.96,306,1665471600"; d="scan'208";a="306112553" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 16:17:34 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="798441217" X-IronPort-AV: E=Sophos;i="5.96,306,1665471600"; d="scan'208";a="798441217" Received: from xiangyuy-mobl.amr.corp.intel.com (HELO [10.212.251.186]) ([10.212.251.186]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 16:17:32 -0800 Message-ID: <8e46f932-8ec9-0621-4423-e6233747b231@intel.com> Date: Fri, 6 Jan 2023 16:17:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 14/16] x86/virt/tdx: Initialize all TDMRs Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <16d47f9611d53c0f07a4af2b5739ed83e41b6e48.1670566861.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <16d47f9611d53c0f07a4af2b5739ed83e41b6e48.1670566861.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A907240002 X-Rspam-User: X-Stat-Signature: rrgxi1heo363rzz14jaoddssyihwtzso X-HE-Tag: 1673050663-918823 X-HE-Meta: U2FsdGVkX18QAaGwx4YHIJGHfPQnqikMz2qaP/31MIYDjI7Vn72gZXxD0AIm9KLS8Ao64bdm37PBLtaccffkM/reIztFDvwLPb51vL2cnxoQ822bfPYAaqMRFtQhtCbyiK5cnWKRPkibfmFnQ17lSE7Zcb/p76UUi4A9A5/wxP2W76nQRHg9z9i+sYUdhwU+lkD9/K7JTIub7IdAVg8/K+LIimrS/LWqp5Zj7fY/98tWO16Q2bMihMe9oauzmw14dHSGdhvZpQXaZvzwXJ90S06YTt2quZ9B4tzT1gFqR1J4LnspIut99ky+Y0dvgwkeu9VZhZh+SFKYa/xaNKLJWfC25dANusH/O4AiIxeb8DeaAvc6cSPnN8rG3gF+E4MO0L8fFJDrz68m0vHEMLgsxBXaps94/46ClATU01JkF2noW1IDPk6JhpCHCDXh8jQPlNYRsiJeCrHCgPz6mlUmEOLD4Mi14z5imrSDvahD6a8wWffOTDe8E/637xVj6tUo/kG4D2D1A3fAeiEtpGFjH1FV1Icvv5z2qlr7UuL8rvwH0mPaaloXkbMGpC2Zo17AGwPd5H9P7bsaxV8w6J3oQ+hjZeQOHluJlSw+Y82aiOjLrmKhF9Njj8MVf3igDU6zgIze7Gcsd7DgSeLtwp2zYmwFV2BZM04cPn0GlNkrZJnqdMGqvMQxM6T+uN/zegpI83/F+L2p3CKeZQq3XPiDbdlBrErz69BGjkZy+g3a2ETWDWc1/BeWxw0zN3qMgyLjY7gvEJRR6PYKZiC2NklpbfTzwRG+N4gSkmCXfcDMm9Dw90G1sYAc3yzxwict87jJ5YOILsWiKT6KqUGKBNiQZE9reVImBeLrj7lW2iERD8M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/22 22:52, Kai Huang wrote: > After the global KeyID has been configured on all packages, initialize > all TDMRs to make all TDX-usable memory regions that are passed to the > TDX module become usable. > > This is the last step of initializing the TDX module. > > Initializing different TDMRs can be parallelized. For now to keep it > simple, just initialize all TDMRs one by one. It can be enhanced in the > future. The changelog probably also needs a note about this being a long process and also at least touching on *why* it takes so long. > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index 4c779e8412f1..8b7314f19df2 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -1006,6 +1006,55 @@ static int config_global_keyid(void) > return ret; > } > > +static int init_tdmr(struct tdmr_info *tdmr) > +{ > + u64 next; > + > + /* > + * Initializing a TDMR can be time consuming. To avoid long > + * SEAMCALLs, the TDX module may only initialize a part of the > + * TDMR in each call. > + */ > + do { > + struct tdx_module_output out; > + int ret; > + > + /* All 0's are unused parameters, they mean nothing. */ > + ret = seamcall(TDH_SYS_TDMR_INIT, tdmr->base, 0, 0, 0, NULL, > + &out); > + if (ret) > + return ret; > + /* > + * RDX contains 'next-to-initialize' address if > + * TDH.SYS.TDMR.INT succeeded. This reads strangely. "Success" to me really is different from "partial success". Sure, partial success is also not an error, *but* this can be explained better. How about: * RDX contains 'next-to-initialize' address if * TDH.SYS.TDMR.INT did not fully complete and should * be retried. > + */ > + next = out.rdx; > + cond_resched(); > + /* Keep making SEAMCALLs until the TDMR is done */ > + } while (next < tdmr->base + tdmr->size); > + > + return 0; > +} > + > +static int init_tdmrs(struct tdmr_info_list *tdmr_list) > +{ > + int i; > + > + /* > + * This operation is costly. It can be parallelized, > + * but keep it simple for now. > + */ > + for (i = 0; i < tdmr_list->nr_tdmrs; i++) { > + int ret; > + > + ret = init_tdmr(tdmr_entry(tdmr_list, i)); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > static int init_tdx_module(void) > { > /* > @@ -1076,14 +1125,10 @@ static int init_tdx_module(void) > if (ret) > goto out_free_pamts; > > - /* > - * TODO: > - * > - * - Initialize all TDMRs. > - * > - * Return error before all steps are done. > - */ > - ret = -EINVAL; > + /* Initialize TDMRs to complete the TDX module initialization */ > + ret = init_tdmrs(&tdmr_list); > + if (ret) > + goto out_free_pamts; > out_free_pamts: > if (ret) { > /* > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index f5c12a2543d4..163c4876dee4 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -21,6 +21,7 @@ > */ > #define TDH_SYS_KEY_CONFIG 31 > #define TDH_SYS_INFO 32 > +#define TDH_SYS_TDMR_INIT 36 > #define TDH_SYS_CONFIG 45 > > struct cmr_info {