From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264A8CFC273 for ; Tue, 15 Oct 2024 08:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF9426B0089; Tue, 15 Oct 2024 04:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA8706B008A; Tue, 15 Oct 2024 04:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 949046B008C; Tue, 15 Oct 2024 04:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 757B76B0089 for ; Tue, 15 Oct 2024 04:16:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C6E4B41443 for ; Tue, 15 Oct 2024 08:16:23 +0000 (UTC) X-FDA: 82675129488.30.8BDADE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id CB39BA0006 for ; Tue, 15 Oct 2024 08:16:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cg31ufIp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728980140; a=rsa-sha256; cv=none; b=qalZMXq9vVyPWLzka7B8xiK0r6ChU3IFHTSAgNBDBbEThwwzDBMMI8nPTPs3gIMHR2cCVw b7K8D8ni+/BwIUIky1hySoIC2d9skEKE9//Lqzrtb+HLZjl78LL6MP+vBEADB/fj+C6gio uEtV26JEv1CGrpJ0s0bqTUDkilDrrA8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cg31ufIp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728980140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y3qaJxVISZGKPtAe1Txr62rhPQYoQyPl/3xNbSM7RfA=; b=PfSMf4UL1b5h51hrEYv5sfC7H6JBO+ON+w9FYxSZqXGFYKuh7tVHF0UYUfp1KS5PFNuwkk oeMGLXcTOSj/aJ4jC/ZzPAErX+TqpWLtOyjgj/iW//R5VFno27LX33G/S35/+1wY5zNRG0 +gUQmmfGfoEiRoGwXpRLwDrCJgqtlFI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728980186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Y3qaJxVISZGKPtAe1Txr62rhPQYoQyPl/3xNbSM7RfA=; b=cg31ufIpkwnxyoeb+1LHQbnoxEGhPgBXOo3qPc+EKNaI4ijlT8fJp1DfrFeKazeK/FSto7 IPfasf9YY4iLrqSstMtFZlrbamz3Y5sT9vAE2aYf3+x3KR2vArEl4kpTsYtaU0sUy2wmAU sv2ywShgJGweA3RNLT/t9jdxArR2WEY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-zBElLy9QPAi7UjU8lHlVkg-1; Tue, 15 Oct 2024 04:16:24 -0400 X-MC-Unique: zBElLy9QPAi7UjU8lHlVkg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539fbbadca7so1218432e87.3 for ; Tue, 15 Oct 2024 01:16:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728980183; x=1729584983; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Y3qaJxVISZGKPtAe1Txr62rhPQYoQyPl/3xNbSM7RfA=; b=pwenofzp66uvSHSWNCOrivw2jaYwMVfRDZJg9odkPFhM/osluNpDwA+wdMXjlw1xEL tzxn01dxvVShSUAr9hMMKsj+6pKP3m8zzy9ohtTvyoNyIEJ7QrA/f1ENxlyXZB93B3lT i6GJbbSsigptajNL7LoP9JKHz8v44pbDd1mmajYgM/mD+D/KTQmpkVA6WOQE32xn5+v9 adUpidBAkBZ5wvgDPTvwVcfHU3/mFUmHPZTN6RfOKFWXTpw0ha0E+6Ev9RUmBvI5HVrJ rHrSAgwI1vuPLh8P9Rzzr/MSE5D6ebfyq1hQau6cUFFqoWBwjIAOSXDbTuDSTRwe67fv WdNA== X-Forwarded-Encrypted: i=1; AJvYcCVXCP7qniHmVN0dIsC5vQvqAr/zvk9ZxnqQEKHgh99TTBGiz7EuuEFWu4tt999tn9qHcFpzf/Bbww==@kvack.org X-Gm-Message-State: AOJu0YxBkbbXEa5K1sIeA2vXxm8bmvmCZzZUsByvN2FnwRyWnHHXZgQi MkkXBQtItwglH/esRpDMuGidk2GhgrP2n6v/VSVlGyp8mk1zWVs0j73Ofl7dl/omIHriNbgZFZ/ 1YqC3wkOH6bnADRbTY3DpV9/f/xvftUmPr3+cX73IgyL5fe5u X-Received: by 2002:a05:6512:138a:b0:539:e911:d20e with SMTP id 2adb3069b0e04-539e911d2d5mr4301457e87.47.1728980183040; Tue, 15 Oct 2024 01:16:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGONdNBejOBFAKiCA308e8Vr2A7//3b+LsytzSBJyDurciY5f5xqFdG4CvlVFIh1Pfw4fq3aA== X-Received: by 2002:a05:6512:138a:b0:539:e911:d20e with SMTP id 2adb3069b0e04-539e911d2d5mr4301421e87.47.1728980182494; Tue, 15 Oct 2024 01:16:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c730:9700:d653:fb19:75e5:ab5c? (p200300cbc7309700d653fb1975e5ab5c.dip0.t-ipconnect.de. [2003:cb:c730:9700:d653:fb19:75e5:ab5c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fc445fesm913160f8f.113.2024.10.15.01.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 01:16:21 -0700 (PDT) Message-ID: <8e39522c-2853-4d1f-b5ec-64fabcca968b@redhat.com> Date: Tue, 15 Oct 2024 10:16:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] Documentation: s390-diag.rst: make diag500 a generic KVM hypercall To: Heiko Carstens Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Jonathan Corbet References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-3-david@redhat.com> <20241014180410.10447-C-hca@linux.ibm.com> <78e8794a-d89f-4ded-b102-afc7cea20d1d@redhat.com> <20241015081212.7641-A-hca@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241015081212.7641-A-hca@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CB39BA0006 X-Rspamd-Server: rspam01 X-Stat-Signature: bgdtzi35cuyhc36ykqsahauq31poxghf X-HE-Tag: 1728980181-498527 X-HE-Meta: U2FsdGVkX1+fWE5dtaW4K2evO5uK2MX1V7vns3X6BRWyR1+PM9ZcYDCoAcHtRAesmpU6IPKtAS5kF/vrP4FD9HCjWue3idFmh4bG61yOlyVkSZtPpXJ5MTkpNGffxLR/8PBfBk+1+9cxL7Elj/u9dlJtXG/fZUoyMMPQR71wx3ozq4JJDlzq2vHIltdWy5zoMSFQH6ptKs9UuJRukRdgbvBWIpvdYD/GoNJuQQjO/v7rzNIemIkLiOBwz47uXtoNXELMKtHI3eBvf3m44e13ytafnjafZaWog4WNO+wmUxBus+NydGpJzfWJ7PTZl5Dx6kM25Iuapzlbtj1gs7K2JlW3k8JlGobkL7XX/rE9ASAe/FfDuHM1xQ263ias7U8uEpD3ndpd+WHz3IgsHSEkxZ4pmbDVBb3n4bMH1Jwz1g5CIZjKMaB7UJv+Advpavl6kTcVKnmLtr8lZ+bfzutx0e0yeyi0Bl4LjeW0Y20EwMau0LVK3wVNxvez6jEyn+IX5YCHS6aTwjM7nol3jaqAWLWZypJwqgSIbFHKkjQluB22uxSchlOzUNNwXzJtOB3XgIgOW91Zx/U1boJ1rYq44fwzu+Ap24IzBL06OjEwvaeHTP6fenPdFm9zX3oMPs/gD9zEPBfi92eE/91mm5LwjkiVNTZ1Oeujt3+Q/GWXyV+aTRAsiVxAybgTVanPalyMWbwKDGuOez4gPomFvdeWUFXjHybTUfWrq7Xg52i8G5sOEncuNi8HeNRWS4k4Wd/rCvsJDRhqGC6IJL5ZUQbn5bmS8iSaHYJzkSA7eQbY/R0sUBSLdm9Q/NCsk3gM1jjsxaeQiCUxRlI/oXLQb3Mt3UUvL/RQfwNmAVQcwjUGygWtxB5ybQM8qJ1p8N4Cl3/PhzIFxT4eUNX3cF+Q5bmW5F7FZFLkYyITB+BlP4EohgxTqKAoLTgj2kFAKxeznJHMAHpPIA7ysfWLDwqyq5M hL62t5Go kooF42Fgznt0hESVZKS1FHfVNEAh/0cnP7wka1sGfqdKCJYHPczl+PoaAzh8ylMqH5tx6tEiR1IX0XAL8iOw3eo+zXVXo84G7FW3FHtOTYA8Pr+pLwlQ+dQvy8qPZ7moVmj8LzOWNZVSPjTZOkfbiWtDqTZOS5pxR3dz3BPMZhdLRXGnu8rrjzl4hStJAN1IVyPRTIg+fe43gTEa1vEF/sFiH82LTNUM8W937Kk/bNj41kUCEoz2O0djSjV5nQwFZyX9Fi+HzaCErPS7LEBiolGXhSl93XVxewnnPAblDL4fzCmed/zfwynahSVY3snBFnwGK4nVERRA8scVlUmK7i4U3ZMAHXS5bFFYC31CcWGzAfDzehCg4XfLiEvyUxU40ApWQrVw/9PHDQUL1Z3LTOkfe1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000189, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.10.24 10:12, Heiko Carstens wrote: > On Mon, Oct 14, 2024 at 09:35:27PM +0200, David Hildenbrand wrote: >> On 14.10.24 20:04, Heiko Carstens wrote: >>> On Mon, Oct 14, 2024 at 04:46:14PM +0200, David Hildenbrand wrote: >>> If so, it would be nice to document that too; but that is not >>> necessarily your problem. >> >> I can squash: >> >> diff --git a/Documentation/virt/kvm/s390/s390-diag.rst b/Documentation/virt/kvm/s390/s390-diag.rst >> index d9b7c6cbc99e..48a326d41cc0 100644 >> --- a/Documentation/virt/kvm/s390/s390-diag.rst >> +++ b/Documentation/virt/kvm/s390/s390-diag.rst >> @@ -50,6 +50,9 @@ Upon completion of the DIAGNOSE instruction, general register 2 contains >> the function's return code, which is either a return code or a subcode >> specific value. >> +If the specified subfunction is not supported, a SPECIFICATION exception >> +will be triggered. >> + > > Looks good. Thanks! > >>> I guess we won't see too many new diag 500 subcodes, or would it make >>> sense to implement some query subcode? >> >> In the context of STORAGE LIMIT, a "query" subfunction is not really beneficial: >> >> it's either one invocation of "query", conditionally followed by one invocation of "STORAGE LIMIT" >> vs. one invocation of "STORAGE LIMIT". >> >> Once there might be a bunch of other subfunctions, a "query" might make more sense. > > "If only there would be a query subcode available, so that the program > check handling would not be necessary; but in particular my new subcode > is not worth adding it" :) > > Anyway, I do not care too much. > Okay, I see your point: it would allow for removing the program check handling from the STORAGE LIMIT invocation. ... if only we wouldn't need the exact same program check handling for the new query subfunction :P -- Cheers, David / dhildenb