From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9701FC433F5 for ; Tue, 3 May 2022 14:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D10F86B0088; Tue, 3 May 2022 10:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBEB06B0089; Tue, 3 May 2022 10:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B861C6B008A; Tue, 3 May 2022 10:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id AA3496B0088 for ; Tue, 3 May 2022 10:03:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 6807760566 for ; Tue, 3 May 2022 14:03:25 +0000 (UTC) X-FDA: 79424599170.11.1AD1B59 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf01.hostedemail.com (Postfix) with ESMTP id CEB5E40088 for ; Tue, 3 May 2022 14:03:16 +0000 (UTC) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Kt1rp48Bmz9sT9; Tue, 3 May 2022 16:03:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RhOOOXYqV50a; Tue, 3 May 2022 16:03:22 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Kt1rp30xWz9sT8; Tue, 3 May 2022 16:03:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4DB408B77B; Tue, 3 May 2022 16:03:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id VIfoSnOpUyFD; Tue, 3 May 2022 16:03:22 +0200 (CEST) Received: from [192.168.202.20] (unknown [192.168.202.20]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2975E8B763; Tue, 3 May 2022 16:03:21 +0200 (CEST) Message-ID: <8e1e4a9c-6ef8-a1a7-ad1f-84b5bf2a0b7d@csgroup.eu> Date: Tue, 3 May 2022 16:03:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [next] powerpc: multiple definition of `____cacheline_aligned'; sound/core/oss/pcm_oss.o:(.bss+0x40): first defined here Content-Language: fr-FR From: Christophe Leroy To: Naresh Kamboju , Linux-Next Mailing List , open list , linuxppc-dev , lkft-triage@lists.linaro.org, Peter Collingbourne , Andrew Morton , "linux-mm@kvack.org" Cc: Stephen Rothwell , Baoquan He , Heiko Carstens , Matthew Wilcox , aul Mackerras , Christoph Hellwig References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CEB5E40088 X-Stat-Signature: mbrz94wa6b48nmgqoc41dy8bnhe9sc9i X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=none X-HE-Tag: 1651586596-600849 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 03/05/2022 à 15:10, Christophe Leroy a écrit : > > > Le 29/04/2022 à 16:45, Naresh Kamboju a écrit : >> Following powerpc builds failed on Linux next-20220428 and next-20220429. >> >> Regressions found on powerpc: >>     - gcc-11-ppc64e_defconfig >>     - gcc-10-ppc64e_defconfig >>     - gcc-9-ppc64e_defconfig >>     - gcc-8-ppc64e_defconfig >>     - clang-14-ppc64e_defconfig >>     - clang-nightly-ppc64e_defconfig >>     - clang-13-ppc64e_defconfig >> >> >> Build error: >> ------------- >> Error: Section .bss not empty in prom_init.c >> make[3]: *** [arch/powerpc/kernel/Makefile:191: >> arch/powerpc/kernel/prom_init_check] Error 1 >> make[3]: Target '__build' not remade because of errors. >> make[2]: *** [scripts/Makefile.build:595: arch/powerpc/kernel] Error 2 >> make[2]: Target '__build' not remade because of errors. >> make[1]: *** [Makefile:1996: arch/powerpc] Error 2 >> powerpc64le-linux-gnu-ld: sound/core/oss/pcm_plugin.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/oss/pcm_oss.o:(.bss+0x40): first defined here >> make[4]: *** [scripts/Makefile.build:530: >> sound/core/oss/snd-pcm-oss.o] Error 1 >> make[4]: Target '__build' not remade because of errors. >> make[3]: *** [scripts/Makefile.build:595: sound/core/oss] Error 2 >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_clientmgr.o:(.bss+0x900): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_memory.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_queue.o:(.bss+0x140): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_fifo.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_timer.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_system.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_ports.o:(.bss+0x0): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> powerpc64le-linux-gnu-ld: sound/core/seq/seq_info.o:(.bss+0x40): >> multiple definition of `____cacheline_aligned'; >> sound/core/seq/seq_lock.o:(.bss+0x0): first defined here >> make[4]: *** [scripts/Makefile.build:530: sound/core/seq/snd-seq.o] >> Error 1 >> make[4]: Target '__build' not remade because of errors. >> >> >> Reported-by: Linux Kernel Functional Testing >> >> >> steps to reproduce: >> ------------------- >> # To install tuxmake on your system globally: >> # sudo pip3 install -U tuxmake >> >> tuxmake --runtime podman --target-arch powerpc --toolchain gcc-11 >> --kconfig ppc64e_defconfig >> >> -- >> Linaro LKFT >> https://lkft.linaro.org >> >> [1] https://builds.tuxbuild.com/28Sn15hB2la1PweieGMLrUdbFMQ/ > > Bisected to: > > 366e7b61ca1f115d38138236467068d8aacabcbc is the first bad commit > commit 366e7b61ca1f115d38138236467068d8aacabcbc > Author: Peter Collingbourne > Date:   Fri Apr 29 14:42:51 2022 -0700 > >     printk: stop including cache.h from printk.h > >     An inclusion of cache.h in printk.h was added in 2014 in commit >     c28aa1f0a847 ("printk/cache: mark printk_once test variable >     __read_mostly") in order to bring in the definition of > __read_mostly.  The >     usage of __read_mostly was later removed in commit 3ec25826ae33 > ("printk: >     Tie printk_once / printk_deferred_once into .data.once for reset") > which >     made the inclusion of cache.h unnecessary, so remove it. > >     We have a small amount of code that depended on the inclusion of > cache.h >     from printk.h; fix that code to include the appropriate header. > >     This fixes a circular inclusion on arm64 (linux/printk.h -> > linux/cache.h >     -> asm/cache.h -> linux/kasan-enabled.h -> linux/static_key.h -> >     linux/jump_label.h -> linux/bug.h -> asm/bug.h -> linux/printk.h) that >     would otherwise be introduced by the next patch. > >     Build tested using {allyesconfig,defconfig} x {arm64,x86_64}. > >     Link: > https://linux-review.googlesource.com/id/I8fd51f72c9ef1f2d6afd3b2cbc875aa4792c1fba > >     Link: > https://lkml.kernel.org/r/20220427195820.1716975-1-pcc@google.com >     Signed-off-by: Peter Collingbourne >     Cc: Alexander Potapenko >     Cc: Andrey Konovalov >     Cc: Andrey Ryabinin >     Cc: Catalin Marinas >     Cc: David Rientjes >     Cc: Dmitry Vyukov >     Cc: Eric W. Biederman >     Cc: Herbert Xu >     Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> >     Cc: Joonsoo Kim >     Cc: Kees Cook >     Cc: Pekka Enberg >     Cc: Roman Gushchin >     Cc: Vlastimil Babka >     Signed-off-by: Andrew Morton > >  arch/arm64/include/asm/mte-kasan.h | 1 + >  arch/arm64/include/asm/percpu.h    | 1 + >  arch/csky/include/asm/processor.h  | 2 +- >  drivers/firmware/smccc/kvm_guest.c | 1 + >  include/linux/printk.h             | 1 - >  kernel/bpf/bpf_lru_list.h          | 1 + >  6 files changed, 5 insertions(+), 2 deletions(-) I think you need to fix all files that use ____cacheline_aligned without including linux/cache.h You can locate them with: git grep -L linux/cache.h `git grep -l ____cacheline_aligned ` Christophe