From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DF2C3ABDA for ; Wed, 14 May 2025 09:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8C06B0111; Wed, 14 May 2025 05:13:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949A36B0113; Wed, 14 May 2025 05:13:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4F76B0114; Wed, 14 May 2025 05:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5C2D16B0111 for ; Wed, 14 May 2025 05:13:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BBB7B1A0A56 for ; Wed, 14 May 2025 09:13:33 +0000 (UTC) X-FDA: 83440950306.03.5C89CC7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 7974680009 for ; Wed, 14 May 2025 09:13:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bEl1Gf5v; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nwvSBOrm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Cq72lhzG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tCmuaFQg; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747214011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IJzDrZLzl0GAfPyXpLtIqKtYKjkB62YGWcSeN006vHk=; b=7bi24vbobU7txyRUDDF1kLnIZq8mvUWCugVMYsudjNc6yyiLehfE8reyXRZQ36J5SSc00o KtYBDnVBHfAINSPb1AOQFwCAGnNeZH1TJda48UjMNbFM22WSX9KjZ7Yq41c3Oe9v5dui5L b6Xqq9yK7gyJiJWoS7rlMzhxfTTFE08= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747214011; a=rsa-sha256; cv=none; b=xOEHSySKFlX+7EhU9Oo2vQ/iNaztk0AB6jlJdjBgVmX89LXTRdfD9iBUL4+ONktNryfuAI HpnJFcMJ3uLW76Lxxz2b9EvJvgGvyPbeCC9YapCB1/B7phdWrM4gy0PDsBp/ozojPV6cg6 ER0F7baGip61CfKS7bTOye6ldinNt+Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bEl1Gf5v; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nwvSBOrm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Cq72lhzG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tCmuaFQg; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 619AF1F455; Wed, 14 May 2025 09:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747214009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJzDrZLzl0GAfPyXpLtIqKtYKjkB62YGWcSeN006vHk=; b=bEl1Gf5vMzoW9w/RxKz7jsH1lSM2aHfdI5U/pXt3hgqp1KefKLXMTlsA13FPuvDCQWbaxa BL47D6iLzqOGwpP8T2ElMsRyscv2wU7zvur0Uwtp3XElvuU8gxCPJEXUGnGp29Dz8FWMh+ Ep+nHRDcoByE9x5uBGUfGVO/Ehsu81w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747214009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJzDrZLzl0GAfPyXpLtIqKtYKjkB62YGWcSeN006vHk=; b=nwvSBOrmxl/LGpG5yITjUvoH8OxYyE+rUnKD3ugEpQfzsFRhA5f2ccdSDLdoAR2OtW3no2 dGvU5PgK4fqdRgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747214008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJzDrZLzl0GAfPyXpLtIqKtYKjkB62YGWcSeN006vHk=; b=Cq72lhzGbBW2QBWBijcCbYFFzRnKmRnDPomsIRwrLGtBjNfqFjavbOPNuQsv/HhNBKL+49 oRvgFR4RZlBTyeojT8a9rBpar/Ues7wYdSjZM6cPTSIfUYbyOD4eEsKB0cj+QuHBe69KX1 9iAeTXraf0CKhxyucl/PRkubTfH/moA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747214008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJzDrZLzl0GAfPyXpLtIqKtYKjkB62YGWcSeN006vHk=; b=tCmuaFQg24TDWQ/gg5VCK6pSMVIlUoOElC66m8lfe8VgK7I3/fJZI5WJi9A/Wey4o5d5jQ u0NmFuTgk9u7vlAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3AD50137E8; Wed, 14 May 2025 09:13:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mlXdDLheJGgAJAAAD6G6ig (envelope-from ); Wed, 14 May 2025 09:13:28 +0000 Message-ID: <8e13926d-b685-4802-a207-ade2001cb657@suse.cz> Date: Wed, 14 May 2025 11:13:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove WARN_ON_ONCE() in file_has_valid_mmap_hooks() Content-Language: en-US To: Lorenzo Stoakes , David Hildenbrand Cc: Andrew Morton , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: <20250514084024.29148-1-lorenzo.stoakes@oracle.com> <357de3b3-6f70-49c4-87d4-f6e38e7bec11@redhat.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7974680009 X-Stat-Signature: cmarqjosush8ffpg6edqzmqr91m5d3f9 X-Rspam-User: X-HE-Tag: 1747214011-50108 X-HE-Meta: U2FsdGVkX18TJDA0Id9LCcAi927CP6lHjuEiQcUy/s08twkelw2YQp48PJvZhAGVlcjnEaoAzxF9BcRaFbCseXU7u5zVhSCG4DgvXvwzdmeCoR4qNciQXTdp0XaBqnnWxObjs3A4Hd42x0FxInM68H+HJZIGBsPeLKb9RiywlMnXoR5alGJjqRXIHeBGiwik4/clKOVLL4IxF9jnyC7pOUYCzIJaVPABhyB02qCFqTvj1LP/5GAioHjT9A3C9WclHez/eQ5BSkgT8TEtAvkinPZ62sxjIxEMoq8xcDisjVa9tJfGxqyKAb3Run95GaZxd3yyn5ySvIZ8hJ65AbS20EuNPT76VEGG67jVVdkkauJnGrAHIU8tCsXKk2HnQjIoCAj/Ay65regAkDwiD95y06cI4YU1/ogV2ERvEYo7p8mj0GVtoSTFDj4qELva5KmKmxkjNxSJM6f6ttJ+WzNFJdEPjwF7vJTymk9WpHK9C81A4OOZC7gjErmdKxMTX4YpuMDfI3maO1lKnnMG+usfaQ7JwQi4Vbb2nYR/pxoxvFzgaGGyw4MNdpx8Cl2jqfelBUMTpH0tygHBP+AfP6mhwh3ngeI/nrqBKI5SNWzKjMUe8wr36lgU1uvF5wedDZvP0MPeRuIoy2KIEUkTr9stnwQ6u4SYrH/VhHnlMn0jdVshSa+qGGdOGnFK1XViSze+K6NLzh/6A4tCc4W0AZ/WG62MpaGD9F3AqfpPEOT5CwaBr95EHjU0bIiQZif/yZe64B9h/YR40qaPC+hiG78wKlh5w8z4nPfp5BCKeCEqR41RFnTpCU6uSwmGCCEFYFIdSzeAyYtm+nPHbxbQ720SKVRsTfjj71SEUeXKZ0oZM1npLH3YNcKQogrnl/Gfydluvuv1Uz6FBpKy+ce//6KW7Bpi6W7XmnAzBwipCkzwG+WIKQhPWTMDK0qnVPEB25IYH0Os+e3M6cbNfDLzG24 c/UW7IP/ 07e4wFa1mQGt+WVs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/14/25 10:56, Lorenzo Stoakes wrote: >> Fixes: c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file callback") Ah yeah I missed there wasn't one. > Is it worth having a fixes tag for something not upstream? This is why I > excluded that. I feel like it's maybe more misleading when the commit hashes are > ephemeral in a certain branch? Yeah it can be useful, in case the fixed commit gets backported somewhere, tools can warn that there's a follow up fix. As mm-stable hashes should not be ephemeral, then this should remain valid (and if there's a rebase for some reason then the fix could be squashed). >> >> Acked-by: David Hildenbrand > > Thanks! > >> >> -- >> Cheers, >> >> David / dhildenb >>