From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0551BC433ED for ; Tue, 18 May 2021 10:06:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 943A061184 for ; Tue, 18 May 2021 10:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 943A061184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 32A698D000D; Tue, 18 May 2021 06:06:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EBB68D0001; Tue, 18 May 2021 06:06:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D480C8D000D; Tue, 18 May 2021 06:06:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 95C908D0001 for ; Tue, 18 May 2021 06:06:51 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2DDB2181AF5F7 for ; Tue, 18 May 2021 10:06:51 +0000 (UTC) X-FDA: 78153923022.34.DB981BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 5B6B46000108 for ; Tue, 18 May 2021 10:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621332410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dFkmeu2athwSt2LK0RUUi/E/grHFe/dKRRuvCpK8qJo=; b=gxDyXub6E2FHAH1ajjW9AsFdwlgRX02dDz2k9SIJUhNnhs8kEEdOL9xHfOn6x+J0u1zTUm EEAUAASgibvrepcVITsh7+Vu/UxUNy6+cEaQNV/s1OWRJ7xvXIPZ3sdwq5s9DBeCa4vv4B Oy9NFaQJ+NaaYac5negNVDJFgnmgChg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-9FnKeswMNN2b3Nf_kwTIjA-1; Tue, 18 May 2021 06:06:46 -0400 X-MC-Unique: 9FnKeswMNN2b3Nf_kwTIjA-1 Received: by mail-wm1-f70.google.com with SMTP id 12-20020a1c010c0000b0290176491efde9so376442wmb.4 for ; Tue, 18 May 2021 03:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dFkmeu2athwSt2LK0RUUi/E/grHFe/dKRRuvCpK8qJo=; b=Bjmn5xpEBNyiuWpe5eK8bBO0L+FdSPEB5gPvKneWO1XEx8AkXxHZ0aE6GwPT6biNTS a7nkly8axAQmPUcvFEeOFJtmgW1dxTP5WdInar3j43YYk4Ey1bxksMJ0xmkvBtm/gaoG HL7XDGyIeI6RoceBDfZPw8ywDRRmshG2aY0HrUcszm7WErd5BFsD5Hc3VOFOuXg1AR/A BdavCsEGI1XcbQ9GEeyLQ5qsdLVsThWVZIv+Ob42b0kk0uSz0GffbUhJf7jHU3lLx1JA EQgsSYPj0MUb5htd+k7EDlmojeQG5clCzdotudCJ420f4cjiAfGLrldbtFskZV2pPOEh 0w8w== X-Gm-Message-State: AOAM530pgXIt66Kp1FuNOjiV9gTKpip2UAPV4W2tel8xaEvRqLf8DYbY B3xpDCYD8R1K6RQpwnTd/5jKRNOtIQswA0F2X/agIOfNc7ypwdp9qQTQyp1zcTx0O8B6FpIEhym tXc3JAMwlpfg= X-Received: by 2002:a05:6000:1ac5:: with SMTP id i5mr5879814wry.6.1621332405353; Tue, 18 May 2021 03:06:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiVxI2VqHM3UC3HkCv7YVP9ChZhf/paSvmhTbK/1R/b2aClM7EAkaKYj9OwIH5AzvG3tEX6Q== X-Received: by 2002:a05:6000:1ac5:: with SMTP id i5mr5879787wry.6.1621332405164; Tue, 18 May 2021 03:06:45 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64fd.dip0.t-ipconnect.de. [91.12.100.253]) by smtp.gmail.com with ESMTPSA id f14sm8395872wry.40.2021.05.18.03.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 03:06:44 -0700 (PDT) Subject: Re: [PATCH v19 5/8] mm: introduce memfd_secret system call to create "secret" memory areas To: Michal Hocko , Mike Rapoport Cc: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , Elena Reshetova , "H. Peter Anvin" , Hagen Paul Pfeifer , Ingo Molnar , James Bottomley , Kees Cook , "Kirill A. Shutemov" , Matthew Wilcox , Matthew Garrett , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , Yury Norov , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org References: <20210513184734.29317-1-rppt@kernel.org> <20210513184734.29317-6-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <8e114f09-60e4-2343-1c42-1beaf540c150@redhat.com> Date: Tue, 18 May 2021 12:06:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gxDyXub6; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: py3p65d34z9o1r71kda79zweqpp8jgnk X-Rspamd-Queue-Id: 5B6B46000108 X-Rspamd-Server: rspam02 X-HE-Tag: 1621332408-61794 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.05.21 11:59, Michal Hocko wrote: > On Sun 16-05-21 10:29:24, Mike Rapoport wrote: >> On Fri, May 14, 2021 at 11:25:43AM +0200, David Hildenbrand wrote: > [...] >>>> + if (!page) >>>> + return VM_FAULT_OOM; >>>> + >>>> + err = set_direct_map_invalid_noflush(page, 1); >>>> + if (err) { >>>> + put_page(page); >>>> + return vmf_error(err); >>> >>> Would we want to translate that to a proper VM_FAULT_..., which would most >>> probably be VM_FAULT_OOM when we fail to allocate a pagetable? >> >> That's what vmf_error does, it translates -ESOMETHING to VM_FAULT_XYZ. > > I haven't read through the rest but this has just caught my attention. > Is it really reasonable to trigger the oom killer when you cannot > invalidate the direct mapping. From a quick look at the code it is quite > unlikely to se ENOMEM from that path (it allocates small pages) but this > can become quite sublte over time. Shouldn't this simply SIGBUS if it > cannot manipulate the direct mapping regardless of the underlying reason > for that? > OTOH, it means our kernel zones are depleted, so we'd better reclaim somehow ... -- Thanks, David / dhildenb