From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0318AC61CE7 for ; Wed, 11 Jun 2025 12:39:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7222F6B0095; Wed, 11 Jun 2025 08:39:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F9F86B0096; Wed, 11 Jun 2025 08:39:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636806B0098; Wed, 11 Jun 2025 08:39:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 496356B0095 for ; Wed, 11 Jun 2025 08:39:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC34B140B82 for ; Wed, 11 Jun 2025 12:39:23 +0000 (UTC) X-FDA: 83543075406.07.80019B3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 1DAEB14000C for ; Wed, 11 Jun 2025 12:39:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AXro1T9M; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749645562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=feNV7mDhCXxpnLNPF1K/+/G/P2pKIRgWT41OaTtc2Rk=; b=YZt5BtM2GUTzpXyL6Y899Tjo/jKhQe3rkluoLwpIquKLUD3CEq/I3g/bRJs+wgRhRIt86E ZnVh6CgZSWUgjFpwVew8DI3mhABEchCQq6jhpgpt5sqS0GWHf/mdc0ekNDRYlN5MtTJcuA aIHm0i7YIRy/zWeDlLR2NYx/ExHSi10= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AXro1T9M; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749645562; a=rsa-sha256; cv=none; b=duotxusJwuVKtBMadh9zfYapma1dFAX7oa+VVlhG3TdlFGAbE1UlR4Tca4C2wox73GpmhT MJcmDD+atSDFpObJVcuvkn7HJmqYDoHU761EONDk48u4dPbcg0118vJMX/nOLqJpjFw03K G//hfy6EXLgqX9f/x2MP76wymnaubOk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7B5D2A515F1; Wed, 11 Jun 2025 12:39:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38EC7C4CEEE; Wed, 11 Jun 2025 12:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749645561; bh=9KX26X6GW1iDgQ0uSkq3rTN6B5rLbx1VT6lq75S/Ju4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AXro1T9MJsigbHNSEuxgL2sFTPDsDUHWbLpWjpRp/479aLPglyUWKoVWGL/V8rstx ZtVTuA6nzw1vRPLfqwbqn5ATn8Efg+WpEXJODoxIkclTw8TnDEVAZnsIokjnRShCwO mv4WxISp2tQD4HitAvAxpuULQaswpuYuaIYhIYuRo1i8/t2v9TQaPald1PG7814ctT Ijmor/B5u8gASr60MkP+0CqbSiycXNU+buRQGOj/15hz8qxPzHl0wwHxLEszEZWpbn RlKaeoG+nACzUfbfqPMg3UBQLda1oHgBKQn9xSHvANQMYRqHUsRoTGtCW/BRujFc6Z 8VhtzIzn3Q5NQ== Date: Wed, 11 Jun 2025 13:39:14 +0100 From: Mark Brown To: Dev Jain Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, vbabka@suse.cz, jannh@google.com, pulehui@huawei.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, aishwarya.tcv@arm.com, ryan.roberts@arm.com Subject: Re: [PATCH] selftests/mm: Add CONFIG_FTRACE to config Message-ID: <8e0925e3-70ae-4b00-9f70-3a0325fd1fae@sirena.org.uk> References: <20250611121011.23888-1-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ZM+5O2byLW1Q9hb" Content-Disposition: inline In-Reply-To: <20250611121011.23888-1-dev.jain@arm.com> X-Cookie: No skis take rocks like rental skis! X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1DAEB14000C X-Stat-Signature: sgdb1nexzssfrfu3qtwjwhzcoq1amti8 X-Rspam-User: X-HE-Tag: 1749645562-247913 X-HE-Meta: U2FsdGVkX1/L6WK4Qjn167UUOi5x+0hl8QY0TnZaXqm0LXCq9+Ha/2dV/zFxvuJmKg18FD596S89uJ11AGJBvQfNBs3RBlDsgArp8p2R8vXmHMiWctcZYjv03RRTMP3XizRjKPXSFf0FWkt4OpcNErkrm2q0/l3gL27mi+e2bqR/DNSlJczZ4nGXCCgx/fOzB0PFJT20eluL/Cm+EqA6qQcOIRNBF3MZqf99hOYDChocWjgaA5XOcTH3P+w+20iyDFxgnIC7GD3dbkZwpQVCuVwfdHZGAVkjcG+jWynSr/XQkLfGq9OxjufFTR5jXM6eRNXgq/IJejOecD+vo2Z+qMieIaMtIAHEq5zQb4wPrqjWBt3Hjod+dx43PUTPEBfJv1tC4o3G+6j0mTSBpkdF60v3VGUIcfJ0ArLwy3+niFv9QeHKq/EWxwtTUS073yykHrsic7yNFEybXIjRfP36tXonkWts3wZIcSWAAgOgkDLJni+Fbk9WpB1NUkqTaCVpKRWson/kqmm8itEuwpXLKqvXESckmULXugXUs4SlwliKPadRhJXYfw/eVH4CXWa4+Xa8DoaylFHnjxUqkWHKHNaBzlzDZqbSBYpU0/uHrobttzNkM5bzGWqjEvzMvAzjzOZSSG2PNTUuFyj6jyz/+kZSFN8Iyr178y6Mm9WrKrIoj4zOhyLFG9sE4wh8IHq5bqYLXd8G9kFVaXM6bzkLfTx5c8xsFWC39TND1eTofaYVZr3kLf9cu8ZmwuQWAVB3UHNB918Jk+Ub84JHOeSeWUANYIWr+EgGII6brlSyDgu1yQxlS43Ey7jAeHjz74EX7n13khfnPzvWn1U/PuNV6Ld/3wiRpDxTHxkOVy/QtOOdIOS0bjcgeONIx6pXEcba/+yhD4EzVlEigZQgp9ZfXiXSYV+uIhr4YF4BRaUUzY/vQx3+C8Ne1bZ/FK6tdpFK0aQfHjdKuJnBRFcyvKg uWjFDwV7 ggOl4VXGiBvrHUuwjsE6z/iBiv6xCUwrNNowm/v92w8mWpZIkKz1gL9l/qSWdQ8DqkcwGir8eX+bJj9L+AaQF2jZyiONMfnXcnlBAvBgGScF/7SMCAElqNfTUxsgD7stMjGOdlYCHcMTcQoQtII+GeGXvhny5NcCpooTqO9NIWJxlh/Tsru1M89MOP3P1Aljir8MnSDphC2vgEMFSePnj6qX98olDlyc7WF3HT2nuMB1yllN2rN691zwvJh4vdNx0P52NI94IZUiVgdY0ZGN/B3FfGHGYlBWPmi8DIfdjEJBcOqwTUFe++SXNG0L169pox2Rqq/KQccYGav3ZyA87igijqfat8vDmGaR/fU9XEUUIhjQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --5ZM+5O2byLW1Q9hb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 11, 2025 at 05:40:11PM +0530, Dev Jain wrote: > If CONFIG_UPROBES is not set, a merge subtest fails: ... > CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by > CONFIG_FTRACE. Therefore add this config to selftests/mm/config so that > CI systems can include this config in the kernel build. > +++ b/tools/testing/selftests/mm/config > @@ -8,3 +8,4 @@ CONFIG_GUP_TEST=y > CONFIG_TRANSPARENT_HUGEPAGE=y > CONFIG_MEM_SOFT_DIRTY=y > CONFIG_ANON_VMA_NAME=y > +CONFIG_FTRACE=y If we need UPROBES we should enable UPROBES explicitly, otherwise it looks like we're just randomly enabling FTRACE even though it's not used itself. If it's a dependency for UPROBES and we also enable UPROBES that's a bit more obvious. --5ZM+5O2byLW1Q9hb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhJePEACgkQJNaLcl1U h9DvZgf/bnaXT1vKg3ySOPSt6xSQ2LQKI6wkepKnc8XCT9rre3fbml1vBkMXBpGd 6XPDGIcOMnNBqJDSyl7XYHglAjW2Lj3KGtx8sCwbT9SR/nHX7NkE6wRucOFrNa65 uNZ/I3gvRyHiqo+Lf9Clr/1wwMlnBseWU7lBaXQJy+3qpxUkNoan5jN/xS/1/gRM rgan9gRVyqxItL0y6o86mVV1dYJ11KDAKdfYDVv91y1czM875jQJFhU6fDs3qpo+ 81bIhyqtkaeCePqo9Llas/R2oVvLZvyqVEdCfSvmL/QLg5sf4z/KhT98rBsn2XRB Gi2Q5Tt5b3UIjFhve/MuAc+m7KwVoA== =tUEy -----END PGP SIGNATURE----- --5ZM+5O2byLW1Q9hb--