From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A650C5321E for ; Mon, 26 Aug 2024 06:32:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 283938D0040; Mon, 26 Aug 2024 02:32:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 232248D0029; Mon, 26 Aug 2024 02:32:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FAD88D0040; Mon, 26 Aug 2024 02:32:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E78768D0029 for ; Mon, 26 Aug 2024 02:32:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D516A1A0B1E for ; Mon, 26 Aug 2024 06:32:37 +0000 (UTC) X-FDA: 82493427954.25.32BB23D Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf06.hostedemail.com (Postfix) with ESMTP id 1F668180005 for ; Mon, 26 Aug 2024 06:32:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724653936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yHAvV4oWvU3p70A5+nymU1WLz1Ofbf8VeLnZgizOasc=; b=LUP4qdox4+zjzzrUSufKsru80uOT6yTFpq6ZXDzMKlgoKf6PIt16VpayFt7LPjxGud7WPQ aRHhCg1WUgNyXIv++NyVmyQoxlvxSOUMsNrJf0X29JpiR4oXHe68gohJwL4y8cwBHCd9HF 4j6IWMqOI75o2ogqxU/dF4LpEurQF+4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724653936; a=rsa-sha256; cv=none; b=ixfyhiAx3L6FwFVh4wo4hU3fjb1sNobEY7DsAd+xw/V/nAcHfu3Je5kiYf97mAAWwjwcpF i0iwb4CKbHM6hJCDTYXZ5dRVmVbmrDJMzIFWKZpOsBjaN+yNB8vNIXvD557iqHO7YOux0d O9NE0+r1UhDJ371Cubs/0v7f2B10yPs= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Wsghc2ty5z20mgm; Mon, 26 Aug 2024 14:27:44 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 57C3B18002B; Mon, 26 Aug 2024 14:32:31 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 26 Aug 2024 14:32:30 +0800 Subject: Re: [PATCH v2] codetag: debug: mark codetags for poisoned page as empty To: Hao Ge , , CC: , , , , , , Hao Ge , References: <20240825163649.33294-1-hao.ge@linux.dev> From: Miaohe Lin Message-ID: <8e052e52-4c8e-279c-bcd4-3c4cd1325bdf@huawei.com> Date: Mon, 26 Aug 2024 14:32:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240825163649.33294-1-hao.ge@linux.dev> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspam-User: X-Stat-Signature: 6k78j6cqfeijmbtnhruq7fzs9exwerqk X-Rspamd-Queue-Id: 1F668180005 X-Rspamd-Server: rspam11 X-HE-Tag: 1724653954-145855 X-HE-Meta: U2FsdGVkX19Z/G3F8rCuc+Ar6lyV6Czz5f/tOHIgtDjpnifROGbOTxp3SponjAPUDljr8fbTTGic/EBSlUv4eB7sYTq3iaWFUHvPH0sc5bs4Du6mlQuqdd1mKL2EURdsQee5etaSUKCX9bjwhU1mAiWNG81lv3iJnG4kKvZn7frFdQkrKdtOBZlRr30QSXK8BakeggMjOzXS6pLO3OA4sRSzj4FkoIzrCNHxCAfq4kZB8A7P1oi4XfEZHIK7fL3xi0bN8cHdWGMXISC1IdOGca+DKm1FY2+wqh22EFt4RHS5lzcpS5gGbpL+CFnlacr9q/F5kGuzyXBv38Sa+xwPf0cI71fUeS5+E9GL/PaoKihc5Mx8S5Kq9GabuLQsXEKH2SDqHzsGUeObtPhSfebz0JI69Lpr3+N9Rc+xLIoo0qC/X8JcF3LfauByLP+c4X7z+i9Rwg5YRfgc1fg8q5ErJTqELOGJgG3pmaMvRayMrD/i9LbTqVzm4irMmCUiiKV7AAy7jkQhuvXWdU3X+hU5/RPruBtqLli2D0LbgdONsykGYYol5FR1j7hixTV7IHLcXxZejq8Xefmg44KpMzpXomOxyqt6IUTsMLmARGv5DYXcv4qhb621vcKVSnIP9ctET20crcrcnwj5OhhNG4Ry/pGKlaS42GUVZSm+PXXnfW+Q+Bh9KTBS5EvWCNUnsbcFQJQM0/phc6ijxvL1n3wnicZd8Ifv21i6B1LCjI588VNByKzPdJfno3lJnxWzUnu4XWHGzr0fsT1fE8CE8VZWdIm4dBCCPWZ+mBXXtqjV5zLqMV3ZGAVSyVLGhEhYJTtWa05bADQkI+cyVXVovpYsEC9HpdlxZ2CQIV6PGkrRyKMCZL+X2Bx3kB0dW1Zb6QY3MkvlfLH6Gx4k6KHZCSXSNq3r6gw5uqkG5CplDOKxo6sREjLopVKzrCBEP5I9qedcAYlWswYqYlAJmPQStdl V7Jepbdo 8MBaYu7oTp9qiTMzZQrxPm/rB66pvuHJ76o5PLxRcPRnwR1KZiFCsAXSnEQik9O0PMHZ3YzY/vpyNwQBU1RGT+QefMg8r638w28n53NO+2yNRhjRgZKcTu+cMzSZdnenNbAyDGMMrxli3xmC9maUtOjvhubmv5QWqPN8BLRHHEZTWOBjyu6dSr51a8dcoafA2Mq+p+J2ky+V7Fkuq/PlpPgJGU1uJnl1ExfRR58UZbtFheNH3rQJs6B6iuL9hUQfQHFJ0Bxe5NnZW8O7hWlaHK/WBkFDnccKqeXe8E6D+9q4g6wzHPrswfT6N360PuWnArtuTbJyBgypRfmfGFhi/VzhGGsSpTTJmKKU1NvCN4An05LyCLRTh3h2iFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/26 0:36, Hao Ge wrote: > From: Hao Ge > > When PG_hwpoison pages are freed,they are treated differently in > free_pages_prepare() and instead of being released they are isolated. > > Page allocation tag counters are decremented at this point since the > page is considered not in use. Later on when such pages are released > by unpoison_memory(), the allocation tag counters will be decremented > again and the following warning gets reported: > > [ 113.930443][ T3282] ------------[ cut here ]------------ > [ 113.931105][ T3282] alloc_tag was not set > [ 113.931576][ T3282] WARNING: CPU: 2 PID: 3282 at ./include/linux/alloc_tag.h:130 pgalloc_tag_sub.part.66+0x154/0x164 > [ 113.932866][ T3282] Modules linked in: hwpoison_inject fuse ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_conntrack ebtable_nat ebtable_broute ip6table_nat ip6table_man4 > [ 113.941638][ T3282] CPU: 2 UID: 0 PID: 3282 Comm: madvise11 Kdump: loaded Tainted: G W 6.11.0-rc4-dirty #18 > [ 113.943003][ T3282] Tainted: [W]=WARN > [ 113.943453][ T3282] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 > [ 113.944378][ T3282] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 113.945319][ T3282] pc : pgalloc_tag_sub.part.66+0x154/0x164 > [ 113.946016][ T3282] lr : pgalloc_tag_sub.part.66+0x154/0x164 > [ 113.946706][ T3282] sp : ffff800087093a10 > [ 113.947197][ T3282] x29: ffff800087093a10 x28: ffff0000d7a9d400 x27: ffff80008249f0a0 > [ 113.948165][ T3282] x26: 0000000000000000 x25: ffff80008249f2b0 x24: 0000000000000000 > [ 113.949134][ T3282] x23: 0000000000000001 x22: 0000000000000001 x21: 0000000000000000 > [ 113.950597][ T3282] x20: ffff0000c08fcad8 x19: ffff80008251e000 x18: ffffffffffffffff > [ 113.952207][ T3282] x17: 0000000000000000 x16: 0000000000000000 x15: ffff800081746210 > [ 113.953161][ T3282] x14: 0000000000000000 x13: 205d323832335420 x12: 5b5d353031313339 > [ 113.954120][ T3282] x11: ffff800087093500 x10: 000000000000005d x9 : 00000000ffffffd0 > [ 113.955078][ T3282] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008236ba90 x6 : c0000000ffff7fff > [ 113.956036][ T3282] x5 : ffff000b34bf4dc8 x4 : ffff8000820aba90 x3 : 0000000000000001 > [ 113.956994][ T3282] x2 : ffff800ab320f000 x1 : 841d1e35ac932e00 x0 : 0000000000000000 > [ 113.957962][ T3282] Call trace: > [ 113.958350][ T3282] pgalloc_tag_sub.part.66+0x154/0x164 > [ 113.959000][ T3282] pgalloc_tag_sub+0x14/0x1c > [ 113.959539][ T3282] free_unref_page+0xf4/0x4b8 > [ 113.960096][ T3282] __folio_put+0xd4/0x120 > [ 113.960614][ T3282] folio_put+0x24/0x50 > [ 113.961103][ T3282] unpoison_memory+0x4f0/0x5b0 > [ 113.961678][ T3282] hwpoison_unpoison+0x30/0x48 [hwpoison_inject] > [ 113.962436][ T3282] simple_attr_write_xsigned.isra.34+0xec/0x1cc > [ 113.963183][ T3282] simple_attr_write+0x38/0x48 > [ 113.963750][ T3282] debugfs_attr_write+0x54/0x80 > [ 113.964330][ T3282] full_proxy_write+0x68/0x98 > [ 113.964880][ T3282] vfs_write+0xdc/0x4d0 > [ 113.965372][ T3282] ksys_write+0x78/0x100 > [ 113.965875][ T3282] __arm64_sys_write+0x24/0x30 > [ 113.966440][ T3282] invoke_syscall+0x7c/0x104 > [ 113.966984][ T3282] el0_svc_common.constprop.1+0x88/0x104 > [ 113.967652][ T3282] do_el0_svc+0x2c/0x38 > [ 113.968893][ T3282] el0_svc+0x3c/0x1b8 > [ 113.969379][ T3282] el0t_64_sync_handler+0x98/0xbc > [ 113.969980][ T3282] el0t_64_sync+0x19c/0x1a0 > [ 113.970511][ T3282] ---[ end trace 0000000000000000 ]--- > > To fix this, clear the page tag reference after the page got isolated > and accounted for. > > Fixes: d224eb0287fb ("codetag: debug: mark codetags for reserved pages as empty") > Cc: stable@vger.kernel.org # v6.10 > Signed-off-by: Hao Ge Reviewed-by: Miaohe Lin Thanks. .