From: David Hildenbrand <david@redhat.com>
To: Wang Jinchao <wangjinchao@xfusion.com>,
Oscar Salvador <osalvador@suse.de>,
Jonathan Corbet <corbet@lwn.net>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: xulei <stone.xulei@xfusion.com>
Subject: Re: [PATCH] memory-hotplug.rst: fix wrong /sys/device/ path
Date: Fri, 22 Sep 2023 09:33:59 +0200 [thread overview]
Message-ID: <8df8d6dd-d0fc-908e-77c7-a67167e1c74f@redhat.com> (raw)
In-Reply-To: <ZQz1NUATBMOb3RT+@fedora>
On 22.09.23 04:00, Wang Jinchao wrote:
> Actually, it should be /sys/devices/
>
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index cfe034cf1e87..01595965734a 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -250,15 +250,15 @@ Observing the State of Memory Blocks
> The state (online/offline/going-offline) of a memory block can be observed
> either via::
>
> - % cat /sys/device/system/memory/memoryXXX/state
> + % cat /sys/devices/system/memory/memoryXXX/state
>
> Or alternatively (1/0) via::
>
> - % cat /sys/device/system/memory/memoryXXX/online
> + % cat /sys/devices/system/memory/memoryXXX/online
>
> For an online memory block, the managing zone can be observed via::
>
> - % cat /sys/device/system/memory/memoryXXX/valid_zones
> + % cat /sys/devices/system/memory/memoryXXX/valid_zones
>
> Configuring Memory Hot(Un)Plug
> ==============================
> @@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
> holes cannot be offlined.
>
> For example, assume 1 GiB memory block size. A device for a memory starting at
> -0x100000000 is ``/sys/device/system/memory/memory4``::
> +0x100000000 is ``/sys/devices/system/memory/memory4``::
>
> (0x100000000 / 1Gib = 4)
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-09-22 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 2:00 Wang Jinchao
2023-09-22 7:33 ` David Hildenbrand [this message]
2023-09-22 11:19 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8df8d6dd-d0fc-908e-77c7-a67167e1c74f@redhat.com \
--to=david@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=stone.xulei@xfusion.com \
--cc=wangjinchao@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox