From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B904BC54E60 for ; Wed, 13 Mar 2024 11:23:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14BA780026; Wed, 13 Mar 2024 07:23:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FC6C940010; Wed, 13 Mar 2024 07:23:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDFA280026; Wed, 13 Mar 2024 07:23:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD743940010 for ; Wed, 13 Mar 2024 07:23:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B07E141255 for ; Wed, 13 Mar 2024 11:23:27 +0000 (UTC) X-FDA: 81891780054.07.CC7C28E Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 67540100010 for ; Wed, 13 Mar 2024 11:23:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="hP /L08/"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710329005; a=rsa-sha256; cv=none; b=NHjAW4a80haz4d6DuLDaaoBAHIzrDMpuq6bWABdm97g2DI4nPKNwnC1ZS0WelMOzMP3rCi ZEwdOI98xt+miKTyavzUpBwu6amV9UPvk1iql2Ds9nRllA43ewxFTdeEk0Ei9APBpCxbNZ kZD4n1yjbNLyAYxRm8UXGiqJTnW3gqw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="hP /L08/"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710329005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NQpXNVfH+tJUTwyZ+SqQMBl5k1g/PXORYi/fo/4MB8s=; b=m4tnqPhutBt4JgAKmnaA300i4lBvoOWbyL9LgXPj0ThxhIL+ffFptYQwix4uUCHITQm7w0 WQeR72RfGOBQr9DAjppmL7bpnhn/0YumizTkpskBAIBcEWEpKRDziUnCbaeeAL+TxvCYBm Iy1byvLTyn/mZv+Ivsu8CIEq6RIz6AA= Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42D9v8uR007212; Wed, 13 Mar 2024 11:23:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=NQpXNVfH+tJUTwyZ+SqQMBl5k1g/PXORYi/fo/4MB8s=; b=hP /L08/sno3oCbu0ePSUoxEizITZ4NYhlB81C3yF/mSFDEJ9FX44PPFkXWgrhN7R2p rHVFIVehgAjBKWUaqf/CPt2ilc/MbxmaH2m93RgmJtPD12M+zpPq5cYINjAx4kai 0KStzxe/5WhjbOLg0lbWoaRCB7nln8OUx3WDEFAz6AExCM67rLIPdvYggdxKjjko y757XtBiJJjlKBNDU5qx+jt+QisPVNUmsmreZRqL/RANXfAutqjayTS+kFLYuM/0 BMcSJ0ZqWXSFTHsVovrevNYr9js7W2YJleevIPgDmsHz/FZabIa6QueEuF6FVTAe wxcxSEp4Z7IoDu68q4kA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wu9y3r57y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 11:23:17 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42DBNGeE017532 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 11:23:16 GMT Received: from [10.214.226.177] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 13 Mar 2024 04:23:13 -0700 Message-ID: <8dd12cfc-e5bd-caae-5a32-e1203a478bac@quicinc.com> Date: Wed, 13 Mar 2024 16:53:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH STABLE v6.1.y] mm/migrate: set swap entry values of THP tail pages properly. To: Zi Yan , , CC: , "Matthew Wilcox (Oracle)" , David Hildenbrand , Andrew Morton , Huang Ying , Naoya Horiguchi References: <20240306155217.118467-1-zi.yan@sent.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: <20240306155217.118467-1-zi.yan@sent.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: BQLT4tyFDTUi3-WYfkazEnPF2aXjRTnr X-Proofpoint-GUID: BQLT4tyFDTUi3-WYfkazEnPF2aXjRTnr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_07,2024-03-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 impostorscore=0 adultscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1011 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403130083 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 67540100010 X-Stat-Signature: 6pzhwaxr98ki56687myczapjaph44q56 X-HE-Tag: 1710329005-261807 X-HE-Meta: U2FsdGVkX19wHWxDVs1xRjM98hiuL7X7lsCBSAz6ZvLFHPBIMDVCtr0m3Gm65v7E63b+v4K9M20Ei+Tl9byVtv3qyeRxyW1qjBr7n5hBgFxF+J+or5oNYmPHkCooS0rLYRV+ymJfT12OwVPH2UWOG7nmDGaTCUqJdybwBrSAXq5z/27cR1oAMO0uEKxs0dkvBC3pYnqgLopHLzQ+B0iO4LHOCR/xphhk0AY2wLVUQvUIWOkgW5kJRBH5e8G7SAE0Rwzp2YB3jNN6wqQexD/dgPgGExSLVubkXMT9jquvdc1jzhsiiM0TkYe9tRCQ08i57TE9eN+hDlJoL4b0IgO4f9Eo72WBvtSWj05M/wcg3/nh75SezXG79mebka9qgXEipHd9lDI6tntWKuNczMC0WcS/+vmM0AsFNaAJ9Vqq4ILc4Ka6ZcJKmj/YGP00JqHye8IEGpCQTmmCblo8IaVbX11a/KyRnBvndeiv23JDdP2/RYNnI012mfosY0+iuh4zynZqIQOPN18EufLZ/CbnMsaFa8T7+fu/4rSNBNflfYGhyvkZwryE4RKFJV7ryWfid6bZtatt9LoE12v1ar3e4z5m+QGy3GpxTSXshlUZaUBtgQzdTM16YvUZrude/tNV6xW+HN765A1jx+fX+clBmNZ+qex5fBQXzXlnraw0/gtvkFFubsl4xlyPLgCZF/EmhAVGUrZDMQTt3rKWEE2+ytWQTkeNgW0XFshREH75csmkQp0pTDGYzsR7FODZjrXCIxzmtmLh4HYEe7LGv1GsORGIeic2NSLHI1uca80vJdx2fjq92ntWZH8cL0uNlse8V547xvYL4NzEz37hqWaB4ASZD1eiSqmbvwX4X9OqDoY/3vllEdrluI09sKugTsjn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/2024 9:22 PM, Zi Yan wrote: > From: Zi Yan > > The tail pages in a THP can have swap entry information stored in their > private field. When migrating to a new page, all tail pages of the new > page need to update ->private to avoid future data corruption. > > This fix is stable-only, since after commit 07e09c483cbe ("mm/huge_memory: > work on folio->swap instead of page->private when splitting folio"), > subpages of a swapcached THP no longer requires the maintenance. > > Adding THPs to the swapcache was introduced in commit > 38d8b4e6bdc87 ("mm, THP, swap: delay splitting THP during swap out"), > where each subpage of a THP added to the swapcache had its own swapcache > entry and required the ->private field to point to the correct swapcache > entry. Later, when THP migration functionality was implemented in commit > 616b8371539a6 ("mm: thp: enable thp migration in generic path"), > it initially did not handle the subpages of swapcached THPs, failing to > update their ->private fields or replace the subpage pointers in the > swapcache. Subsequently, commit e71769ae5260 ("mm: enable thp migration > for shmem thp") addressed the swapcache update aspect. This patch fixes > the update of subpage ->private fields. > > Closes: https://lore.kernel.org/linux-mm/1707814102-22682-1-git-send-email-quic_charante@quicinc.com/ > Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") > Signed-off-by: Zi Yan > Acked-by: David Hildenbrand Tested this patch for 6.1 kernel and observed no issues. With that, Reported-and-tested-by: Charan Teja Kalla Thanks, Charan