From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469C5C4345F for ; Thu, 25 Apr 2024 07:37:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A83316B00A7; Thu, 25 Apr 2024 03:37:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A32D26B00A8; Thu, 25 Apr 2024 03:37:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 922AC6B00A9; Thu, 25 Apr 2024 03:37:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70B696B00A7 for ; Thu, 25 Apr 2024 03:37:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1D6D01403F3 for ; Thu, 25 Apr 2024 07:37:24 +0000 (UTC) X-FDA: 82047248808.30.3970C84 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 8FC19100007 for ; Thu, 25 Apr 2024 07:37:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714030642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5a5VIdGGeWLYcwFk8QO6VcgBJgtIapIeF6ebWtB2eXY=; b=zC/o9MtndHxBs2U9ilJ1evDLvw8RKbj6Tj6a1RBjxqP8SxEn18iJXxXPPT27dbEfdgv4+N 2rkGmQy9zq7Zi6G7DYt1y9ybQor3ruFyUeYzfQ/fD1V1/8f3ZPeJfDpRhj6plp7pCrhaY6 sdJ3creTyp0SWyQvhmes8KNFzvoQyCU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714030642; a=rsa-sha256; cv=none; b=LG2vaidawVpjZS7wyn9xIN2BK2qxnStdZeDWcCF4ibX4qPcXM4q61H1YFh/hSooaVSZWbX c93e5qecIbGKFIv2g0IYBTbL6/99A664Vw1NEukry/0EWl9kLvBdPZffsczC+iaM6gu55c 7BxlF682wuUnaNDq0PHzpe80IOjWgQk= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4VQ7052Kn5z1R9P0; Thu, 25 Apr 2024 15:34:13 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id F37C8180A9F; Thu, 25 Apr 2024 15:37:15 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 15:37:15 +0800 Message-ID: <8dc0a47d-0cb1-4e89-8b9a-083921b22f68@huawei.com> Date: Thu, 25 Apr 2024 15:37:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add more readable thp_vma_allowable_order_foo() Content-Language: en-US To: David Hildenbrand , Matthew Wilcox CC: Andrew Morton , Ryan Roberts , References: <20240425035108.3063-1-wangkefeng.wang@huawei.com> <5bf467d3-f596-4986-9e27-f2707efbe6a3@redhat.com> From: Kefeng Wang In-Reply-To: <5bf467d3-f596-4986-9e27-f2707efbe6a3@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 8FC19100007 X-Stat-Signature: h7bz6ah34much5cs6x958axrfzea55em X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1714030640-400123 X-HE-Meta: U2FsdGVkX19nEz+qw43MANqckcyrkiwP0WQamFtRXgMsQygABdq2riiseHQao9ovmwHCLmylA1Gnj2+MDgc75b208hq7A0HHiI8Cwm1dDgT1oQDsmSZHXsF4syfbgQi74eH/oV4J2GS0TtTpjc0vu+z3pvibSScMiw+32MEN8V+1uQ6QVgh4/gfrt8VyOwxqxHNCxmaC3c81Jp7kACICBPnbdqb2UF9AUACo6wBYXJp9KDhBlOxvOyWy0nItrTlitFyVJvnGv2Eo6qM4tFmOOMmtCAjcatj830w89Ph07E3y7gLr+eymSxfM6hUG2XhlMAJUbGYUcinkHper7uvNWE6LUQH7aEK7HFQbZ885Ig93iF3lUyhCLTcATbli7c80enovEbxMk/lU9JXqLM400i0eIdn2peocSTIce4ndniayEOAfO+KfoHWEwUkTquaJbMfcSqNY54FMki965M7gESc+41ciWGRM/ipLJ82G7kk/adaZ8Ds+nAuBW+EGc4ULJDbDXAny5FYK5Wipk4K0eg2+1pfhUGQjJTSBWxsUPiWjRQEA9Yj15QRmiy/Uq8L7x65QkEZbXfE7waY35JKA/4Yi7xzy+Fqnz2wi1PEpPpeBf93BJAIpK4B0kOiAH1y7LfDpnYoqcbT6hG55AODG/ad4mLEsqwbAx0ILTlMNdzn4GM3jxWE//ogKiaUrWC30l4ZFAkdCxzLE1y1i+3S2nsbQliYlO5lO9vmFOv7H7hwyI3xSsr/+THReFPDv393Yg6ohrNwI3coXYGVXvojhH2sAIbwjCY04lcVLkQOujJfTy68W5qPdCesQ5CkTkHBnUyezoEUvtxG6O5SqRv9wLVCNBJ/0UqvRjdGNj2eGIfnRj8nF8Xz7J/Mwq5feXhouzBDX6DhTNzga6Pljk2zDO7Kk45jF4jaPUY3bNsCkr0qRGg6jTDBo4xMFNaj2AbQzeqlxmmcueznqNXA3yAp Wcbp4tJ0 6szVXeItJPPSOXHu59XYFZjK8kWU9Utl7PHnvnYDQFTKvUB5MI3atoW3lgRt/bDz3Rvh6tr0aRWGBAP4vwEhbC1vtqNyq41+QM2PrN4q8cxX8Cm3Zsbz34CaxCKKBFq9sHwQwbmtV4V2qqzwHCZ77AYJ0ppRG/DDBwcHZXMPNGDvyuY4WyNeXAhpZYYe+VoDTP4MzxGksDqF7M4Qf3SqLip202A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/25 15:22, David Hildenbrand wrote: > On 25.04.24 09:18, Kefeng Wang wrote: >> >> >> On 2024/4/25 12:00, Matthew Wilcox wrote: >>> On Thu, Apr 25, 2024 at 11:51:08AM +0800, Kefeng Wang wrote: >>>> There are too many bool arguments in thp_vma_allowable_orders(), adding >>>> some more readable thp_vma_allowable_order_foo(), >>> >>> Here's an alternative approach I came up with and forgot to send out. >>> I take no position on which is better. >> >> Always confuse, either way is fine, even combine the two way, let's see >> Ryan/David's option. > > It's shocking how Willy and I sometimes create almost identical patches ;) > :) > I played with the same flags idea during mTHP bringup. > > And I think I prefer the flags version. > OK, wait for Andrew to pick it