From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ryan Roberts <ryan.roberts@arm.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm: add more readable thp_vma_allowable_order_foo()
Date: Thu, 25 Apr 2024 15:37:15 +0800 [thread overview]
Message-ID: <8dc0a47d-0cb1-4e89-8b9a-083921b22f68@huawei.com> (raw)
In-Reply-To: <5bf467d3-f596-4986-9e27-f2707efbe6a3@redhat.com>
On 2024/4/25 15:22, David Hildenbrand wrote:
> On 25.04.24 09:18, Kefeng Wang wrote:
>>
>>
>> On 2024/4/25 12:00, Matthew Wilcox wrote:
>>> On Thu, Apr 25, 2024 at 11:51:08AM +0800, Kefeng Wang wrote:
>>>> There are too many bool arguments in thp_vma_allowable_orders(), adding
>>>> some more readable thp_vma_allowable_order_foo(),
>>>
>>> Here's an alternative approach I came up with and forgot to send out.
>>> I take no position on which is better.
>>
>> Always confuse, either way is fine, even combine the two way, let's see
>> Ryan/David's option.
>
> It's shocking how Willy and I sometimes create almost identical patches ;)
>
:)
> I played with the same flags idea during mTHP bringup.
>
> And I think I prefer the flags version.
>
OK, wait for Andrew to pick it
next prev parent reply other threads:[~2024-04-25 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 3:51 Kefeng Wang
2024-04-25 4:00 ` Matthew Wilcox
2024-04-25 7:18 ` Kefeng Wang
2024-04-25 7:22 ` David Hildenbrand
2024-04-25 7:37 ` Kefeng Wang [this message]
2024-04-25 7:58 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc0a47d-0cb1-4e89-8b9a-083921b22f68@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox