From: Yang Shi <yang.shi@linux.alibaba.com>
To: Jan Hadrava <had@kam.mff.cuni.cz>, Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
wizards@kam.mff.cuni.cz, Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUG]: mm/vmscan.c: shrink_slab does not work correctly with memcg disabled via commandline
Date: Thu, 1 Aug 2019 14:10:05 -0700 [thread overview]
Message-ID: <8db8ec82-5a66-a221-09f3-66d0b8b9a75f@linux.alibaba.com> (raw)
In-Reply-To: <20190801174631.ulnlx3pi2g2rznzk@kam.mff.cuni.cz>
On 8/1/19 10:46 AM, Jan Hadrava wrote:
> On Thu, Aug 01, 2019 at 06:32:13PM +0200, Michal Hocko wrote:
>> On Thu 01-08-19 17:54:34, Jan Hadrava wrote:
>>> Just to be sure, i run my tests and patch proposed in the original thread
>>> solves my issue in all four affected stable releases:
>> Cc Andrew.
> Are you sure? I can't see any change in e-mail headers.
Cc'ed Andrew.
>
>> I assume we can assume your Tested-by tag?
> Well, these test only checked, that bug is present without the patch
> and disappears after applying it. Anyway: I am ok with it.
Thanks for testing it. I think you ran into the similar pre-mature OOM
issue as what Shakeel reported.
Andrew,
The patch has been in -mm tree
(mm-vmscan-check-if-mem-cgroup-is-disabled-or-not-before-calling-memcg-slab-shrinker.patch),
it seems we'd better to get this fix in the upcoming 5.3-rc so that it
could get into stable release soon.
>
>
prev parent reply other threads:[~2019-08-01 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 13:42 Jan Hadrava
2019-08-01 14:06 ` Michal Hocko
2019-08-01 15:54 ` Jan Hadrava
2019-08-01 16:32 ` Michal Hocko
2019-08-01 17:46 ` Jan Hadrava
2019-08-01 21:10 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8db8ec82-5a66-a221-09f3-66d0b8b9a75f@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=had@kam.mff.cuni.cz \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=wizards@kam.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox