From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A68C54FB3 for ; Mon, 26 May 2025 07:40:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 177646B007B; Mon, 26 May 2025 03:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1287B6B0082; Mon, 26 May 2025 03:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0166C6B0083; Mon, 26 May 2025 03:40:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D69056B007B for ; Mon, 26 May 2025 03:40:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4DFA4595CA for ; Mon, 26 May 2025 07:40:14 +0000 (UTC) X-FDA: 83484260748.08.3AA9E3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id E5084C000F for ; Mon, 26 May 2025 07:40:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpHOAlBf; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748245212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tgfPyghdNKeNstPw0hlFT74xvMeUiDTtqqo5DgSnAPo=; b=nvWXW2lQ0Ft6FvsUz/HLQB2tOjUed0CLAwdn59ny4H8MyZSnmH3S8qXRlX+nChRShkJKsD 4kO0RaI/vaTuctPXrXoAh613ZZerGBcP16QSdPbqvcegFD1d1nn3C17TENIkXPixeNinRQ i7wkXaK9Am/1gARNWnF70IOn6Tbjicw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpHOAlBf; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748245212; a=rsa-sha256; cv=none; b=buAMTq2wI1umoRw7hQA0SPXh4mxmg13x/t7WMNnR9nnmo9wCkHHr8HW5vGuK9LWX/ppUbe MWXVFJ2F5cimhduh2u8WipCGR/kTzAOZ4gY9KEKh+qoNgV2qZk5btLReU2cDQWm0qqhIMe upzwLPYx6kpdgXegWOeW8/Je6wc6884= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748245211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tgfPyghdNKeNstPw0hlFT74xvMeUiDTtqqo5DgSnAPo=; b=EpHOAlBfzRjQZGYrQ7iA4r6AqMh4IHm06ykfzLwnvwwM0Qvb9faKmhFTqV3RP3TV4aFuMo FJO32GqWR3wfpGw0K0tNFDptcK5cG6RSndJzUqXT9ydnznIjXyElL5luCtCsespLSti5bi G7qkT1IvRCCxiKS29G7RVKUhRK1azts= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-JCMGTE0mMMW0bE_l0iMG9w-1; Mon, 26 May 2025 03:40:09 -0400 X-MC-Unique: JCMGTE0mMMW0bE_l0iMG9w-1 X-Mimecast-MFC-AGG-ID: JCMGTE0mMMW0bE_l0iMG9w_1748245209 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a3561206b3so714550f8f.2 for ; Mon, 26 May 2025 00:40:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748245208; x=1748850008; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tgfPyghdNKeNstPw0hlFT74xvMeUiDTtqqo5DgSnAPo=; b=ky5aVZ2WUmX9D8/ia+/aiQVkkS0p1qtKMLWA+G0OMw0zFFS4uZCWE4m1i1nL4NWi/p qWdrFviVnJ79KOATEZtw7sIfSOXuHZL0xc+n2MhfUndi1n6ZMELHqUlvX0lv+Ap9WU/w wGsvZiqlCiDf4+dciiZWIiVeZ2D7aCkrZL/eaJfZqOg11zQj7gmwlAuYxDoA/hNm6Hl5 MK7iF7+7QhRhgh4k+abgH6pXuW5r3ieInQWfHgjt8GXj5vCaSjei7gypJiYFrgOmC+V8 DMOelCoVcyJDdg04e33mca9NDdNk+dvO948qat1IsozicTz5IoE1wtiE6wIBkR/UlGWW oMqQ== X-Gm-Message-State: AOJu0YwzXaFZDmXzcIhJX+75/96Ufh1TW8wxpd635akdxwSZ7wZqoAqt FL1Gsqz53Zc1wnmhLWAdFfacLxcVcYEo7+nCiSJmTtIy/EIBuIsALyiJR60y5tnhfZihtE2Oc7z C+ENUPRzr/bixK/PUJWpOUGpv475aXOxBpQgMbF9zDFSP07clufD4 X-Gm-Gg: ASbGncvUr+z7tjbi+JkeyeMpS6ZBDVI4Ydlc6TIdFas319EGoXFImuEgz4UCkEUbPtF zIAa7ECXzFB04weetRUW7JuuWxPhnPk4USZ0wqnLRR39oOwK+OewHYCBobxGvX6SOxx6WBOREau 3Jx10A4jbadmpf0DuB35oR/V8BhxVUA1iRjDLEQQro1LMAcBKh32LGZdsP0usHcnPYO02EVfeDg v5L7lk542U4LHovbDdh+xC0IRgdksW1OugOEWe0vfkIPckfFx5TdjVQC1c80TLeecYY4TMe5ug3 7/rxzH93fOKfM7hFnX+xd4OJFn0keQouC6fvfoiBFaY46NmftOGQkUwf3b7Tksqs4urgtgpyha2 9X8egfTRZnB2/iJt7ypU9j5RH0fqQf2g9vQSDO9Y= X-Received: by 2002:adf:e381:0:b0:3a4:cbbd:6345 with SMTP id ffacd0b85a97d-3a4cbbd64bcmr4362168f8f.13.1748245208629; Mon, 26 May 2025 00:40:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdSQcxG+7GRa/3fimPQAcX44Cqrbym2zy6oRVwNrciRP1tWml6Iz+Ki3+n+w3eQZrvNLH9CQ== X-Received: by 2002:adf:e381:0:b0:3a4:cbbd:6345 with SMTP id ffacd0b85a97d-3a4cbbd64bcmr4362143f8f.13.1748245208272; Mon, 26 May 2025 00:40:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:6500:e1c1:8216:4c25:efe4? (p200300d82f196500e1c182164c25efe4.dip0.t-ipconnect.de. [2003:d8:2f19:6500:e1c1:8216:4c25:efe4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4d6ae802esm3162648f8f.71.2025.05.26.00.40.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 00:40:07 -0700 (PDT) Message-ID: <8da60934-0670-4f8a-8bde-fa4de320cdbb@redhat.com> Date: Mon, 26 May 2025 09:40:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] xas_reload() in iter_xarray_populate_pages() To: Dev Jain , ziy@nvidia.com, willy@infradead.org, dhowells@redhat.com, hughd@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, aneesh.kumar@kernel.org References: <20250526063524.22597-1-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250526063524.22597-1-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pFQUtlMDa9cc5Z8lp3RjLpR-qta4qXugGeEy1nicsD4_1748245209 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E5084C000F X-Stat-Signature: ng7tdnfjcez7jd3wjo8oriuufrg8q648 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748245211-595595 X-HE-Meta: U2FsdGVkX192EBDgBKRQN4TU/F8utua3hye0I3zT1keLKj9FqLXnxBiw1TbCSJ2MZNrwxMtTgBtzxCNZXaqN1eUAsKEa+PUcfCA7q2c2mWipeSaBxc57onUp7cfL6vH5xK1Td3t520CFRKCmvXCOfBNapOzBD40TzEMjwYs7yI02BgGJla4RunKuauMak/99rrpiCr/C8mm33SqVKQ8m3hVLl/1eobyolbo0i7IhY2u3xowyfJN4dNDAqtS5StfHwJgfaXO86tsYIKVvZCPWV9aHnq4udVE70k+OS29Pik7z9gEK30q8qh0cn2wj2ndsOUIkrTjbEqgBpTDa56hQ4I6RbP8iZvw1W4GhgSoNnDONIc+b7iORd79kz+taz9yn9Y2ZDJUn+wLFqaTV1o5YlVDvzXqA2TmAMGwUbJVVBaTmLbs1y+bvOpVILdsqNGBYPnaH9PZ+58crR2ozCzWIQUJzEzfnNNDqqvy0ti0ShNp79vOpCjimSzomEyGKU632+tOXMMYJw7JzUYf9Aea7OCMnQzttX7Sf1d49el3p5S2voV/FgYFxvPeocfHK/nWo8mS6CRBSzjQ2ZF1aNgHTVQk4wdYtnqCaZ8/MhdqlI1JYKlC9RBz5vu3QrZLy90mmE2AaN19Hk5F5F5v2483SraE4rV1BituBwixqbyz0AkOc+oxGp01zXB7GQJTR8Oe+asHukSHhcAZBLXJOadwnTn4dyveJT0daqm5SZDURpA3ZGS1ijAschwotjpUcpqU/BS0KLuZIGTwfS8npqpx7KDhctZsNjD0eIXZyM8duJdmyRrSGrm466QyA8jorjAW4RwTlwPt5G7hGBklaHrTIgbZnh7tkanNGfIGQImlg0l0K8KcoSnSFM+FeGq9GqDcLOpUWU5YFWorGwRmhX0R3WdHv6hU9EO6XhLqw853c2Py7bUO+UeJ39OoVHja0NKJRg2+4Hi8RJdlgequSYpv 5XvSCINI m1lTFOqTw6OQXx33hqSbfTm1BrnRutqaWRqlb1q/Jbrl3GVIpNIA1KL1jYle/CBQRS7th7F0TrFjeMRfU/G8nIPFxu460zlElOxzSa7tYEB9vxoym5lHxh/yORSGdgB9LXUikiUZP1aiyGb3PGp94MXarsdkJcThCJ52SiJbSCQC8/4LKculc1uedJieIhm3rCM7FNjyqVOuK9MRM9LRpsmBbwpcJeHX2tEKWFpoROolNRabdTCHc7PyS2Ht2/6+xHXKzrYy0j21Cy9YYqT8cbroU4B/cJvUi5XkTtNaexbHKTxOTgr1ZldMHMd9EAgs4ObRJxtoXwxZHYVCuNY30yVI2s6zARfkVfHL3iucFl0ryi9e1J1pvw7UPS5q4/Ovef0cgFtmuNcAhuogDirVkPE5jj3rh+xBQ5emgBQrcH9+Tq7oftjfojSSTnL6ykDQMJc0Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.05.25 08:35, Dev Jain wrote: > Hello all, > > After doing an xas_load() and xas_retry(), we take neither a reference nor a lock > on the folio, and we do an xas_reload(). Is this just to reduce the time window > for a race? > > If the above is true, then, there is a negligible window between xas_load() and > xas_reload(), because only xas_retry() exists between them, so why to even reload()? The usual sequence for the pagecache is (see filemap_get_entry()) 1) xas_load(): Load the entry 2) xas_retry(): Test if we have to retry immediately 3) folio || xa_is_value(folio): check if the entry stores a folio 4) folio_try_get(): try getting a folio reference, might get freed concurrently, so a folio_get() is not safe 5) folio != xas_reload(&xas): recheck whether the entry was changed concurrently iter_xarray_get_pages()->iter_xarray_populate_pages() works on whatever xarray was provided to iov_iter_xarray(). erofs/netfs/orangefs seem to pass the pagecache ... so I would also assume that we have to use the same sequence as above. Willy and me had a look ad that code in b57f4f4f186d ("iov_iter: convert iter_xarray_populate_pages() to use folios"). But looking at it now, I think that code is incorrect. At least the folio_get() and reload-before-folio-get is weird. -- Cheers, David / dhildenb