From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE85EB64DD for ; Wed, 9 Aug 2023 08:39:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 044596B0071; Wed, 9 Aug 2023 04:39:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F35816B0074; Wed, 9 Aug 2023 04:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD5998E0001; Wed, 9 Aug 2023 04:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CDCA76B0071 for ; Wed, 9 Aug 2023 04:39:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94B6DC0E72 for ; Wed, 9 Aug 2023 08:39:08 +0000 (UTC) X-FDA: 81103916376.30.0F2BC2B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 4D0711A0017 for ; Wed, 9 Aug 2023 08:39:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q7T7JNBU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691570346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yWr9jPf9rYEHd/Ru68IehI3osMA3zfmFXP6TABwr0TU=; b=JDffJqLlSIZxcHvSot22tTJEUd6KHANEIxL3Qmd44DvmVz0sIWPi4USNkt+0h8TrvNmdgz kAU/m4b8Kk1qrrOnUfNtrL7Bi/kti0MfFUwLgkvhw5K7GLAzOFanYMtfcY/UT+RdyiGYAV EZ12uL0m6V3qoORsFocEtfitsX6zUKc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q7T7JNBU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691570346; a=rsa-sha256; cv=none; b=Q4qVLm9/BhA2ct/I2xYX753sRjxjNbX1dKmO9ps/SrfSjo/8waemEWKKtkdZ2w11uiqFbV JHyYoCT2Ma7BBuAwR4wk2yFExJOcLhA0xqePKEQGz2/4u85A9u8XEaMFKqKD0VwObcr3au mXyet5zo8rEwMkgJc/b1wrQUy40ATUE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691570345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yWr9jPf9rYEHd/Ru68IehI3osMA3zfmFXP6TABwr0TU=; b=Q7T7JNBULf39JHtR43WrGqEbjpssirzkGXvlH1BnhdqsiidwDM5yZqqvK6TQxblkEbT17+ 6uyR/xxOYBvL8+ow170rpmpvt9jg+IbUfRca324x+phFQKzGVDdAQ2SQyx80TPNrdVl7kt pucO1+qn4GGdSa9ii45QQ2X0LI80kok= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-Ac6Dk0rsOIui9Kwtn_jDqw-1; Wed, 09 Aug 2023 04:39:04 -0400 X-MC-Unique: Ac6Dk0rsOIui9Kwtn_jDqw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3175efd89e4so3407035f8f.1 for ; Wed, 09 Aug 2023 01:39:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691570343; x=1692175143; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yWr9jPf9rYEHd/Ru68IehI3osMA3zfmFXP6TABwr0TU=; b=cv8JON3HdO0b4wY+roLohZ0oZ/YAWg0fBs5npEFRwUaLMQ6PZtgeTWQIJDGErh5Uri 6dt4IEP9m2XPyvfX0IA1a6oXKvwXYDgCLL3TjYuizI74uK37+b2HbpqIHsXud2bnHWyd fsSWBaPzSWq2plza303vimoLKaLCAQ+GWAOwpIq8W2Y03g4MDm3kHtIIbudKXLuTvP9E JIaNgJXN51dfQ1Y3aZcSrrhXy26rgjtWG0RIsrwCcZBil5rjoLSQMmKfHhZ9/FmChcXV SsJbzUKQdoW+ugqgkijX35Gsp1UfxA1pjh3Udv52sRhVDAEZ/abrbDINzkX97PdteHGC hs9w== X-Gm-Message-State: AOJu0YyMoaHNqA1o2lv3CJgdYdEbf0sggR0TkaW8denzraxJlbgJVixA 7I+S/GG3rXxXSiSwYRatSrbGPLIddeWc30x9w4H1Q/f7bF7cbCrg4KLWH+JoHpNY/oyjSqerZO/ rLXTOXK0qny0= X-Received: by 2002:a5d:56ca:0:b0:317:5849:c2e0 with SMTP id m10-20020a5d56ca000000b003175849c2e0mr1215239wrw.9.1691570343098; Wed, 09 Aug 2023 01:39:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfKqI5bE6eFYpvnmDoa9+GlqCogti53TIGfkfxHGlIb6PPjm4qsIDOr78QCl6DvJHXVISRRQ== X-Received: by 2002:a5d:56ca:0:b0:317:5849:c2e0 with SMTP id m10-20020a5d56ca000000b003175849c2e0mr1215224wrw.9.1691570342688; Wed, 09 Aug 2023 01:39:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6800:9933:28db:f83a:ef5? (p200300cbc70e6800993328dbf83a0ef5.dip0.t-ipconnect.de. [2003:cb:c70e:6800:9933:28db:f83a:ef5]) by smtp.gmail.com with ESMTPSA id l12-20020adff48c000000b0030ada01ca78sm16005009wro.10.2023.08.09.01.39.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 01:39:02 -0700 (PDT) Message-ID: <8d99a10b-6579-cdcf-3b82-4859a3a35005@redhat.com> Date: Wed, 9 Aug 2023 10:39:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH -next] mm/memory_hotplug: fix error return code in add_memory_resource() To: Yang Yingliang , linux-mm@kvack.org Cc: osalvador@suse.de, akpm@linux-foundation.org, mhocko@suse.com, aneesh.kumar@linux.ibm.com References: <20230809081552.1351184-1-yangyingliang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230809081552.1351184-1-yangyingliang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4D0711A0017 X-Stat-Signature: tt6fhnmtsxdf1bzzapzkb5wwwqutabbc X-Rspam-User: X-HE-Tag: 1691570346-4260 X-HE-Meta: U2FsdGVkX1+V9tUb2/IKqms9qB6gMpZ/64nhYEeIHmda9RBiyjauTGCm5c5ZHaN8fek/gbQXvfoL1M3CszDyySfvFa0nNeFlRp2eqCtmIkEgMeROWYJFm/QP2afwltYP6U1uSFvAVflRJqA2I0BYukTuuRieoB+PAKKcbO4TuFhyCvSyChOLzgqWyv76iej098prvjlooEYVVN2T9AVD+UDquIZwzaov+f1eemtB/E4qadmE5Q7Rmm9R6fPrAE2cpznIs5WrfnAi1klAn4FGs+i6BT9uujQZHivpAVQ+1PqKGpsZd+VVME+AOIcLg1gPlrfazEGUkCdM/z23pvEHlCzgl6Hgs4xcusSKr0u3zVliLQL9hxGFqm56qQfC9sXCEIg/97HGX08/+pJ07BFwB2R42h2rjvne7FQ2wbiCXuEujMjLdynytZjwf3thsQYczjyxiA3vXYyT7X1JwIeh9yr5n/G/ehG5JCcW5HtT+jjHw/bPb4cezt/3DAnJ70iQseKbJMJ6XeOBmN7j04gs7WX2yP1FWz9IEPe4az79b44mBuNf+sVEE5DHkWZ9pxMcHuxuCvsNlDHYGaGqDvyGS22ecYpiT13k5Enf8j6UP9ndFjylKZ4qtTeGM4C9R7x8C+JAM3SvtNLrAVvyRuDea2HMhJ1QA5WWFprnqOn7WnnuKoK7muxdTrKVeVIUSHQkTJ09RDHM5lCt1cEhkRQFTMDszgCYxBABoIm7BHKGkab7p1eDPIzLAPS876gfG0bTAhWKvj1mGI7vBb4Vz3DbsB3eNWMU3V/qef6tIYegiHQ+s2XYEzLeR2Je7vS9tJd8T6qSNw1JmP7HiDceEDj8xlLPXAIJxSM1HhnLApJ5UQT+KeTHnkdZZ5dnSiwpbJiY1YtXPcz4sMNyu4O0BjRqy2bsABMo13QdohST3bcNm6liRLRJ3MLRejNMRyAlzvGEl3DAjrqJdoZjLs7nCBF GzSiRxnv GiWry38J9hy4YleSFE7O2bitp6tGoGK7CZaM6wUMwrztEseFYwZKEuWuRhV170f7lsONHAYSgGeNi631tI6NG+h1NC5hHRNK6+wAc2PraCh/YOfGsgv5lwxjiKeT2MS5H9m6gCxvMUOOKsJqwivYNgcPYAmOoLe5oYAMxEChF8YHF3R56i+ZELyYF8BxMDmlQfiuYhl2WXGrcALmB2OEk6zAgXCzikwp4eEV2CtKB/YqEuXouOFq2+ln26GOa9FKNKP0np0rxp6FjPy3ThGdbeClfR/+Vx5olGmnv2qo0kyN583bKvRSIw1RSJkS4BREz0tcu6rNWx3O0DPWKOQx4fINS0rOde2eHcyyiZv1WNSOABNu8GNFXaHyOBY8dUhxF7/iVIVkQRAlrbPnRogzT1BSEtf2VfS+19V3lJ3zdmm3YrYjQdu7qsqeGf+FxzCmXtp5bn4X1l7n+UT0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.08.23 10:15, Yang Yingliang wrote: > Set error return code to -ENOMEM, when kmalloc() fails. > > Fixes: ad3232df3e41 ("mm/memory_hotplug: embed vmem_altmap details in memory block") Commit id is not stable yet. > Signed-off-by: Yang Yingliang > --- > mm/memory_hotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..1b03f4ec6fd2 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1440,8 +1440,10 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > - if (!params.altmap) > + if (!params.altmap) { > + ret = -ENOMEM; > goto error; > + } LGTM, should be squashed into the original commit. Thanks! -- Cheers, David / dhildenb