From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851AAC433EF for ; Wed, 27 Apr 2022 09:48:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C78A76B0071; Wed, 27 Apr 2022 05:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C28E86B0075; Wed, 27 Apr 2022 05:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17586B0078; Wed, 27 Apr 2022 05:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id A1F9B6B0071 for ; Wed, 27 Apr 2022 05:48:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7F8BF22292 for ; Wed, 27 Apr 2022 09:48:24 +0000 (UTC) X-FDA: 79402183728.22.834813B Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 39FE040047 for ; Wed, 27 Apr 2022 09:48:21 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=xuyu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VBSFVkL_1651052899; Received: from 30.225.28.75(mailfrom:xuyu@linux.alibaba.com fp:SMTPD_---0VBSFVkL_1651052899) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Apr 2022 17:48:20 +0800 Message-ID: <8d903226-e83f-1476-b32f-50fe45e59246@linux.alibaba.com> Date: Wed, 27 Apr 2022 17:48:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] mm/huge_memory: do not overkill when splitting huge_zero_page Content-Language: en-US To: kernel test robot , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, akpm@linux-foundation.org, naoya.horiguchi@nec.com, shy828301@gmail.com References: <202204271636.UqHlxRwk-lkp@intel.com> From: Yu Xu In-Reply-To: <202204271636.UqHlxRwk-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 39FE040047 X-Stat-Signature: mro9733jwc5wq3aq4b7hq4bc95wmusho X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of xuyu@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=xuyu@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-HE-Tag: 1651052901-766519 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks! Sorry for that I tested only with CONFIG_DEBUG_VM enabled. This issue is triggered when CONFIG_DEBUG_VM is disabled. PATCH 2/2 has been resend. On 4/27/22 5:01 PM, kernel test robot wrote: > Hi Xu, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 > base: https://github.com/hnaz/linux-mm master > config: s390-randconfig-r044-20220425 (https://download.01.org/0day-ci/archive/20220427/202204271636.UqHlxRwk-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/988ec6e274e00e5706be7590a4a39427fbe856b1 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 > git checkout 988ec6e274e00e5706be7590a4a39427fbe856b1 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from include/linux/bits.h:22, > from include/linux/ratelimit_types.h:5, > from include/linux/printk.h:10, > from include/asm-generic/bug.h:22, > from arch/s390/include/asm/bug.h:68, > from include/linux/bug.h:5, > from include/linux/mmdebug.h:5, > from include/linux/mm.h:6, > from mm/huge_memory.c:8: > mm/huge_memory.c: In function 'split_huge_page_to_list': >>> include/linux/build_bug.h:30:33: error: void value not ignored as it ought to be > 30 | #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e)))) > | ^ > include/linux/mmdebug.h:81:43: note: in expansion of macro 'BUILD_BUG_ON_INVALID' > 81 | #define VM_WARN_ON_ONCE_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond) > | ^~~~~~~~~~~~~~~~~~~~ > mm/huge_memory.c:2553:13: note: in expansion of macro 'VM_WARN_ON_ONCE_PAGE' > 2553 | if (VM_WARN_ON_ONCE_PAGE(is_huge_zero_page(head), head)) > | ^~~~~~~~~~~~~~~~~~~~ > > > vim +30 include/linux/build_bug.h > > 527edbc18a70e74 Masahiro Yamada 2019-01-03 18 > 527edbc18a70e74 Masahiro Yamada 2019-01-03 19 /* Force a compilation error if a constant expression is not a power of 2 */ > 527edbc18a70e74 Masahiro Yamada 2019-01-03 20 #define __BUILD_BUG_ON_NOT_POWER_OF_2(n) \ > 527edbc18a70e74 Masahiro Yamada 2019-01-03 21 BUILD_BUG_ON(((n) & ((n) - 1)) != 0) > 527edbc18a70e74 Masahiro Yamada 2019-01-03 22 #define BUILD_BUG_ON_NOT_POWER_OF_2(n) \ > 527edbc18a70e74 Masahiro Yamada 2019-01-03 23 BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0)) > bc6245e5efd70c4 Ian Abbott 2017-07-10 24 > bc6245e5efd70c4 Ian Abbott 2017-07-10 25 /* > bc6245e5efd70c4 Ian Abbott 2017-07-10 26 * BUILD_BUG_ON_INVALID() permits the compiler to check the validity of the > bc6245e5efd70c4 Ian Abbott 2017-07-10 27 * expression but avoids the generation of any code, even if that expression > bc6245e5efd70c4 Ian Abbott 2017-07-10 28 * has side-effects. > bc6245e5efd70c4 Ian Abbott 2017-07-10 29 */ > bc6245e5efd70c4 Ian Abbott 2017-07-10 @30 #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e)))) > bc6245e5efd70c4 Ian Abbott 2017-07-10 31 > -- Thanks, Yu