From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=dAXo=HA=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3213CC433E0
	for <linux-mm@archiver.kernel.org>; Fri, 29 Jan 2021 19:53:14 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 7F97464E10
	for <linux-mm@archiver.kernel.org>; Fri, 29 Jan 2021 19:53:13 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F97464E10
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id AA5138D0002; Fri, 29 Jan 2021 14:53:12 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id A2D448D0001; Fri, 29 Jan 2021 14:53:12 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 8F56C8D0002; Fri, 29 Jan 2021 14:53:12 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187])
	by kanga.kvack.org (Postfix) with ESMTP id 75E3B8D0001
	for <linux-mm@kvack.org>; Fri, 29 Jan 2021 14:53:12 -0500 (EST)
Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay04.hostedemail.com (Postfix) with ESMTP id 2EDF91DE1
	for <linux-mm@kvack.org>; Fri, 29 Jan 2021 19:53:12 +0000 (UTC)
X-FDA: 77759861424.21.spade24_0c0bd82275aa
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin21.hostedemail.com (Postfix) with ESMTP id EE15A180442C4
	for <linux-mm@kvack.org>; Fri, 29 Jan 2021 19:53:11 +0000 (UTC)
X-HE-Tag: spade24_0c0bd82275aa
X-Filterd-Recvd-Size: 3756
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by imf38.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Fri, 29 Jan 2021 19:53:10 +0000 (UTC)
IronPort-SDR: 995g6f0xkuaN1QD5uE9LyY9hMPxsI59GFZGYWPK3fxc4l1wTAQkGNm00G+BdPuLfe7ohfBVRbU
 M1lRhry5drqA==
X-IronPort-AV: E=McAfee;i="6000,8403,9879"; a="199323479"
X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; 
   d="scan'208";a="199323479"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 11:53:08 -0800
IronPort-SDR: +mj39OBP743gPD+7++bzmhvPPBqDOqmZztGCGnQxxTqwCoqylBM8mo9huhwBKWmuMHuPIE18m+
 pKgnaNZAm7ew==
X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; 
   d="scan'208";a="410848169"
Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.73.214]) ([10.212.73.214])
  by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 11:53:02 -0800
Subject: Re: [PATCH v18 24/25] x86/cet/shstk: Add arch_prctl functions for
 shadow stack
To: Dave Hansen <dave.hansen@intel.com>, x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org,
 linux-api@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
 Andy Lutomirski <luto@kernel.org>, Balbir Singh <bsingharora@gmail.com>,
 Borislav Petkov <bp@alien8.de>, Cyrill Gorcunov <gorcunov@gmail.com>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 Eugene Syromiatnikov <esyr@redhat.com>, Florian Weimer <fweimer@redhat.com>,
 "H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
 Jonathan Corbet <corbet@lwn.net>, Kees Cook <keescook@chromium.org>,
 Mike Kravetz <mike.kravetz@oracle.com>, Nadav Amit <nadav.amit@gmail.com>,
 Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
 Peter Zijlstra <peterz@infradead.org>, Randy Dunlap <rdunlap@infradead.org>,
 "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
 Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>,
 Dave Martin <Dave.Martin@arm.com>, Weijiang Yang <weijiang.yang@intel.com>,
 Pengfei Xu <pengfei.xu@intel.com>
References: <20210127212524.10188-1-yu-cheng.yu@intel.com>
 <20210127212524.10188-25-yu-cheng.yu@intel.com>
 <ba39586d-25b6-6ea5-19c3-adf17b59f910@intel.com>
 <761ae8ce-0560-24cc-e6f7-684475cb3708@intel.com>
 <179fe87e-8fd1-9a26-e4f6-a508b45a54d4@intel.com>
From: "Yu, Yu-cheng" <yu-cheng.yu@intel.com>
Message-ID: <8d8bccab-12f3-0ecb-f2b2-91c26f82958a@intel.com>
Date: Fri, 29 Jan 2021 11:53:01 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <179fe87e-8fd1-9a26-e4f6-a508b45a54d4@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 1/29/2021 11:15 AM, Dave Hansen wrote:
> On 1/29/21 10:56 AM, Yu, Yu-cheng wrote:
>> On 1/29/2021 9:07 AM, Dave Hansen wrote:
>>> On 1/27/21 1:25 PM, Yu-cheng Yu wrote:
[...]
>>> What's the point of doing copy_status_to_user() if the processor does=
n't
>>> support CET?=C2=A0 In other words, shouldn't this be below the CPU fe=
ature
>>> check?
>>
>> The thought was to tell the difference between the kernel itself does
>> not support CET and the system does not have CET.=C2=A0 And, if the ke=
rnel
>> supports it, show CET status of the thread.
>=20
> Why would that matter to userspace?
>=20
> If they want to know if the processor has CET support there are existin=
g
> ways to do it.  I don't think this should be part of the ABI.
>=20

Ok, I will make it:

if (!cpu_feature_enabled(X86_FEATURE_CET))
	...