From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D487FC433EF for ; Mon, 25 Apr 2022 13:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A7976B0074; Mon, 25 Apr 2022 09:39:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556D36B0075; Mon, 25 Apr 2022 09:39:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F7B76B0078; Mon, 25 Apr 2022 09:39:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 318ED6B0074 for ; Mon, 25 Apr 2022 09:39:04 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 013E861901 for ; Mon, 25 Apr 2022 13:39:03 +0000 (UTC) X-FDA: 79395507408.01.E7AC962 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 28B6A1A003E for ; Mon, 25 Apr 2022 13:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650893942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U/nJVlrnckJY6gYEpBiKmEsvpHCZZ3VcmakjaLJFA5o=; b=AIEHxs3d55xt6BHZvhOJR951Ys57i6FjaaA1JIHKbiCNK1So/+NT+xufF7nXygMoEMjYSY 5ibQAEOfMxn43skc1qWBBB5G7gxXXIGfjH1iJioNF2Mtan2ZbAwH9yX0/fsVTLZrs1KXOZ kcKhK/+doatIYRBN1JjuqMGcoFDygFc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-jYJ0j5GUNmuJdx2pHq9Qqw-1; Mon, 25 Apr 2022 09:39:01 -0400 X-MC-Unique: jYJ0j5GUNmuJdx2pHq9Qqw-1 Received: by mail-wr1-f71.google.com with SMTP id v29-20020adfa1dd000000b0020ad932b7c0so864167wrv.0 for ; Mon, 25 Apr 2022 06:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=U/nJVlrnckJY6gYEpBiKmEsvpHCZZ3VcmakjaLJFA5o=; b=MlO08B/bWlqz1Wsr06boKHpBdgVaFgbl5BnDpl3rFicx2Fvz74oRk7PMh0628Z6Lx5 Tn4vG48I7nFre9OBpZdNbhKAPqxkCTDItzOcUj5YYIZgJysVA/ObkDTgZb0mLpJsUDj5 jrPAUmkhKdKVsd81FLrYcba05XayUxzr20O3+j+CQn/EdbdpoY/7Oo90+jYVThe6eN2D tzIOxPsFamD2b2FbAZZLVbHw5yb6mY5WWkhI0rOyg3QclqK/F1MzGncFtR073L+SVGQ8 2zfVus9rAgmoGhHuwSsz2Pj7WV4BLdPlHsKRnzl7xwU4FrTKGwEBplFtqqlmeSqJmzlp Do8A== X-Gm-Message-State: AOAM532Odyk3OBDy5Z4O63z20cOKHxFhnaD47Uq3doIUR6z4lCBy7CzD aWmBZFlTpLXzSnxNquHQPB5+5d4FtAp59j6MVCIORzEVdm8O77p5UTx+rtuM92OXPueMNd8/aDF wT3K442LdO/E= X-Received: by 2002:adf:df05:0:b0:20a:c402:6811 with SMTP id y5-20020adfdf05000000b0020ac4026811mr14592006wrl.275.1650893940357; Mon, 25 Apr 2022 06:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl7suWwaROQq9b2PYFvA50sZlPXavnDV5jI48/WjywXp6wyfpRVASVT+F8KZzW6eKW4s1J6A== X-Received: by 2002:adf:df05:0:b0:20a:c402:6811 with SMTP id y5-20020adfdf05000000b0020ac4026811mr14591990wrl.275.1650893940038; Mon, 25 Apr 2022 06:39:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:490d:ed6a:8b22:223a? (p200300cbc700fc00490ded6a8b22223a.dip0.t-ipconnect.de. [2003:cb:c700:fc00:490d:ed6a:8b22:223a]) by smtp.gmail.com with ESMTPSA id e30-20020adf9bde000000b0020ad8ffb0f9sm3844998wrc.69.2022.04.25.06.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 06:38:59 -0700 (PDT) Message-ID: <8d80cb56-4216-2d5b-7ab5-8abd60d2871c@redhat.com> Date: Mon, 25 Apr 2022 15:38:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 1/5] memblock tests: update style of comments for memblock_add_*() functions To: Rebecca Mckeever , outreachy@lists.linux.dev Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <2ea997e7b5c4737d674a2e5d9288938d557cb0c3.1650633253.git.remckee0@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2ea997e7b5c4737d674a2e5d9288938d557cb0c3.1650633253.git.remckee0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 28B6A1A003E X-Stat-Signature: hgdsx1wp5gd4toe8jha5xmwe4ywhykyy X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AIEHxs3d; spf=none (imf19.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam09 X-HE-Tag: 1650893940-403646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.04.22 15:32, Rebecca Mckeever wrote: > Update comments in memblock_add_*() functions to match the style used > in tests/alloc_*.c by rewording to make the expected outcome more apparent > and, if more than one memblock is involved, adding a visual of the > memory blocks. > > Signed-off-by: Rebecca Mckeever Please make sure to not drop Rb/Ack tags and instead carry them along when you resend patches. This, for example, makes it easier for reviewers to spot what needs attention and review. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb