From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2D9C021B8 for ; Wed, 26 Feb 2025 10:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3501C6B0085; Wed, 26 Feb 2025 05:58:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3005E6B0089; Wed, 26 Feb 2025 05:58:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0C1280003; Wed, 26 Feb 2025 05:58:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EBC996B0085 for ; Wed, 26 Feb 2025 05:58:14 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9EA69B67A4 for ; Wed, 26 Feb 2025 10:58:14 +0000 (UTC) X-FDA: 83161796508.06.7067275 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 3A56740002 for ; Wed, 26 Feb 2025 10:58:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zqQI5+yM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=40ObUHLU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zqQI5+yM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=40ObUHLU; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740567492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WvQMaogfR4p5vXml1R1gl73Lc4GXJegwVY6rJmvbNrQ=; b=7cozGuhMh5s0VAYzhHQqMFZWO6YlMHcclUk8VaZ44tYSWGIsm1zpJ2CS8mXGXRXrSfnlnw ahqMtRaJ19bf4qyFFPU9vwEdzKUU5F7pn8x/MS9D8VBWEpejXydctBZpAcnJjFO45w/BRu 6qKjRntJyqIckk0E5pFgSXNXOkQHD4k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zqQI5+yM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=40ObUHLU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zqQI5+yM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=40ObUHLU; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740567492; a=rsa-sha256; cv=none; b=VSOZS3xREi6httVn5hVUsuGKUhtDELzjZfVKg4cpFoxG0Ki8pq27d/PZMObiHBqJinGfWW FsjkNzZlRGpW5GghPjMPAStfZNTHdpEOF0RW8JBUr0TZ6P4l0ryBNAXQLE7/AD/RJYLOov 8/TpnwfYNnMuIyP/E+grnMY2gAnfs9c= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 68A6221184; Wed, 26 Feb 2025 10:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740567490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvQMaogfR4p5vXml1R1gl73Lc4GXJegwVY6rJmvbNrQ=; b=zqQI5+yMO6yV3jxwiKP42S0fE0YF0JhLpTM+nLG6l1933VXSW+zLE2lfLXoRZfvJxeWuu4 G3y8qKDjpgk2MiX8YP7+xy354Y+FKgQb5ewbL9NoYSjlf+35YjyS3AqA1PujhidnbV4mRU mi4dVNgoXqxqzP9CbBcvFCHyd+BqRLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740567490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvQMaogfR4p5vXml1R1gl73Lc4GXJegwVY6rJmvbNrQ=; b=40ObUHLUWyTtsyo7VM6q8v3Scind4/Ubjn28AvhTB1BWxzficxhr/BOj1Ak9F9rSwSj6UN +Dtsqe0OY/rifSBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740567490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvQMaogfR4p5vXml1R1gl73Lc4GXJegwVY6rJmvbNrQ=; b=zqQI5+yMO6yV3jxwiKP42S0fE0YF0JhLpTM+nLG6l1933VXSW+zLE2lfLXoRZfvJxeWuu4 G3y8qKDjpgk2MiX8YP7+xy354Y+FKgQb5ewbL9NoYSjlf+35YjyS3AqA1PujhidnbV4mRU mi4dVNgoXqxqzP9CbBcvFCHyd+BqRLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740567490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvQMaogfR4p5vXml1R1gl73Lc4GXJegwVY6rJmvbNrQ=; b=40ObUHLUWyTtsyo7VM6q8v3Scind4/Ubjn28AvhTB1BWxzficxhr/BOj1Ak9F9rSwSj6UN +Dtsqe0OY/rifSBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3DA491377F; Wed, 26 Feb 2025 10:58:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HQrvDcLzvmdaeQAAD6G6ig (envelope-from ); Wed, 26 Feb 2025 10:58:10 +0000 Message-ID: <8d7aabb2-2836-4c09-9fc7-8bde271e7f23@suse.cz> Date: Wed, 26 Feb 2025 11:59:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy() To: Uladzislau Rezki , Keith Busch Cc: "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik , linux-nvme@lists.infradead.org, leitao@debian.org References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-6-ea79102f428c@suse.cz> <2811463a-751f-4443-9125-02628dc315d9@suse.cz> From: Vlastimil Babka Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: k6ps8kkgcnpbe6j1cwfrijtcx8pu81ir X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3A56740002 X-HE-Tag: 1740567491-253520 X-HE-Meta: U2FsdGVkX1/tBBrJ1q2mxAAa04iZOvYNKQOEaPFLk5cVEMXjWvB//GCXN4B8x6EOnQMKe5mEhA6XqmSGXddzezUBX3sxBmrnP/7F0NJ0sJbuJfxOVptrfDaXiiWyjX4ZlJAnQ0cCPupLLuAHaL4vAQILkmc0FNe9+wQQTXkHTigVNv22Duheioe9hcRcLvm7+OLfw60xpVDP84vlNCFTOiH/kevME4F3N9auhCFf7VAzplz//LEyzZd0tT9FnQeVMwo50+GL+j3LsjmIH3+3dxvA0mOLeC+tJEYkhiYaROfgU+adH1WM6FMemiPbbPODOEcKqxw9mQ8cf6lrcLvCX5PKmXb4WJwvxkkcL2QrE9PRKb8ZV57iBtEVcjwf5B8zTq0aMGwDvi0WqIGJDuW7MuAh9JE+MmVc21AWYsyLD3Oh6gfehSWTg3YXhyt6LTMRJlAZN/3SpFzSaAANtipqCf1cjcu0AdIKCUP/9HrNiNBFFPQQvRkZcQptHsesiIEGRlUnuqWPeK5gr5E3mQTIvqbufCUnXobAjmCzEUaLSTEgk1KuTSBMm+lsjYB81Wt4h0HwrnETcrCbdZDVWICm4EOhmTKRoxDiSkR+IJGo8ch8Qh3HlNAjFpCaTdP34Qq8q9ZqRNhSMS7G38+euG6ckF297yftKqud/OzekhhMyXMK7T2kyUV1aMilwXL6asYKqGS/2+OckWh0i+3rv8oWWvZuHHbKfVyWtH2Js7ARpxAU8OUuqNME9DJDvZghhjNthZ6wItHwh7XIVPewHDlJsqPd5Xwsrksz72hcFKXmY8FRAgvHYVzZ1HhmBRqgC2H/KMUJhcrcAKNagrRba6v7PzB1/fe79WJBVT90yWu2ZMh+jEGdSywcS7sHrc7BOf6UJdKEyMMhPktj12HDf6lOCLeSFjumzrTfCBm7ckqFzT7ymH+rOIm5BMxI3lWfCAjUW7CeXzuyamxR9YH4G5w +UWKyGTW RXdAMqvMLNcT8HWHdLkd8ibtixlCy/6nJmMdSmKlg3GjKFs/L24NW/CEsnH/bLlAgBusrtJG1D8Dnn2OmTwOchzVKyZiQnjpMo8H9LLfwTmlN/sH0/sxiKC60uxqSTZ9XDevMBtX60PTVbGP8C2xCbCUwOk/GA4cE6UNIeIw5Pd68ZPypShaJU9avLZZOmRc5CRpmT/NeHLaGlBVH2XSNH9tsw6R6G1OkeE4tAcfM6cwsqQHFY1iy65M5oecDs/njDNJFowC4jExIq6PXVyWe9xx9kG+RgMUOdRLazA2+L2HNIMjh7+HBIGsI4CCZUojzQv6lqp5Q9idMrr8WpuJ9wJr3UPo+ME07uoDYmdL7wWXl9aJFM1Gwd908Iqu+5U/8jnRd0e3wBV/1Ts65q//bJC9REQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/25/25 7:21 PM, Uladzislau Rezki wrote: >> > WQ_MEM_RECLAIM-patch fixes this for me: Sounds good, can you send a formal patch then? Some nits below: > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 4030907b6b7d..1b5ed5512782 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1304,6 +1304,8 @@ module_param(rcu_min_cached_objs, int, 0444); > static int rcu_delay_page_cache_fill_msec = 5000; > module_param(rcu_delay_page_cache_fill_msec, int, 0444); > > +static struct workqueue_struct *rcu_reclaim_wq; > + > /* Maximum number of jiffies to wait before draining a batch. */ > #define KFREE_DRAIN_JIFFIES (5 * HZ) > #define KFREE_N_BATCHES 2 > @@ -1632,10 +1634,10 @@ __schedule_delayed_monitor_work(struct kfree_rcu_cpu *krcp) > if (delayed_work_pending(&krcp->monitor_work)) { > delay_left = krcp->monitor_work.timer.expires - jiffies; > if (delay < delay_left) > - mod_delayed_work(system_unbound_wq, &krcp->monitor_work, delay); > + mod_delayed_work(rcu_reclaim_wq, &krcp->monitor_work, delay); > return; > } > - queue_delayed_work(system_unbound_wq, &krcp->monitor_work, delay); > + queue_delayed_work(rcu_reclaim_wq, &krcp->monitor_work, delay); > } > > static void > @@ -1733,7 +1735,7 @@ kvfree_rcu_queue_batch(struct kfree_rcu_cpu *krcp) > // "free channels", the batch can handle. Break > // the loop since it is done with this CPU thus > // queuing an RCU work is _always_ success here. > - queued = queue_rcu_work(system_unbound_wq, &krwp->rcu_work); > + queued = queue_rcu_work(rcu_reclaim_wq, &krwp->rcu_work); > WARN_ON_ONCE(!queued); > break; > } > @@ -1883,7 +1885,7 @@ run_page_cache_worker(struct kfree_rcu_cpu *krcp) > if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING && > !atomic_xchg(&krcp->work_in_progress, 1)) { > if (atomic_read(&krcp->backoff_page_cache_fill)) { > - queue_delayed_work(system_unbound_wq, > + queue_delayed_work(rcu_reclaim_wq, > &krcp->page_cache_work, > msecs_to_jiffies(rcu_delay_page_cache_fill_msec)); > } else { > @@ -2120,6 +2122,10 @@ void __init kvfree_rcu_init(void) > int i, j; > struct shrinker *kfree_rcu_shrinker; > > + rcu_reclaim_wq = alloc_workqueue("rcu_reclaim", Should we name it "kvfree_rcu_reclaim"? rcu_reclaim sounds too generic as if it's part of rcu itself? > + WQ_UNBOUND | WQ_MEM_RECLAIM, 0); Do we want WQ_SYSFS? Or maybe only when someone asks, with a use case? Thanks, Vlastimil > + WARN_ON(!rcu_reclaim_wq); > + > /* Clamp it to [0:100] seconds interval. */ > if (rcu_delay_page_cache_fill_msec < 0 || > rcu_delay_page_cache_fill_msec > 100 * MSEC_PER_SEC) { > > > it passes: > > > [ 15.972416] KTAP version 1 > [ 15.972421] 1..1 > [ 15.973467] KTAP version 1 > [ 15.973470] # Subtest: slub_test > [ 15.973472] # module: slub_kunit > [ 15.973474] 1..10 > [ 15.974483] ok 1 test_clobber_zone > [ 15.974927] ok 2 test_next_pointer > [ 15.975308] ok 3 test_first_word > [ 15.975672] ok 4 test_clobber_50th_byte > [ 15.976035] ok 5 test_clobber_redzone_free > [ 15.976128] stackdepot: allocating hash table of 1048576 entries via kvcalloc > [ 15.979505] ok 6 test_kmalloc_redzone_access > [ 16.014408] ok 7 test_kfree_rcu > [ 17.726602] ok 8 test_kfree_rcu_wq_destroy > [ 17.750323] ok 9 test_leak_destroy > [ 17.750883] ok 10 test_krealloc_redzone_zeroing > [ 17.750887] # slub_test: pass:10 fail:0 skip:0 total:10 > [ 17.750890] # Totals: pass:10 fail:0 skip:0 total:10 > [ 17.750891] ok 1 slub_test > > > -- > Uladzislau Rezki