From: Alex Ghiti <alex@ghiti.fr>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Oscar Salvador <osalvador@suse.de>,
David Rientjes <rientjes@google.com>,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"hughd@google.com" <hughd@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] mm/hugetlb: Fix unsigned overflow in __nr_hugepages_store_common()
Date: Tue, 5 Mar 2019 16:41:55 -0500 [thread overview]
Message-ID: <8d77e5ba-3de6-801c-8497-6a219665bc57@ghiti.fr> (raw)
In-Reply-To: <9a23edc9-b2e5-839e-30d6-0723cb98246d@oracle.com>
On 3/5/19 4:35 PM, Mike Kravetz wrote:
> On 3/5/19 1:16 PM, Andrew Morton wrote:
>> On Mon, 4 Mar 2019 20:15:40 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>
>>> Andrew, this is on top of Alexandre Ghiti's "hugetlb: allow to free gigantic
>>> pages regardless of the configuration" patch. Both patches modify
>>> __nr_hugepages_store_common(). Alex's patch is going to change slightly
>>> in this area.
>> OK, thanks, I missed that. Are the changes significant?
>>
> No, changes should be minor. IIRC, just checking for a condition in an
> error path.
I will send the v5 of this patch tomorrow, I was waiting for architecture
maintainer remarks. I still miss sh, but I'm confident on this change.
Alex
next prev parent reply other threads:[~2019-03-05 21:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 1:32 Jing Xiangfeng
2019-02-25 0:45 ` Mike Kravetz
2019-02-25 3:17 ` David Rientjes
2019-02-25 16:49 ` Mike Kravetz
2019-02-25 18:19 ` Mike Kravetz
2019-02-25 19:17 ` David Rientjes
2019-02-26 2:22 ` Jing Xiangfeng
2019-02-26 6:21 ` David Rientjes
2019-02-26 19:32 ` Mike Kravetz
2019-02-26 22:36 ` Andrew Morton
2019-02-27 0:03 ` Mike Kravetz
2019-03-04 13:48 ` Oscar Salvador
2019-03-05 0:03 ` Naoya Horiguchi
2019-03-05 4:15 ` Mike Kravetz
2019-03-05 21:16 ` Andrew Morton
2019-03-05 21:35 ` Mike Kravetz
2019-03-05 21:41 ` Alex Ghiti [this message]
2019-03-06 9:41 ` Oscar Salvador
2019-03-07 0:17 ` Mike Kravetz
2019-03-04 6:00 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d77e5ba-3de6-801c-8497-6a219665bc57@ghiti.fr \
--to=alex@ghiti.fr \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jingxiangfeng@huawei.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox